Re: [RFC PATCH 1/5] iommu/arm-smmu-v3: Refactor arm_smmu_setup_irqs

[Pranjal Shrivastava <praan@google.com>]

On Tue, Mar 25, 2025 at 09:19:36AM -0700, Daniel Mentz wrote:
> On Tue, Mar 18, 2025 at 5:43 PM Pranjal Shrivastava <praan@google.com> wrote:
> > @@ -4754,6 +4773,13 @@ static int arm_smmu_device_probe(struct platform_device *pdev)
> >         /* Check for RMRs and install bypass STEs if any */
> >         arm_smmu_rmr_install_bypass_ste(smmu);
> >
> > +       /* Setup interrupt handlers */
> > +       ret = arm_smmu_setup_irqs(smmu);
> > +       if (ret) {
> > +               dev_err(smmu->dev, "failed to setup irqs\n");
> > +               return ret;
> 
> Do you need
> 
> goto err_free_iopf;
> 
> here instead of return ret?
> 

Yes! Great catch! Thanks!

> > +       }
> > +
> >         /* Reset the device */
> >         ret = arm_smmu_device_reset(smmu);
> >         if (ret)

Thanks,
Praan