From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Realtek linux nic maintainers <nic_swsd@realtek.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next] r8169: remove unused flag RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE
Date: Tue, 3 Dec 2024 14:01:02 +0100 [thread overview]
Message-ID: <Z08BDgxPVVKbjJZo@mev-dev.igk.intel.com> (raw)
In-Reply-To: <d9dd214b-3027-4f60-b0e8-6f34a0c76582@gmail.com>
On Mon, Dec 02, 2024 at 09:14:35PM +0100, Heiner Kallweit wrote:
> After 854d71c555dfc3 ("r8169: remove original workaround for RTL8125
> broken rx issue") this flag isn't used any longer. So remove it.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/net/ethernet/realtek/r8169_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index 739707a7b..4b96b4ad8 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -623,7 +623,6 @@ struct rtl8169_tc_offsets {
>
> enum rtl_flag {
> RTL_FLAG_TASK_RESET_PENDING,
> - RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE,
> RTL_FLAG_TASK_TX_TIMEOUT,
> RTL_FLAG_MAX
> };
> @@ -4723,8 +4722,6 @@ static void rtl_task(struct work_struct *work)
> reset:
> rtl_reset_work(tp);
> netif_wake_queue(tp->dev);
> - } else if (test_and_clear_bit(RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE, tp->wk.flags)) {
> - rtl_reset_work(tp);
> }
> }
>
> --
> 2.47.1
>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Thanks
>
>
next prev parent reply other threads:[~2024-12-03 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 20:14 [PATCH net-next] r8169: remove unused flag RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE Heiner Kallweit
2024-12-03 13:01 ` Michal Swiatkowski [this message]
2024-12-04 3:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z08BDgxPVVKbjJZo@mev-dev.igk.intel.com \
--to=michal.swiatkowski@linux.intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.