* [PATCH net-next] r8169: remove unused flag RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE
@ 2024-12-02 20:14 Heiner Kallweit
2024-12-03 13:01 ` Michal Swiatkowski
2024-12-04 3:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Heiner Kallweit @ 2024-12-02 20:14 UTC (permalink / raw)
To: Realtek linux nic maintainers, Andrew Lunn, Paolo Abeni,
Jakub Kicinski, David Miller, Eric Dumazet, Simon Horman
Cc: netdev@vger.kernel.org
After 854d71c555dfc3 ("r8169: remove original workaround for RTL8125
broken rx issue") this flag isn't used any longer. So remove it.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/realtek/r8169_main.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index 739707a7b..4b96b4ad8 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -623,7 +623,6 @@ struct rtl8169_tc_offsets {
enum rtl_flag {
RTL_FLAG_TASK_RESET_PENDING,
- RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE,
RTL_FLAG_TASK_TX_TIMEOUT,
RTL_FLAG_MAX
};
@@ -4723,8 +4722,6 @@ static void rtl_task(struct work_struct *work)
reset:
rtl_reset_work(tp);
netif_wake_queue(tp->dev);
- } else if (test_and_clear_bit(RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE, tp->wk.flags)) {
- rtl_reset_work(tp);
}
}
--
2.47.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] r8169: remove unused flag RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE
2024-12-02 20:14 [PATCH net-next] r8169: remove unused flag RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE Heiner Kallweit
@ 2024-12-03 13:01 ` Michal Swiatkowski
2024-12-04 3:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Michal Swiatkowski @ 2024-12-03 13:01 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Realtek linux nic maintainers, Andrew Lunn, Paolo Abeni,
Jakub Kicinski, David Miller, Eric Dumazet, Simon Horman,
netdev@vger.kernel.org
On Mon, Dec 02, 2024 at 09:14:35PM +0100, Heiner Kallweit wrote:
> After 854d71c555dfc3 ("r8169: remove original workaround for RTL8125
> broken rx issue") this flag isn't used any longer. So remove it.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/net/ethernet/realtek/r8169_main.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index 739707a7b..4b96b4ad8 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -623,7 +623,6 @@ struct rtl8169_tc_offsets {
>
> enum rtl_flag {
> RTL_FLAG_TASK_RESET_PENDING,
> - RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE,
> RTL_FLAG_TASK_TX_TIMEOUT,
> RTL_FLAG_MAX
> };
> @@ -4723,8 +4722,6 @@ static void rtl_task(struct work_struct *work)
> reset:
> rtl_reset_work(tp);
> netif_wake_queue(tp->dev);
> - } else if (test_and_clear_bit(RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE, tp->wk.flags)) {
> - rtl_reset_work(tp);
> }
> }
>
> --
> 2.47.1
>
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Thanks
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] r8169: remove unused flag RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE
2024-12-02 20:14 [PATCH net-next] r8169: remove unused flag RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE Heiner Kallweit
2024-12-03 13:01 ` Michal Swiatkowski
@ 2024-12-04 3:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-12-04 3:10 UTC (permalink / raw)
To: Heiner Kallweit
Cc: nic_swsd, andrew+netdev, pabeni, kuba, davem, edumazet, horms,
netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 2 Dec 2024 21:14:35 +0100 you wrote:
> After 854d71c555dfc3 ("r8169: remove original workaround for RTL8125
> broken rx issue") this flag isn't used any longer. So remove it.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/net/ethernet/realtek/r8169_main.c | 3 ---
> 1 file changed, 3 deletions(-)
Here is the summary with links:
- [net-next] r8169: remove unused flag RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE
https://git.kernel.org/netdev/net-next/c/2e20bf8cc057
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-04 3:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-02 20:14 [PATCH net-next] r8169: remove unused flag RTL_FLAG_TASK_RESET_NO_QUEUE_WAKE Heiner Kallweit
2024-12-03 13:01 ` Michal Swiatkowski
2024-12-04 3:10 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.