All of lore.kernel.org
 help / color / mirror / Atom feed
From: Long Li <leo.lilong@huawei.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <brauner@kernel.org>, <djwong@kernel.org>, <cem@kernel.org>,
	<linux-xfs@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
	<yi.zhang@huawei.com>, <houtao1@huawei.com>,
	<yangerkun@huawei.com>
Subject: Re: [PATCH v4 1/2] iomap: fix zero padding data issue in concurrent append writes
Date: Mon, 25 Nov 2024 21:42:48 +0800	[thread overview]
Message-ID: <Z0R-2Jmj2u-Cqwxu@localhost.localdomain> (raw)
In-Reply-To: <Z0Qb1HKqWJKyR5Q0@infradead.org>

On Sun, Nov 24, 2024 at 10:40:20PM -0800, Christoph Hellwig wrote:
> On Mon, Nov 25, 2024 at 10:33:40AM +0800, Long Li wrote:
> >   1. collect reviewed tag
> >   2. Modify the comment of io_size and iomap_ioend_size_aligned().
> >   3. Add explain of iomap_ioend_size_aligned() to commit message.
> 
> Just curious, did you look into Brian's suggestions to do away
> with the rounding up entirely as there is not much practical benefit
> in merging behind EOF?
> 
> 

I agree with Brian's point. The scenarios where rounding up io_size
enables ioend merging are quite rare, so the practical benefits are
limited, though such cases can still exist. Therefore, I think both
approaches are acceptable as there doesn't seem to be a significant
difference between them. 

Thanks,
Long Li

  reply	other threads:[~2024-11-25 13:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-25  2:33 [PATCH v4 1/2] iomap: fix zero padding data issue in concurrent append writes Long Li
2024-11-25  2:33 ` [PATCH v4 2/2] xfs: clean up xfs_end_ioend() to reuse local variables Long Li
2024-11-25  6:40 ` [PATCH v4 1/2] iomap: fix zero padding data issue in concurrent append writes Christoph Hellwig
2024-11-25 13:42   ` Long Li [this message]
2024-11-26  6:28     ` Christoph Hellwig
2024-11-26  6:53       ` Long Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z0R-2Jmj2u-Cqwxu@localhost.localdomain \
    --to=leo.lilong@huawei.com \
    --cc=brauner@kernel.org \
    --cc=cem@kernel.org \
    --cc=djwong@kernel.org \
    --cc=hch@infradead.org \
    --cc=houtao1@huawei.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=yangerkun@huawei.com \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.