From: Christoph Hellwig <hch@infradead.org>
To: Long Li <leo.lilong@huawei.com>
Cc: Christoph Hellwig <hch@infradead.org>,
brauner@kernel.org, djwong@kernel.org, cem@kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
yi.zhang@huawei.com, houtao1@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH v4 1/2] iomap: fix zero padding data issue in concurrent append writes
Date: Mon, 25 Nov 2024 22:28:42 -0800 [thread overview]
Message-ID: <Z0VqmgQisdDxlSAy@infradead.org> (raw)
In-Reply-To: <Z0R-2Jmj2u-Cqwxu@localhost.localdomain>
On Mon, Nov 25, 2024 at 09:42:48PM +0800, Long Li wrote:
> I agree with Brian's point. The scenarios where rounding up io_size
> enables ioend merging are quite rare, so the practical benefits are
> limited, though such cases can still exist. Therefore, I think both
> approaches are acceptable as there doesn't seem to be a significant
> difference between them.
Given that not rounding and using the unaligned value should be
a lot simpler, can you give it a try?
next prev parent reply other threads:[~2024-11-26 6:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 2:33 [PATCH v4 1/2] iomap: fix zero padding data issue in concurrent append writes Long Li
2024-11-25 2:33 ` [PATCH v4 2/2] xfs: clean up xfs_end_ioend() to reuse local variables Long Li
2024-11-25 6:40 ` [PATCH v4 1/2] iomap: fix zero padding data issue in concurrent append writes Christoph Hellwig
2024-11-25 13:42 ` Long Li
2024-11-26 6:28 ` Christoph Hellwig [this message]
2024-11-26 6:53 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0VqmgQisdDxlSAy@infradead.org \
--to=hch@infradead.org \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=houtao1@huawei.com \
--cc=leo.lilong@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.