[wsa:i2c/for-next 2/8] drivers/of/base.c:661: warning: Function parameter or struct member 'prefix' not described in 'of_get_next_child_with_prefix'

[wsa:i2c/for-next 2/8] drivers/of/base.c:661: warning: Function parameter or struct member 'prefix' not described in 'of_get_next_child_with_prefix'

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
head:   44b682694a0ca366bf15c26c3c3c16d26c9e9f6d
commit: 1fcc67e3a354865775355eafec1fb061a755c971 [2/8] of: base: Add for_each_child_of_node_with_prefix()
config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20241128/202411280010.KGSDBOUE-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241128/202411280010.KGSDBOUE-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411280010.KGSDBOUE-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/of/base.c:661: warning: Function parameter or struct member 'prefix' not described in 'of_get_next_child_with_prefix'


vim +661 drivers/of/base.c

   646	
   647	/**
   648	 * of_get_next_child_with_prefix - Find the next child node with prefix
   649	 * @node:	parent node
   650	 * @prev:	previous child of the parent node, or NULL to get first
   651	 *
   652	 * This function is like of_get_next_child(), except that it automatically
   653	 * skips any nodes whose name doesn't have the given prefix.
   654	 *
   655	 * Return: A node pointer with refcount incremented, use
   656	 * of_node_put() on it when done.
   657	 */
   658	struct device_node *of_get_next_child_with_prefix(const struct device_node *node,
   659							  struct device_node *prev,
   660							  const char *prefix)
 > 661	{
   662		struct device_node *next;
   663		unsigned long flags;
   664	
   665		if (!node)
   666			return NULL;
   667	
   668		raw_spin_lock_irqsave(&devtree_lock, flags);
   669		next = prev ? prev->sibling : node->child;
   670		for (; next; next = next->sibling) {
   671			if (!of_node_name_prefix(next, prefix))
   672				continue;
   673			if (of_node_get(next))
   674				break;
   675		}
   676		of_node_put(prev);
   677		raw_spin_unlock_irqrestore(&devtree_lock, flags);
   678		return next;
   679	}
   680	EXPORT_SYMBOL(of_get_next_child_with_prefix);
   681	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [wsa:i2c/for-next 2/8] drivers/of/base.c:661: warning: Function parameter or struct member 'prefix' not described in 'of_get_next_child_with_prefix'

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1147 bytes --]

On Wed, Nov 27, 2024 at 10:26:35PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-next
> head:   44b682694a0ca366bf15c26c3c3c16d26c9e9f6d
> commit: 1fcc67e3a354865775355eafec1fb061a755c971 [2/8] of: base: Add for_each_child_of_node_with_prefix()
> config: openrisc-allnoconfig (https://download.01.org/0day-ci/archive/20241128/202411280010.KGSDBOUE-lkp@intel.com/config)
> compiler: or1k-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241128/202411280010.KGSDBOUE-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202411280010.KGSDBOUE-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/of/base.c:661: warning: Function parameter or struct member 'prefix' not described in 'of_get_next_child_with_prefix'

Chen-Yu, can you send an incremental patch fixing this, please?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]