From: Long Li <leo.lilong@huawei.com>
To: Brian Foster <bfoster@redhat.com>, Dave Chinner <david@fromorbit.com>
Cc: <brauner@kernel.org>, <djwong@kernel.org>, <cem@kernel.org>,
<linux-xfs@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
<yi.zhang@huawei.com>, <houtao1@huawei.com>,
<yangerkun@huawei.com>
Subject: Re: [PATCH v5 1/2] iomap: fix zero padding data issue in concurrent append writes
Date: Wed, 4 Dec 2024 17:06:00 +0800 [thread overview]
Message-ID: <Z1AbeD8QVtITsvic@localhost.localdomain> (raw)
In-Reply-To: <Z08bsQ07cilOsUKi@bfoster>
On Tue, Dec 03, 2024 at 09:54:41AM -0500, Brian Foster wrote:
> Not sure I see how this is a serialization dependency given that
> writeback completion also samples i_size. But no matter, it seems a
> reasonable implementation to me to make the submission path consistent
> in handling eof.
>
> I wonder if this could just use end_pos returned from
> iomap_writepage_handle_eof()?
>
> Brian
>
It seems reasonable to me, but end_pos is block-size granular. We need
to pass in a more precise byte-granular end.
Thanks,
Long Li
next prev parent reply other threads:[~2024-12-04 9:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 6:35 [PATCH v5 1/2] iomap: fix zero padding data issue in concurrent append writes Long Li
2024-11-27 6:35 ` [PATCH v5 2/2] xfs: clean up xfs_end_ioend() to reuse local variables Long Li
2024-11-27 16:07 ` Darrick J. Wong
2024-11-27 16:28 ` [PATCH v5 1/2] iomap: fix zero padding data issue in concurrent append writes Darrick J. Wong
2024-11-28 6:38 ` Long Li
2024-11-28 3:33 ` Christoph Hellwig
2024-11-30 13:39 ` Long Li
2024-12-02 15:26 ` Brian Foster
2024-12-03 2:08 ` Dave Chinner
2024-12-03 14:54 ` Brian Foster
2024-12-03 21:12 ` Dave Chinner
2024-12-04 12:05 ` Brian Foster
2024-12-04 9:06 ` Long Li [this message]
2024-12-04 12:05 ` Brian Foster
2024-12-06 3:36 ` Long Li
2024-12-04 9:00 ` Long Li
2024-12-04 12:17 ` Brian Foster
2024-12-05 12:47 ` Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1AbeD8QVtITsvic@localhost.localdomain \
--to=leo.lilong@huawei.com \
--cc=bfoster@redhat.com \
--cc=brauner@kernel.org \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=houtao1@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.