All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Iliopoulos via Grub-devel <grub-devel@gnu.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Anthony Iliopoulos <ailiop@suse.com>,
	grub-devel@gnu.org,
	"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
	Marta Lewandowska <mlewando@redhat.com>,
	Andrey Albershteyn <aalbersh@redhat.com>,
	Jon DeVree <nuxi@vault24.org>
Subject: Re: [PATCH GRUB] fs/xfs: fix large extent counters incompat feature support
Date: Wed, 4 Dec 2024 21:13:56 +0100	[thread overview]
Message-ID: <Z1C4BB31S9HdYlDM@technoir> (raw)
In-Reply-To: <985816b8-35e6-4083-994f-ec9138bd35d2@redhat.com>

On Wed, Dec 04, 2024 at 07:50:28AM -0600, Eric Sandeen wrote:
> When large extent counter / NREXT64 support was added to grub, it missed
> a couple of direct reads of nextents which need to be changed to the new
> NREXT64-aware helper as well. Without this, we'll have mis-reads of some
> directories with this feature enabled.
> 
> (The large extent counter fix likely raced on merge with
> 07318ee7e ("fs/xfs: Fix XFS directory extent parsing") which added the new
> direct nextents reads just prior, causing this issue.)

Indeed 07318ee7e11a has a commit-date after the author-date of aa7c1322671e,
so it wasn't applied to the tree yet when I submitted the patch:

$ git show -s --pretty="%h %aI %cI" 07318ee7e aa7c1322671e
07318ee7e11a 2023-10-17T23:03:47-04:00 2023-10-30T18:01:22+01:00
aa7c1322671e 2023-10-26T11:53:39+02:00 2023-11-22T19:13:46+01:00

> Fixes: aa7c1322671e ("fs/xfs: Add large extent counters incompat feature support")
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Thanks for catching this,

Reviewed-by: Anthony Iliopoulos <ailiop@suse.com>

Regards,
Anthony

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

WARNING: multiple messages have this Message-ID (diff)
From: Anthony Iliopoulos <ailiop@suse.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: grub-devel@gnu.org,
	"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
	Marta Lewandowska <mlewando@redhat.com>,
	Andrey Albershteyn <aalbersh@redhat.com>,
	Jon DeVree <nuxi@vault24.org>
Subject: Re: [PATCH GRUB] fs/xfs: fix large extent counters incompat feature support
Date: Wed, 4 Dec 2024 21:13:56 +0100	[thread overview]
Message-ID: <Z1C4BB31S9HdYlDM@technoir> (raw)
In-Reply-To: <985816b8-35e6-4083-994f-ec9138bd35d2@redhat.com>

On Wed, Dec 04, 2024 at 07:50:28AM -0600, Eric Sandeen wrote:
> When large extent counter / NREXT64 support was added to grub, it missed
> a couple of direct reads of nextents which need to be changed to the new
> NREXT64-aware helper as well. Without this, we'll have mis-reads of some
> directories with this feature enabled.
> 
> (The large extent counter fix likely raced on merge with
> 07318ee7e ("fs/xfs: Fix XFS directory extent parsing") which added the new
> direct nextents reads just prior, causing this issue.)

Indeed 07318ee7e11a has a commit-date after the author-date of aa7c1322671e,
so it wasn't applied to the tree yet when I submitted the patch:

$ git show -s --pretty="%h %aI %cI" 07318ee7e aa7c1322671e
07318ee7e11a 2023-10-17T23:03:47-04:00 2023-10-30T18:01:22+01:00
aa7c1322671e 2023-10-26T11:53:39+02:00 2023-11-22T19:13:46+01:00

> Fixes: aa7c1322671e ("fs/xfs: Add large extent counters incompat feature support")
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Thanks for catching this,

Reviewed-by: Anthony Iliopoulos <ailiop@suse.com>

Regards,
Anthony

  reply	other threads:[~2024-12-04 20:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-04 13:50 [PATCH GRUB] fs/xfs: fix large extent counters incompat feature support Eric Sandeen
2024-12-04 13:50 ` Eric Sandeen
2024-12-04 20:13 ` Anthony Iliopoulos via Grub-devel [this message]
2024-12-04 20:13   ` Anthony Iliopoulos
2024-12-13  2:22 ` Jon DeVree
2024-12-13  2:22   ` Jon DeVree
2025-03-27 19:48 ` Eric Sandeen via Grub-devel
2025-03-27 19:48   ` Eric Sandeen
2025-04-16  1:08   ` Eric Sandeen via Grub-devel
2025-04-16  1:08     ` Eric Sandeen
2025-04-17 18:34     ` Daniel Kiper
2025-04-17 18:34       ` Daniel Kiper
2025-04-17 18:51       ` Eric Sandeen via Grub-devel
2025-04-17 18:51         ` Eric Sandeen
2025-04-01 10:36 ` Vladimir 'phcoder' Serbinenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z1C4BB31S9HdYlDM@technoir \
    --to=grub-devel@gnu.org \
    --cc=aalbersh@redhat.com \
    --cc=ailiop@suse.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=mlewando@redhat.com \
    --cc=nuxi@vault24.org \
    --cc=sandeen@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.