From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: jan.petrous@oss.nxp.com
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vinod Koul <vkoul@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Emil Renner Berthing <kernel@esmil.dk>,
Minda Chen <minda.chen@starfivetech.com>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Iyappan Subramanian <iyappan@os.amperecomputing.com>,
Keyur Chudgar <keyur@os.amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-msm@vger.kernel.org, imx@lists.linux.dev,
devicetree@vger.kernel.org, NXP S32 Linux Team <s32@nxp.com>,
0x1207@gmail.com, fancer.lancer@gmail.com,
Jacob Keller <jacob.e.keller@intel.com>
Subject: Re: [PATCH net-next v8 01/15] net: stmmac: Fix CSR divider comment
Date: Thu, 5 Dec 2024 16:51:19 +0000 [thread overview]
Message-ID: <Z1HaB6hT0QX4Jlyx@shell.armlinux.org.uk> (raw)
In-Reply-To: <20241205-upstream_s32cc_gmac-v8-1-ec1d180df815@oss.nxp.com>
On Thu, Dec 05, 2024 at 05:42:58PM +0100, Jan Petrous via B4 Relay wrote:
> From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
>
> The comment in declaration of STMMAC_CSR_250_300M
> incorrectly describes the constant as '/* MDC = clk_scr_i/122 */'
> but the DWC Ether QOS Handbook version 5.20a says it is
> CSR clock/124.
>
> Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
I gave my reviewed-by for this patch in the previous posting, but you
haven't included it.
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: jan.petrous@oss.nxp.com
Cc: Andrew Lunn <andrew@lunn.ch>, NXP S32 Linux Team <s32@nxp.com>,
Emil Renner Berthing <kernel@esmil.dk>,
imx@lists.linux.dev,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Eric Dumazet <edumazet@google.com>,
Iyappan Subramanian <iyappan@os.amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>,
Fabio Estevam <festevam@gmail.com>,
linux-stm32@st-md-mailman.stormreply.com,
Rob Herring <robh@kernel.org>,
0x1207@gmail.com, Jose Abreu <joabreu@synopsys.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
linux-arm-msm@vger.kernel.org,
Sascha Hauer <s.hauer@pengutronix.de>,
Keyur Chudgar <keyur@os.amperecomputing.com>,
Minda Chen <minda.chen@starfivetech.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
fancer.lancer@gmail.com, linux-kernel@vger.kernel.org,
Andrew Lunn <andrew+netdev@lunn.ch>,
Vinod Koul <vkoul@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH net-next v8 01/15] net: stmmac: Fix CSR divider comment
Date: Thu, 5 Dec 2024 16:51:19 +0000 [thread overview]
Message-ID: <Z1HaB6hT0QX4Jlyx@shell.armlinux.org.uk> (raw)
In-Reply-To: <20241205-upstream_s32cc_gmac-v8-1-ec1d180df815@oss.nxp.com>
On Thu, Dec 05, 2024 at 05:42:58PM +0100, Jan Petrous via B4 Relay wrote:
> From: "Jan Petrous (OSS)" <jan.petrous@oss.nxp.com>
>
> The comment in declaration of STMMAC_CSR_250_300M
> incorrectly describes the constant as '/* MDC = clk_scr_i/122 */'
> but the DWC Ether QOS Handbook version 5.20a says it is
> CSR clock/124.
>
> Signed-off-by: Jan Petrous (OSS) <jan.petrous@oss.nxp.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
I gave my reviewed-by for this patch in the previous posting, but you
haven't included it.
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2024-12-05 16:52 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 16:42 [PATCH net-next v8 00/15] Add support for Synopsis DWMAC IP on NXP Automotive SoCs S32G2xx/S32G3xx/S32R45 Jan Petrous (OSS)
2024-12-05 16:42 ` Jan Petrous via B4 Relay
2024-12-05 16:42 ` [PATCH net-next v8 01/15] net: stmmac: Fix CSR divider comment Jan Petrous (OSS)
2024-12-05 16:42 ` Jan Petrous via B4 Relay
2024-12-05 16:51 ` Russell King (Oracle) [this message]
2024-12-05 16:51 ` Russell King (Oracle)
2024-12-05 16:55 ` Jan Petrous
2024-12-05 16:55 ` Jan Petrous
2024-12-05 17:01 ` Russell King (Oracle)
2024-12-05 17:01 ` Russell King (Oracle)
2024-12-05 23:45 ` Andrew Lunn
2024-12-05 23:45 ` Andrew Lunn
2024-12-05 16:42 ` [PATCH net-next v8 02/15] net: stmmac: Extend CSR calc support Jan Petrous (OSS)
2024-12-05 16:42 ` Jan Petrous via B4 Relay
2024-12-05 16:43 ` [PATCH net-next v8 03/15] net: stmmac: Fix clock rate variables size Jan Petrous (OSS)
2024-12-05 16:43 ` Jan Petrous via B4 Relay
2024-12-05 16:43 ` [PATCH net-next v8 04/15] net: phy: Add helper for mapping RGMII link speed to clock rate Jan Petrous (OSS)
2024-12-05 16:43 ` Jan Petrous via B4 Relay
2024-12-05 16:43 ` [PATCH net-next v8 05/15] net: dwmac-dwc-qos-eth: Use helper rgmii_clock Jan Petrous (OSS)
2024-12-05 16:43 ` Jan Petrous via B4 Relay
2024-12-05 16:43 ` [PATCH net-next v8 06/15] net: dwmac-imx: " Jan Petrous (OSS)
2024-12-05 16:43 ` Jan Petrous via B4 Relay
2024-12-05 16:43 ` [PATCH net-next v8 07/15] net: dwmac-intel-plat: " Jan Petrous (OSS)
2024-12-05 16:43 ` Jan Petrous via B4 Relay
2024-12-05 16:58 ` Russell King (Oracle)
2024-12-05 16:58 ` Russell King (Oracle)
2024-12-05 16:43 ` [PATCH net-next v8 08/15] net: dwmac-rk: " Jan Petrous (OSS)
2024-12-05 16:43 ` Jan Petrous via B4 Relay
2024-12-05 16:43 ` [PATCH net-next v8 09/15] net: dwmac-starfive: " Jan Petrous (OSS)
2024-12-05 16:43 ` Jan Petrous via B4 Relay
2024-12-05 16:43 ` [PATCH net-next v8 10/15] net: macb: " Jan Petrous (OSS)
2024-12-05 16:43 ` Jan Petrous via B4 Relay
2024-12-06 9:47 ` Nicolas Ferre
2024-12-05 16:43 ` [PATCH net-next v8 11/15] net: xgene_enet: " Jan Petrous (OSS)
2024-12-05 16:43 ` Jan Petrous via B4 Relay
2024-12-05 16:43 ` [PATCH net-next v8 12/15] net: dwmac-sti: " Jan Petrous (OSS)
2024-12-05 16:43 ` Jan Petrous via B4 Relay
2024-12-05 16:43 ` [PATCH net-next v8 13/15] dt-bindings: net: Add DT bindings for DWMAC on NXP S32G/R SoCs Jan Petrous (OSS)
2024-12-05 16:43 ` Jan Petrous via B4 Relay
2024-12-05 16:43 ` [PATCH net-next v8 14/15] net: stmmac: dwmac-s32: add basic NXP S32G/S32R glue driver Jan Petrous (OSS)
2024-12-05 16:43 ` Jan Petrous via B4 Relay
2024-12-05 16:43 ` [PATCH net-next v8 15/15] MAINTAINERS: Add Jan Petrous as the NXP S32G/R DWMAC driver maintainer Jan Petrous (OSS)
2024-12-05 16:43 ` Jan Petrous via B4 Relay
2024-12-10 5:10 ` [PATCH net-next v8 00/15] Add support for Synopsis DWMAC IP on NXP Automotive SoCs S32G2xx/S32G3xx/S32R45 patchwork-bot+netdevbpf
2024-12-10 5:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1HaB6hT0QX4Jlyx@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=0x1207@gmail.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=fancer.lancer@gmail.com \
--cc=festevam@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=imx@lists.linux.dev \
--cc=iyappan@os.amperecomputing.com \
--cc=jacob.e.keller@intel.com \
--cc=jan.petrous@oss.nxp.com \
--cc=joabreu@synopsys.com \
--cc=kernel@esmil.dk \
--cc=kernel@pengutronix.de \
--cc=keyur@os.amperecomputing.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=minda.chen@starfivetech.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=quan@os.amperecomputing.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.