* [PATCH] arm64: dts: freescale: Remove unused and undocumented "cooling-(min|max)-state" properties
@ 2024-11-15 19:35 Rob Herring (Arm)
2024-12-09 12:29 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring (Arm) @ 2024-11-15 19:35 UTC (permalink / raw)
To: Shawn Guo, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-kernel, devicetree, linux-kernel
Remove "cooling-(min|max)-state" properties which are both unused in the
kernel and undocumented. Most likely they are leftovers from downstream.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
.../boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts | 2 --
arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi | 2 --
2 files changed, 4 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
index d9fac647f432..1d53b529af88 100644
--- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
+++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
@@ -19,8 +19,6 @@ / {
pwm-fan {
compatible = "pwm-fan";
- cooling-min-state = <0>;
- cooling-max-state = <3>;
#cooling-cells = <2>;
pwms = <&sl28cpld_pwm0 0 4000000>;
cooling-levels = <1 128 192 255>;
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
index d32a52ab00a4..aef63a4f698c 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
@@ -94,8 +94,6 @@ i2c@1 {
fan-temperature-ctrlr@18 {
compatible = "ti,amc6821";
reg = <0x18>;
- cooling-min-state = <0>;
- cooling-max-state = <9>;
#cooling-cells = <2>;
};
};
--
2.45.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: freescale: Remove unused and undocumented "cooling-(min|max)-state" properties
2024-11-15 19:35 [PATCH] arm64: dts: freescale: Remove unused and undocumented "cooling-(min|max)-state" properties Rob Herring (Arm)
@ 2024-12-09 12:29 ` Shawn Guo
0 siblings, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2024-12-09 12:29 UTC (permalink / raw)
To: Rob Herring (Arm)
Cc: Shawn Guo, Krzysztof Kozlowski, Conor Dooley, linux-arm-kernel,
devicetree, linux-kernel
On Fri, Nov 15, 2024 at 01:35:03PM -0600, Rob Herring (Arm) wrote:
> Remove "cooling-(min|max)-state" properties which are both unused in the
> kernel and undocumented. Most likely they are leftovers from downstream.
>
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
A similar change from Frank [1] was applied, thanks!
Shawn
[1] https://lore.kernel.org/lkml/20241007220542.897605-1-Frank.Li@nxp.com/
> ---
> .../boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts | 2 --
> arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi | 2 --
> 2 files changed, 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
> index d9fac647f432..1d53b529af88 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
> +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var3-ads2.dts
> @@ -19,8 +19,6 @@ / {
>
> pwm-fan {
> compatible = "pwm-fan";
> - cooling-min-state = <0>;
> - cooling-max-state = <3>;
> #cooling-cells = <2>;
> pwms = <&sl28cpld_pwm0 0 4000000>;
> cooling-levels = <1 128 192 255>;
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> index d32a52ab00a4..aef63a4f698c 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> @@ -94,8 +94,6 @@ i2c@1 {
> fan-temperature-ctrlr@18 {
> compatible = "ti,amc6821";
> reg = <0x18>;
> - cooling-min-state = <0>;
> - cooling-max-state = <9>;
> #cooling-cells = <2>;
> };
> };
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm64: dts: freescale: Remove unused and undocumented "cooling-(min|max)-state" properties
@ 2024-11-18 1:53 kernel test robot
0 siblings, 0 replies; 3+ messages in thread
From: kernel test robot @ 2024-11-18 1:53 UTC (permalink / raw)
To: oe-kbuild; +Cc: lkp
::::::
:::::: Manual check reason: "dtcheck: binding changes may go via different trees"
::::::
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20241115193504.3619533-1-robh@kernel.org>
References: <20241115193504.3619533-1-robh@kernel.org>
TO: "Rob Herring (Arm)" <robh@kernel.org>
TO: Shawn Guo <shawnguo@kernel.org>
TO: Krzysztof Kozlowski <krzk@kernel.org>
TO: Conor Dooley <conor+dt@kernel.org>
CC: linux-arm-kernel@lists.infradead.org
CC: devicetree@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Hi Rob,
kernel test robot noticed the following build warnings:
[auto build test WARNING on krzk/for-next]
[also build test WARNING on krzk-dt/for-next linus/master v6.12]
[cannot apply to shawnguo/for-next next-20241115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Rob-Herring-Arm/arm64-dts-freescale-Remove-unused-and-undocumented-cooling-min-max-state-properties/20241117-000213
base: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git for-next
patch link: https://lore.kernel.org/r/20241115193504.3619533-1-robh%40kernel.org
patch subject: [PATCH] arm64: dts: freescale: Remove unused and undocumented "cooling-(min|max)-state" properties
:::::: branch date: 34 hours ago
:::::: commit date: 34 hours ago
config: arm64-randconfig-051-20241117 (https://download.01.org/0day-ci/archive/20241118/202411180925.URdzXqPu-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
dtschema version: 2024.12.dev1+gcabb5b9
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241118/202411180925.URdzXqPu-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/r/202411180925.URdzXqPu-lkp@intel.com/
dtcheck warnings: (new ones prefixed by >>)
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi:1703.34-1775.5: Warning (avoid_unnecessary_addr_size): /soc/pinmux@70010012c: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: syscon@1f70000: interrupt-controller@14:interrupt-map: [[0, 0, 1, 0, 0, 4, 1, 0], [1, 0, 1, 4, 2, 0, 1, 0], [2, 4, 3, 0, 1, 0, 3, 4], [4, 0, 1, 0, 4, 4, 5, 0], [1, 0, 5, 4, 6, 0, 1, 0], [6, 4, 7, 0, 1, 0, 7, 4], [8, 0, 1, 0, 8, 4, 9, 0], [1, 0, 9, 4, 10, 0, 1, 0], [10, 4, 11, 0, 1, 0, 11, 4]] is too short
from schema $id: http://devicetree.org/schemas/soc/fsl/fsl,layerscape-scfg.yaml#
arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: interrupt-controller@14: interrupt-map: [[0, 0, 1, 0, 0, 4, 1, 0], [1, 0, 1, 4, 2, 0, 1, 0], [2, 4, 3, 0, 1, 0, 3, 4], [4, 0, 1, 0, 4, 4, 5, 0], [1, 0, 5, 4, 6, 0, 1, 0], [6, 4, 7, 0, 1, 0, 7, 4], [8, 0, 1, 0, 8, 4, 9, 0], [1, 0, 9, 4, 10, 0, 1, 0], [10, 4, 11, 0, 1, 0, 11, 4]] is too short
from schema $id: http://devicetree.org/schemas/interrupt-controller/fsl,ls-extirq.yaml#
>> arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: fan-temperature-ctrlr@18: '#cooling-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: /soc/pcie@3400000: failed to match any schema with compatible: ['fsl,lx2160a-pcie']
arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: /soc/pcie@3500000: failed to match any schema with compatible: ['fsl,lx2160a-pcie']
arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: /soc/pcie@3600000: failed to match any schema with compatible: ['fsl,lx2160a-pcie']
arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: /soc/pcie@3700000: failed to match any schema with compatible: ['fsl,lx2160a-pcie']
arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: /soc/pcie@3800000: failed to match any schema with compatible: ['fsl,lx2160a-pcie']
arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: /soc/pcie@3900000: failed to match any schema with compatible: ['fsl,lx2160a-pcie']
arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dtb: fsl-mc@80c000000: msi-parent:0: [51, 0] is too long
from schema $id: http://devicetree.org/schemas/misc/fsl,qoriq-mc.yaml#
--
arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi:1703.34-1775.5: Warning (avoid_unnecessary_addr_size): /soc/pinmux@70010012c: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: syscon@1f70000: interrupt-controller@14:interrupt-map: [[0, 0, 1, 0, 0, 4, 1, 0], [1, 0, 1, 4, 2, 0, 1, 0], [2, 4, 3, 0, 1, 0, 3, 4], [4, 0, 1, 0, 4, 4, 5, 0], [1, 0, 5, 4, 6, 0, 1, 0], [6, 4, 7, 0, 1, 0, 7, 4], [8, 0, 1, 0, 8, 4, 9, 0], [1, 0, 9, 4, 10, 0, 1, 0], [10, 4, 11, 0, 1, 0, 11, 4]] is too short
from schema $id: http://devicetree.org/schemas/soc/fsl/fsl,layerscape-scfg.yaml#
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: interrupt-controller@14: interrupt-map: [[0, 0, 1, 0, 0, 4, 1, 0], [1, 0, 1, 4, 2, 0, 1, 0], [2, 4, 3, 0, 1, 0, 3, 4], [4, 0, 1, 0, 4, 4, 5, 0], [1, 0, 5, 4, 6, 0, 1, 0], [6, 4, 7, 0, 1, 0, 7, 4], [8, 0, 1, 0, 8, 4, 9, 0], [1, 0, 9, 4, 10, 0, 1, 0], [10, 4, 11, 0, 1, 0, 11, 4]] is too short
from schema $id: http://devicetree.org/schemas/interrupt-controller/fsl,ls-extirq.yaml#
>> arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fan-temperature-ctrlr@18: '#cooling-cells' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/trivial-devices.yaml#
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: /soc/pcie@3400000: failed to match any schema with compatible: ['fsl,lx2160a-pcie']
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: /soc/pcie@3500000: failed to match any schema with compatible: ['fsl,lx2160a-pcie']
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: /soc/pcie@3600000: failed to match any schema with compatible: ['fsl,lx2160a-pcie']
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: /soc/pcie@3700000: failed to match any schema with compatible: ['fsl,lx2160a-pcie']
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: /soc/pcie@3800000: failed to match any schema with compatible: ['fsl,lx2160a-pcie']
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: /soc/pcie@3900000: failed to match any schema with compatible: ['fsl,lx2160a-pcie']
arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dtb: fsl-mc@80c000000: msi-parent:0: [51, 0] is too long
from schema $id: http://devicetree.org/schemas/misc/fsl,qoriq-mc.yaml#
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-09 12:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-15 19:35 [PATCH] arm64: dts: freescale: Remove unused and undocumented "cooling-(min|max)-state" properties Rob Herring (Arm)
2024-12-09 12:29 ` Shawn Guo
-- strict thread matches above, loose matches on Subject: below --
2024-11-18 1:53 kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.