All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@linux.intel.com>
To: Krzysztof Karas <krzysztof.karas@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
	Michal Wajdeczko <michal.wajdeczko@intel.com>,
	Andi Shyti <andi.shyti@linux.intel.com>,
	Imre Deak <imre.deak@intel.com>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v2] drm/display: use ERR_PTR on DP tunnel manager creation fail
Date: Wed, 11 Dec 2024 23:42:41 +0100	[thread overview]
Message-ID: <Z1oVYTZA3Ls0ApVd@ashyti-mobl2.lan> (raw)
In-Reply-To: <x46u4zhhpnxgohyguhqsc4d73sbjwipebxp5uiwkopejsy6dpz@v3eysonfbmk2>

Hi Krzysztof,

On Wed, Dec 11, 2024 at 02:52:20PM +0000, Krzysztof Karas wrote:
> Instead of returning a generic NULL on error from drm_dp_tunnel_mgr_create(),
> use error pointers with informative codes. This will also trigger IS_ERR() in
> current caller (intel_dp_tunnerl_mgr_init()) instead of bypassing it via NULL
> pointer.
> 
> v2: use error codes inside drm_dp_tunnel_mgr_create() instead of handling
>  on caller's side (Michal, Imre)
> 
> Signed-off-by: Krzysztof Karas <krzysztof.karas@intel.com>

Please:

 1. run checkpatch.pl before sending patches.
 2. don't ignore previous reviews: I asked you to add the fixes
    tag and two Cc
 3. run checkpatch.pl before sending patches.
 4. Because this is a fix you should Cc also the stable mailing
    list (for real!).
 5. Find the proper maintainers to Cc, this patch is outside
    Intel's territory; consider using, but not strictly,
    get_maintainer.pl

And, in case you forget:

 6. run checkpatch.pl before sending patches.

Looking forward for a v3.

Andi

  parent reply	other threads:[~2024-12-11 22:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-11 14:52 [PATCH v2] drm/display: use ERR_PTR on DP tunnel manager creation fail Krzysztof Karas
2024-12-11 15:18 ` Andi Shyti
2024-12-11 15:21   ` Andi Shyti
2024-12-11 16:11 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2024-12-11 16:52 ` ✓ i915.CI.BAT: success " Patchwork
2024-12-11 18:24 ` ✓ i915.CI.Full: " Patchwork
2024-12-11 22:42 ` Andi Shyti [this message]
2024-12-12  8:50   ` [PATCH v2] " Krzysztof Karas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z1oVYTZA3Ls0ApVd@ashyti-mobl2.lan \
    --to=andi.shyti@linux.intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=krzysztof.karas@intel.com \
    --cc=michal.wajdeczko@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.