* [paulmckrcu:dev 51/57] ERROR: modpost: "rcutorture_format_gp_seqs" [kernel/rcu/rcutorture.ko] undefined!
@ 2024-12-11 21:55 kernel test robot
2024-12-11 23:46 ` Paul E. McKenney
0 siblings, 1 reply; 4+ messages in thread
From: kernel test robot @ 2024-12-11 21:55 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: oe-kbuild-all
tree: https://github.com/paulmckrcu/linux dev
head: 58b186eb8049230c475262f8e9eab34299677b8a
commit: 9133bc2bf728593225932a2574688beeb602b1ef [51/57] rcutorture: Include grace-period sequence numbers in failure/close-call
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20241212/202412120535.T5YZArL9-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241212/202412120535.T5YZArL9-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412120535.T5YZArL9-lkp@intel.com/
All errors (new ones prefixed by >>, old ones prefixed by <<):
ERROR: modpost: "rcutorture_gather_gp_seqs" [kernel/rcu/rcutorture.ko] undefined!
>> ERROR: modpost: "rcutorture_format_gp_seqs" [kernel/rcu/rcutorture.ko] undefined!
ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!
ERROR: modpost: "devm_of_clk_add_hw_provider" [drivers/media/i2c/tc358746.ko] undefined!
ERROR: modpost: "devm_clk_hw_register" [drivers/media/i2c/tc358746.ko] undefined!
ERROR: modpost: "of_clk_hw_simple_get" [drivers/media/i2c/tc358746.ko] undefined!
ERROR: modpost: "inb_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
ERROR: modpost: "inw_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
ERROR: modpost: "nec7210_locking_ioport_write_byte" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
ERROR: modpost: "nec7210_locking_ioport_read_byte" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
WARNING: modpost: suppressed 2 unresolved symbol warnings because there were too many)
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [paulmckrcu:dev 51/57] ERROR: modpost: "rcutorture_format_gp_seqs" [kernel/rcu/rcutorture.ko] undefined!
2024-12-11 21:55 [paulmckrcu:dev 51/57] ERROR: modpost: "rcutorture_format_gp_seqs" [kernel/rcu/rcutorture.ko] undefined! kernel test robot
@ 2024-12-11 23:46 ` Paul E. McKenney
2024-12-12 4:27 ` Oliver Sang
0 siblings, 1 reply; 4+ messages in thread
From: Paul E. McKenney @ 2024-12-11 23:46 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all
On Thu, Dec 12, 2024 at 05:55:36AM +0800, kernel test robot wrote:
> tree: https://github.com/paulmckrcu/linux dev
> head: 58b186eb8049230c475262f8e9eab34299677b8a
> commit: 9133bc2bf728593225932a2574688beeb602b1ef [51/57] rcutorture: Include grace-period sequence numbers in failure/close-call
> config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20241212/202412120535.T5YZArL9-lkp@intel.com/config)
> compiler: sh4-linux-gcc (GCC) 14.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241212/202412120535.T5YZArL9-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202412120535.T5YZArL9-lkp@intel.com/
>
> All errors (new ones prefixed by >>, old ones prefixed by <<):
>
> ERROR: modpost: "rcutorture_gather_gp_seqs" [kernel/rcu/rcutorture.ko] undefined!
> >> ERROR: modpost: "rcutorture_format_gp_seqs" [kernel/rcu/rcutorture.ko] undefined!
> ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!
> ERROR: modpost: "devm_of_clk_add_hw_provider" [drivers/media/i2c/tc358746.ko] undefined!
> ERROR: modpost: "devm_clk_hw_register" [drivers/media/i2c/tc358746.ko] undefined!
> ERROR: modpost: "of_clk_hw_simple_get" [drivers/media/i2c/tc358746.ko] undefined!
> ERROR: modpost: "inb_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
> ERROR: modpost: "inw_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
> ERROR: modpost: "nec7210_locking_ioport_write_byte" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
> ERROR: modpost: "nec7210_locking_ioport_read_byte" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
> WARNING: modpost: suppressed 2 unresolved symbol warnings because there were too many)
I believe that this is fixed by the following commit, which I will likely
fold into the original. Does it do the trick for you?
Thanx, Paul
------------------------------------------------------------------------
commit c2cf9cf59e746aa60badcb07f58b09b7f604c19b
Author: Nathan Chancellor <nathan@kernel.org>
Date: Wed Dec 11 12:43:01 2024 -0800
rcu: Use IS_ENABLED() for Tiny RCU rcutorture definitions
The rcutorture_gather_gp_seqs() and rcutorture_format_gp_seqs() functions
are currently guarded by "#ifdef CONFIG_RCU_TORTURE_TEST". This fails
in kernels built with CONFIG_RCU_TINY=y and CONFIG_RCU_TORTURE_TEST=m
because in that case there is no CONFIG_RCU_TORTURE_TEST cpp macro.
There is instead a CONFIG_RCU_TORTURE_TEST_MODULE cpp macro.
This commit uses "#if IS_ENABLED(CONFIG_RCU_TORTURE_TEST)" to correctly
handle modular as well as built-in rcutorture for kernels using Tiny RCU.
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
diff --git a/kernel/rcu/tiny.c b/kernel/rcu/tiny.c
index 1971683f1a82d..b97c64e99a905 100644
--- a/kernel/rcu/tiny.c
+++ b/kernel/rcu/tiny.c
@@ -257,7 +257,7 @@ void kvfree_call_rcu(struct rcu_head *head, void *ptr)
EXPORT_SYMBOL_GPL(kvfree_call_rcu);
#endif
-#ifdef CONFIG_RCU_TORTURE_TEST
+#if IS_ENABLED(CONFIG_RCU_TORTURE_TEST)
unsigned long long rcutorture_gather_gp_seqs(void)
{
return READ_ONCE(rcu_ctrlblk.gp_seq) & 0xffffULL;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [paulmckrcu:dev 51/57] ERROR: modpost: "rcutorture_format_gp_seqs" [kernel/rcu/rcutorture.ko] undefined!
2024-12-11 23:46 ` Paul E. McKenney
@ 2024-12-12 4:27 ` Oliver Sang
2024-12-12 19:12 ` Paul E. McKenney
0 siblings, 1 reply; 4+ messages in thread
From: Oliver Sang @ 2024-12-12 4:27 UTC (permalink / raw)
To: paulmck@kernel.org; +Cc: lkp, oe-kbuild-all@lists.linux.dev, oliver.sang
hi, Paul,
On Thu, Dec 12, 2024 at 07:46:09AM +0800, Paul E. McKenney wrote:
> On Thu, Dec 12, 2024 at 05:55:36AM +0800, kernel test robot wrote:
> > tree: https://github.com/paulmckrcu/linux dev
> > head: 58b186eb8049230c475262f8e9eab34299677b8a
> > commit: 9133bc2bf728593225932a2574688beeb602b1ef [51/57] rcutorture: Include grace-period sequence numbers in failure/close-call
> > config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20241212/202412120535.T5YZArL9-lkp@intel.com/config)
> > compiler: sh4-linux-gcc (GCC) 14.2.0
> > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241212/202412120535.T5YZArL9-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202412120535.T5YZArL9-lkp@intel.com/
> >
> > All errors (new ones prefixed by >>, old ones prefixed by <<):
> >
> > ERROR: modpost: "rcutorture_gather_gp_seqs" [kernel/rcu/rcutorture.ko] undefined!
> > >> ERROR: modpost: "rcutorture_format_gp_seqs" [kernel/rcu/rcutorture.ko] undefined!
above two ERROR are solved by the patch you mentioned below. thanks
Tested-by: kernel test robot <oliver.sang@intel.com>
> > ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!
> > ERROR: modpost: "devm_of_clk_add_hw_provider" [drivers/media/i2c/tc358746.ko] undefined!
> > ERROR: modpost: "devm_clk_hw_register" [drivers/media/i2c/tc358746.ko] undefined!
> > ERROR: modpost: "of_clk_hw_simple_get" [drivers/media/i2c/tc358746.ko] undefined!
> > ERROR: modpost: "inb_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
> > ERROR: modpost: "inw_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
> > ERROR: modpost: "nec7210_locking_ioport_write_byte" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
> > ERROR: modpost: "nec7210_locking_ioport_read_byte" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
> > WARNING: modpost: suppressed 2 unresolved symbol warnings because there were too many)
>
> I believe that this is fixed by the following commit, which I will likely
> fold into the original. Does it do the trick for you?
>
> Thanx, Paul
>
> ------------------------------------------------------------------------
>
> commit c2cf9cf59e746aa60badcb07f58b09b7f604c19b
> Author: Nathan Chancellor <nathan@kernel.org>
> Date: Wed Dec 11 12:43:01 2024 -0800
>
> rcu: Use IS_ENABLED() for Tiny RCU rcutorture definitions
>
> The rcutorture_gather_gp_seqs() and rcutorture_format_gp_seqs() functions
> are currently guarded by "#ifdef CONFIG_RCU_TORTURE_TEST". This fails
> in kernels built with CONFIG_RCU_TINY=y and CONFIG_RCU_TORTURE_TEST=m
> because in that case there is no CONFIG_RCU_TORTURE_TEST cpp macro.
> There is instead a CONFIG_RCU_TORTURE_TEST_MODULE cpp macro.
>
> This commit uses "#if IS_ENABLED(CONFIG_RCU_TORTURE_TEST)" to correctly
> handle modular as well as built-in rcutorture for kernels using Tiny RCU.
>
> Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
>
> diff --git a/kernel/rcu/tiny.c b/kernel/rcu/tiny.c
> index 1971683f1a82d..b97c64e99a905 100644
> --- a/kernel/rcu/tiny.c
> +++ b/kernel/rcu/tiny.c
> @@ -257,7 +257,7 @@ void kvfree_call_rcu(struct rcu_head *head, void *ptr)
> EXPORT_SYMBOL_GPL(kvfree_call_rcu);
> #endif
>
> -#ifdef CONFIG_RCU_TORTURE_TEST
> +#if IS_ENABLED(CONFIG_RCU_TORTURE_TEST)
> unsigned long long rcutorture_gather_gp_seqs(void)
> {
> return READ_ONCE(rcu_ctrlblk.gp_seq) & 0xffffULL;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [paulmckrcu:dev 51/57] ERROR: modpost: "rcutorture_format_gp_seqs" [kernel/rcu/rcutorture.ko] undefined!
2024-12-12 4:27 ` Oliver Sang
@ 2024-12-12 19:12 ` Paul E. McKenney
0 siblings, 0 replies; 4+ messages in thread
From: Paul E. McKenney @ 2024-12-12 19:12 UTC (permalink / raw)
To: Oliver Sang; +Cc: lkp, oe-kbuild-all@lists.linux.dev
On Thu, Dec 12, 2024 at 12:27:53PM +0800, Oliver Sang wrote:
> hi, Paul,
>
> On Thu, Dec 12, 2024 at 07:46:09AM +0800, Paul E. McKenney wrote:
> > On Thu, Dec 12, 2024 at 05:55:36AM +0800, kernel test robot wrote:
> > > tree: https://github.com/paulmckrcu/linux dev
> > > head: 58b186eb8049230c475262f8e9eab34299677b8a
> > > commit: 9133bc2bf728593225932a2574688beeb602b1ef [51/57] rcutorture: Include grace-period sequence numbers in failure/close-call
> > > config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20241212/202412120535.T5YZArL9-lkp@intel.com/config)
> > > compiler: sh4-linux-gcc (GCC) 14.2.0
> > > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241212/202412120535.T5YZArL9-lkp@intel.com/reproduce)
> > >
> > > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > > the same patch/commit), kindly add following tags
> > > | Reported-by: kernel test robot <lkp@intel.com>
> > > | Closes: https://lore.kernel.org/oe-kbuild-all/202412120535.T5YZArL9-lkp@intel.com/
> > >
> > > All errors (new ones prefixed by >>, old ones prefixed by <<):
> > >
> > > ERROR: modpost: "rcutorture_gather_gp_seqs" [kernel/rcu/rcutorture.ko] undefined!
> > > >> ERROR: modpost: "rcutorture_format_gp_seqs" [kernel/rcu/rcutorture.ko] undefined!
>
> above two ERROR are solved by the patch you mentioned below. thanks
>
> Tested-by: kernel test robot <oliver.sang@intel.com>
Thank you!!! I will apply your Tested-by on my next rebase.
Thanx, Paul
> > > ERROR: modpost: "__delay" [drivers/net/mdio/mdio-cavium.ko] undefined!
> > > ERROR: modpost: "devm_of_clk_add_hw_provider" [drivers/media/i2c/tc358746.ko] undefined!
> > > ERROR: modpost: "devm_clk_hw_register" [drivers/media/i2c/tc358746.ko] undefined!
> > > ERROR: modpost: "of_clk_hw_simple_get" [drivers/media/i2c/tc358746.ko] undefined!
> > > ERROR: modpost: "inb_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
> > > ERROR: modpost: "inw_wrapper" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
> > > ERROR: modpost: "nec7210_locking_ioport_write_byte" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
> > > ERROR: modpost: "nec7210_locking_ioport_read_byte" [drivers/staging/gpib/tnt4882/tnt4882.ko] undefined!
> > > WARNING: modpost: suppressed 2 unresolved symbol warnings because there were too many)
> >
> > I believe that this is fixed by the following commit, which I will likely
> > fold into the original. Does it do the trick for you?
> >
> > Thanx, Paul
> >
> > ------------------------------------------------------------------------
> >
> > commit c2cf9cf59e746aa60badcb07f58b09b7f604c19b
> > Author: Nathan Chancellor <nathan@kernel.org>
> > Date: Wed Dec 11 12:43:01 2024 -0800
> >
> > rcu: Use IS_ENABLED() for Tiny RCU rcutorture definitions
> >
> > The rcutorture_gather_gp_seqs() and rcutorture_format_gp_seqs() functions
> > are currently guarded by "#ifdef CONFIG_RCU_TORTURE_TEST". This fails
> > in kernels built with CONFIG_RCU_TINY=y and CONFIG_RCU_TORTURE_TEST=m
> > because in that case there is no CONFIG_RCU_TORTURE_TEST cpp macro.
> > There is instead a CONFIG_RCU_TORTURE_TEST_MODULE cpp macro.
> >
> > This commit uses "#if IS_ENABLED(CONFIG_RCU_TORTURE_TEST)" to correctly
> > handle modular as well as built-in rcutorture for kernels using Tiny RCU.
> >
> > Signed-off-by: Nathan Chancellor <nathan@kernel.org>
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> >
> > diff --git a/kernel/rcu/tiny.c b/kernel/rcu/tiny.c
> > index 1971683f1a82d..b97c64e99a905 100644
> > --- a/kernel/rcu/tiny.c
> > +++ b/kernel/rcu/tiny.c
> > @@ -257,7 +257,7 @@ void kvfree_call_rcu(struct rcu_head *head, void *ptr)
> > EXPORT_SYMBOL_GPL(kvfree_call_rcu);
> > #endif
> >
> > -#ifdef CONFIG_RCU_TORTURE_TEST
> > +#if IS_ENABLED(CONFIG_RCU_TORTURE_TEST)
> > unsigned long long rcutorture_gather_gp_seqs(void)
> > {
> > return READ_ONCE(rcu_ctrlblk.gp_seq) & 0xffffULL;
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-12 19:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-11 21:55 [paulmckrcu:dev 51/57] ERROR: modpost: "rcutorture_format_gp_seqs" [kernel/rcu/rcutorture.ko] undefined! kernel test robot
2024-12-11 23:46 ` Paul E. McKenney
2024-12-12 4:27 ` Oliver Sang
2024-12-12 19:12 ` Paul E. McKenney
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.