[PATCH 0/3] include: Cleanups around 'exec/cpu-common.h' header

[PATCH 0/3] include: Cleanups around 'exec/cpu-common.h' header

[Philippe Mathieu-Daudé]

Do not include "exec/cpu-common.h" when we don't need it.

(I plan to merge this series myself).

Philippe Mathieu-Daudé (3):
  hw/xen: Remove unnecessary 'exec/cpu-common.h' header
  system/numa: Remove unnecessary 'exec/cpu-common.h' header
  system/accel-ops: Remove unnecessary 'exec/cpu-common.h' header

 include/hw/xen/xen.h       | 2 --
 include/sysemu/accel-ops.h | 2 +-
 include/sysemu/numa.h      | 1 -
 3 files changed, 1 insertion(+), 4 deletions(-)

-- 
2.45.2

[PATCH 1/3] hw/xen: Remove unnecessary 'exec/cpu-common.h' header

[Philippe Mathieu-Daudé]

Nothing requires definitions from "exec/cpu-common.h",
do not include this header.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/hw/xen/xen.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h
index ecb89ecfc14..e94c6e5a318 100644
--- a/include/hw/xen/xen.h
+++ b/include/hw/xen/xen.h
@@ -24,8 +24,6 @@
 #define __XEN_INTERFACE_VERSION__ 0x00040e00
 #endif
 
-#include "exec/cpu-common.h"
-
 /* xen-machine.c */
 enum xen_mode {
     XEN_DISABLED = 0, /* xen support disabled (default) */
-- 
2.45.2

Re: [PATCH 1/3] hw/xen: Remove unnecessary 'exec/cpu-common.h' header

[Zhao Liu]

On Tue, Dec 17, 2024 at 04:13:03PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Tue, 17 Dec 2024 16:13:03 +0100
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: [PATCH 1/3] hw/xen: Remove unnecessary 'exec/cpu-common.h' header
> X-Mailer: git-send-email 2.45.2
> 
> Nothing requires definitions from "exec/cpu-common.h",
> do not include this header.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  include/hw/xen/xen.h | 2 --
>  1 file changed, 2 deletions(-)
> 

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

[PATCH 2/3] system/numa: Remove unnecessary 'exec/cpu-common.h' header

[Philippe Mathieu-Daudé]

Nothing requires definitions from "exec/cpu-common.h",
do not include this header.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/sysemu/numa.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/sysemu/numa.h b/include/sysemu/numa.h
index 04676141470..1338db9502d 100644
--- a/include/sysemu/numa.h
+++ b/include/sysemu/numa.h
@@ -3,7 +3,6 @@
 
 #include "qemu/bitmap.h"
 #include "qapi/qapi-types-machine.h"
-#include "exec/cpu-common.h"
 
 struct CPUArchId;
 
-- 
2.45.2

Re: [PATCH 2/3] system/numa: Remove unnecessary 'exec/cpu-common.h' header

[Zhao Liu]

On Tue, Dec 17, 2024 at 04:13:04PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Tue, 17 Dec 2024 16:13:04 +0100
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: [PATCH 2/3] system/numa: Remove unnecessary 'exec/cpu-common.h'
>  header
> X-Mailer: git-send-email 2.45.2
> 
> Nothing requires definitions from "exec/cpu-common.h",
> do not include this header.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  include/sysemu/numa.h | 1 -
>  1 file changed, 1 deletion(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

[PATCH 3/3] system/accel-ops: Remove unnecessary 'exec/cpu-common.h' header

[Philippe Mathieu-Daudé]

Since commit c4b3f46c151 ("include/exec: Move vaddr defines to
separate file") we only need to include "exec/vaddr.h" to get
the 'vaddr' type definition, no need for "exec/cpu-common.h".

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 include/sysemu/accel-ops.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/sysemu/accel-ops.h b/include/sysemu/accel-ops.h
index a0886722305..137fb96d444 100644
--- a/include/sysemu/accel-ops.h
+++ b/include/sysemu/accel-ops.h
@@ -10,7 +10,7 @@
 #ifndef ACCEL_OPS_H
 #define ACCEL_OPS_H
 
-#include "exec/cpu-common.h"
+#include "exec/vaddr.h"
 #include "qom/object.h"
 
 #define ACCEL_OPS_SUFFIX "-ops"
-- 
2.45.2

Re: [PATCH 3/3] system/accel-ops: Remove unnecessary 'exec/cpu-common.h' header

[Zhao Liu]

On Tue, Dec 17, 2024 at 04:13:05PM +0100, Philippe Mathieu-Daudé wrote:
> Date: Tue, 17 Dec 2024 16:13:05 +0100
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: [PATCH 3/3] system/accel-ops: Remove unnecessary
>  'exec/cpu-common.h' header
> X-Mailer: git-send-email 2.45.2
> 
> Since commit c4b3f46c151 ("include/exec: Move vaddr defines to
> separate file") we only need to include "exec/vaddr.h" to get
> the 'vaddr' type definition, no need for "exec/cpu-common.h".
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  include/sysemu/accel-ops.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

Re: [PATCH 0/3] include: Cleanups around 'exec/cpu-common.h' header

[Richard Henderson]

On 12/17/24 09:13, Philippe Mathieu-Daudé wrote:
> Philippe Mathieu-Daudé (3):
>    hw/xen: Remove unnecessary 'exec/cpu-common.h' header
>    system/numa: Remove unnecessary 'exec/cpu-common.h' header
>    system/accel-ops: Remove unnecessary 'exec/cpu-common.h' header

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~

Re: [PATCH 0/3] include: Cleanups around 'exec/cpu-common.h' header

[Philippe Mathieu-Daudé]

On 17/12/24 16:13, Philippe Mathieu-Daudé wrote:

> Philippe Mathieu-Daudé (3):
>    hw/xen: Remove unnecessary 'exec/cpu-common.h' header
>    system/numa: Remove unnecessary 'exec/cpu-common.h' header
>    system/accel-ops: Remove unnecessary 'exec/cpu-common.h' header

Series queued.