From: Long Li <leo.lilong@huawei.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: "Darrick J. Wong" <djwong@kernel.org>, <cem@kernel.org>,
<linux-xfs@vger.kernel.org>, <david@fromorbit.com>,
<yi.zhang@huawei.com>, <houtao1@huawei.com>,
<yangerkun@huawei.com>, <lonuxli.64@gmail.com>
Subject: Re: [PATCH 1/2] xfs: correct the sb_rgcount when the disk not support rt volume
Date: Wed, 8 Jan 2025 15:22:00 +0800 [thread overview]
Message-ID: <Z34nmIFrYqqvHnBe@localhost.localdomain> (raw)
In-Reply-To: <Z34h-hdI8VC_32g4@infradead.org>
On Tue, Jan 07, 2025 at 10:58:02PM -0800, Christoph Hellwig wrote:
> sb_rgcount for file system without a RT subvolume and without the
> metadir/rtgroup feature should be 1. That is because we have an implicit
> default rtgroup that points to the global bitmap and summary inodes,
> which exist even with zero rtblocks. Now for a kernel without
> CONFIG_XFS_RT that probably does not matter, but I'd prefer to keep the
> value consistent for CONFIG_XFS_RT vs !CONFIG_XFS_RT.
>
>
Your explanation seems reasonable to me, thanks for your replay.
Long Li
next prev parent reply other threads:[~2025-01-08 7:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-31 2:34 [PATCH 0/2] xfs: fix two issues regarding mount failures Long Li
2024-12-31 2:34 ` [PATCH 1/2] xfs: correct the sb_rgcount when the disk not support rt volume Long Li
2025-01-06 19:52 ` Darrick J. Wong
2025-01-07 13:11 ` Long Li
2025-01-08 0:32 ` Darrick J. Wong
2025-01-08 1:26 ` Long Li
2025-01-08 6:58 ` Christoph Hellwig
2025-01-08 7:22 ` Long Li [this message]
2025-01-08 6:55 ` Christoph Hellwig
2025-01-08 7:10 ` Long Li
2024-12-31 2:34 ` [PATCH 2/2] xfs: fix mount hang during primary superblock recovery failure Long Li
2025-01-06 19:55 ` Darrick J. Wong
2025-01-07 13:39 ` Long Li
2025-01-08 0:34 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z34nmIFrYqqvHnBe@localhost.localdomain \
--to=leo.lilong@huawei.com \
--cc=cem@kernel.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=houtao1@huawei.com \
--cc=linux-xfs@vger.kernel.org \
--cc=lonuxli.64@gmail.com \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.