All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/3] ARM: dts: imx: add phy-3p0-supply for i.MX6 series
@ 2024-11-26  9:22 Stefan Kerkmann
  2024-11-26  9:22 ` [PATCH 1/3] ARM: dts: imx6qdl: add phy-3p0-supply to usb phys Stefan Kerkmann
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Stefan Kerkmann @ 2024-11-26  9:22 UTC (permalink / raw)
  To: Shawn Guo, Pengutronix Kernel Team
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel, Stefan Kerkmann

The integrated usb phys are supplied by the 3p0 regulator, which has a
voltage range of 2.625V to 3.4V. Thus the min and max values are
corrected and the regulator added as a proper supply for the usb phys.

This fixes the following warnings during the probe of the mxs_phy
driver:

mxs_phy 20c9000.usbphy: supply phy-3p0 not found, using dummy regulator
mxs_phy 20ca000.usbphy: supply phy-3p0 not found, using dummy regulator

The regulator handling was introduced by commit `966d73152078 (usb: phy:
mxs: enable regulator phy-3p0 to improve signal qualilty, 2024-07-26)`.

I have consulted the reference manuals for the affected SoCs but only
tested the changes on an actual i.MX6Q SoC.

Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
---
Stefan Kerkmann (3):
      ARM: dts: imx6qdl: add phy-3p0-supply to usb phys
      ARM: dts: imx6sl: add phy-3p0-supply to usb phys
      ARM: dts: imx6sx: add phy-3p0-supply to usb phys

 arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi | 6 ++++--
 arch/arm/boot/dts/nxp/imx/imx6sl.dtsi  | 6 ++++--
 arch/arm/boot/dts/nxp/imx/imx6sx.dtsi  | 6 ++++--
 3 files changed, 12 insertions(+), 6 deletions(-)
---
base-commit: 7eef7e306d3c40a0c5b9ff6adc9b273cc894dbd5
change-id: 20241126-v6-12-topic-imx-3p0-regulator-440d5a25a980

Best regards,
-- 
Stefan Kerkmann <s.kerkmann@pengutronix.de>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/3] ARM: dts: imx6qdl: add phy-3p0-supply to usb phys
  2024-11-26  9:22 [PATCH 0/3] ARM: dts: imx: add phy-3p0-supply for i.MX6 series Stefan Kerkmann
@ 2024-11-26  9:22 ` Stefan Kerkmann
  2024-11-26  9:22 ` [PATCH 2/3] ARM: dts: imx6sl: " Stefan Kerkmann
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Stefan Kerkmann @ 2024-11-26  9:22 UTC (permalink / raw)
  To: Shawn Guo, Pengutronix Kernel Team
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel, Stefan Kerkmann

The integrated usb phys are supplied by the 3p0 regulator, which has a
voltage range of 2.625V to 3.4V. Thus the min and max values are
corrected and the regulator added as a proper supply for the usb phys.

This fixes the following warnings during the probe of the mxs_phy
driver:

mxs_phy 20c9000.usbphy: supply phy-3p0 not found, using dummy regulator
mxs_phy 20ca000.usbphy: supply phy-3p0 not found, using dummy regulator

The 3p0 regulator handling was introduced by commit 966d73152078 ("usb:
phy: mxs: enable regulator phy-3p0 to improve signal qualilty")`.

Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi
index d2200c9db25aec90dbd348dedee4bfef47eb3ee7..45bcfd7faf9db628479359b5c0a26e1011a7c2d3 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl.dtsi
@@ -711,8 +711,8 @@ reg_vdd1p1: regulator-1p1 {
 				reg_vdd3p0: regulator-3p0 {
 					compatible = "fsl,anatop-regulator";
 					regulator-name = "vdd3p0";
-					regulator-min-microvolt = <2800000>;
-					regulator-max-microvolt = <3150000>;
+					regulator-min-microvolt = <2625000>;
+					regulator-max-microvolt = <3400000>;
 					regulator-always-on;
 					anatop-reg-offset = <0x120>;
 					anatop-vol-bit-shift = <8>;
@@ -806,6 +806,7 @@ usbphy1: usbphy@20c9000 {
 				reg = <0x020c9000 0x1000>;
 				interrupts = <0 44 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clks IMX6QDL_CLK_USBPHY1>;
+				phy-3p0-supply = <&reg_vdd3p0>;
 				fsl,anatop = <&anatop>;
 			};
 
@@ -814,6 +815,7 @@ usbphy2: usbphy@20ca000 {
 				reg = <0x020ca000 0x1000>;
 				interrupts = <0 45 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clks IMX6QDL_CLK_USBPHY2>;
+				phy-3p0-supply = <&reg_vdd3p0>;
 				fsl,anatop = <&anatop>;
 			};
 

-- 
2.39.5


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/3] ARM: dts: imx6sl: add phy-3p0-supply to usb phys
  2024-11-26  9:22 [PATCH 0/3] ARM: dts: imx: add phy-3p0-supply for i.MX6 series Stefan Kerkmann
  2024-11-26  9:22 ` [PATCH 1/3] ARM: dts: imx6qdl: add phy-3p0-supply to usb phys Stefan Kerkmann
@ 2024-11-26  9:22 ` Stefan Kerkmann
  2024-11-26  9:22 ` [PATCH 3/3] ARM: dts: imx6sx: " Stefan Kerkmann
  2024-12-30  4:04 ` [PATCH 0/3] ARM: dts: imx: add phy-3p0-supply for i.MX6 series Shawn Guo
  3 siblings, 0 replies; 5+ messages in thread
From: Stefan Kerkmann @ 2024-11-26  9:22 UTC (permalink / raw)
  To: Shawn Guo, Pengutronix Kernel Team
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel, Stefan Kerkmann

The integrated usb phys are supplied by the 3p0 regulator, which has a
voltage range of 2.625V to 3.4V. Thus the min and max values are
corrected and the regulator added as a proper supply for the usb phys.

This fixes the following warnings during the probe of the mxs_phy
driver:

mxs_phy 20c9000.usbphy: supply phy-3p0 not found, using dummy regulator
mxs_phy 20ca000.usbphy: supply phy-3p0 not found, using dummy regulator

The 3p0 regulator handling was introduced by commit 966d73152078 ("usb:
phy: mxs: enable regulator phy-3p0 to improve signal qualilty")`.

Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
---
 arch/arm/boot/dts/nxp/imx/imx6sl.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi
index 941a2f185056d92f11e6d274d9633b0a3739c4b9..7381fb7f89126e29db05491e751a0d6e519f22f2 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6sl.dtsi
@@ -546,8 +546,8 @@ reg_vdd1p1: regulator-1p1 {
 				reg_vdd3p0: regulator-3p0 {
 					compatible = "fsl,anatop-regulator";
 					regulator-name = "vdd3p0";
-					regulator-min-microvolt = <2800000>;
-					regulator-max-microvolt = <3150000>;
+					regulator-min-microvolt = <2625000>;
+					regulator-max-microvolt = <3400000>;
 					regulator-always-on;
 					anatop-reg-offset = <0x120>;
 					anatop-vol-bit-shift = <8>;
@@ -640,6 +640,7 @@ usbphy1: usbphy@20c9000 {
 				reg = <0x020c9000 0x1000>;
 				interrupts = <0 44 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clks IMX6SL_CLK_USBPHY1>;
+				phy-3p0-supply = <&reg_vdd3p0>;
 				fsl,anatop = <&anatop>;
 			};
 
@@ -648,6 +649,7 @@ usbphy2: usbphy@20ca000 {
 				reg = <0x020ca000 0x1000>;
 				interrupts = <0 45 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clks IMX6SL_CLK_USBPHY2>;
+				phy-3p0-supply = <&reg_vdd3p0>;
 				fsl,anatop = <&anatop>;
 			};
 

-- 
2.39.5


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 3/3] ARM: dts: imx6sx: add phy-3p0-supply to usb phys
  2024-11-26  9:22 [PATCH 0/3] ARM: dts: imx: add phy-3p0-supply for i.MX6 series Stefan Kerkmann
  2024-11-26  9:22 ` [PATCH 1/3] ARM: dts: imx6qdl: add phy-3p0-supply to usb phys Stefan Kerkmann
  2024-11-26  9:22 ` [PATCH 2/3] ARM: dts: imx6sl: " Stefan Kerkmann
@ 2024-11-26  9:22 ` Stefan Kerkmann
  2024-12-30  4:04 ` [PATCH 0/3] ARM: dts: imx: add phy-3p0-supply for i.MX6 series Shawn Guo
  3 siblings, 0 replies; 5+ messages in thread
From: Stefan Kerkmann @ 2024-11-26  9:22 UTC (permalink / raw)
  To: Shawn Guo, Pengutronix Kernel Team
  Cc: devicetree, imx, linux-arm-kernel, linux-kernel, Stefan Kerkmann

The integrated usb phys are supplied by the 3p0 regulator, which has a
voltage range of 2.625V to 3.4V. Thus the min and max values are
corrected and the regulator added as a proper supply for the usb phys.

This fixes the following warnings during the probe of the mxs_phy
driver:

mxs_phy 20c9000.usbphy: supply phy-3p0 not found, using dummy regulator
mxs_phy 20ca000.usbphy: supply phy-3p0 not found, using dummy regulator

The regulator handling was introduced by commit `966d73152078 (usb: phy:
mxs: enable regulator phy-3p0 to improve signal qualilty, 2024-07-26)`.

Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
---
 arch/arm/boot/dts/nxp/imx/imx6sx.dtsi | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi
index a9550f115f82699336f62c33214c9a9bb04e79e0..5132b575b001564b9767605ae7ff044701516673 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6sx.dtsi
@@ -637,8 +637,8 @@ reg_vdd1p1: regulator-1p1 {
 				reg_vdd3p0: regulator-3p0 {
 					compatible = "fsl,anatop-regulator";
 					regulator-name = "vdd3p0";
-					regulator-min-microvolt = <2800000>;
-					regulator-max-microvolt = <3150000>;
+					regulator-min-microvolt = <2625000>;
+					regulator-max-microvolt = <3400000>;
 					regulator-always-on;
 					anatop-reg-offset = <0x120>;
 					anatop-vol-bit-shift = <8>;
@@ -731,6 +731,7 @@ usbphy1: usbphy@20c9000 {
 				reg = <0x020c9000 0x1000>;
 				interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clks IMX6SX_CLK_USBPHY1>;
+				phy-3p0-supply = <&reg_vdd3p0>;
 				fsl,anatop = <&anatop>;
 			};
 
@@ -739,6 +740,7 @@ usbphy2: usbphy@20ca000 {
 				reg = <0x020ca000 0x1000>;
 				interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clks IMX6SX_CLK_USBPHY2>;
+				phy-3p0-supply = <&reg_vdd3p0>;
 				fsl,anatop = <&anatop>;
 			};
 

-- 
2.39.5


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 0/3] ARM: dts: imx: add phy-3p0-supply for i.MX6 series
  2024-11-26  9:22 [PATCH 0/3] ARM: dts: imx: add phy-3p0-supply for i.MX6 series Stefan Kerkmann
                   ` (2 preceding siblings ...)
  2024-11-26  9:22 ` [PATCH 3/3] ARM: dts: imx6sx: " Stefan Kerkmann
@ 2024-12-30  4:04 ` Shawn Guo
  3 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2024-12-30  4:04 UTC (permalink / raw)
  To: Stefan Kerkmann
  Cc: Shawn Guo, Pengutronix Kernel Team, devicetree, imx,
	linux-arm-kernel, linux-kernel

On Tue, Nov 26, 2024 at 10:22:12AM +0100, Stefan Kerkmann wrote:
> Stefan Kerkmann (3):
>       ARM: dts: imx6qdl: add phy-3p0-supply to usb phys
>       ARM: dts: imx6sl: add phy-3p0-supply to usb phys
>       ARM: dts: imx6sx: add phy-3p0-supply to usb phys

Applied all, thanks!


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-12-30  4:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-26  9:22 [PATCH 0/3] ARM: dts: imx: add phy-3p0-supply for i.MX6 series Stefan Kerkmann
2024-11-26  9:22 ` [PATCH 1/3] ARM: dts: imx6qdl: add phy-3p0-supply to usb phys Stefan Kerkmann
2024-11-26  9:22 ` [PATCH 2/3] ARM: dts: imx6sl: " Stefan Kerkmann
2024-11-26  9:22 ` [PATCH 3/3] ARM: dts: imx6sx: " Stefan Kerkmann
2024-12-30  4:04 ` [PATCH 0/3] ARM: dts: imx: add phy-3p0-supply for i.MX6 series Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.