From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nf] netfilter: nf_tables: imbalance in flowtable binding
Date: Fri, 3 Jan 2025 18:37:07 +0100 [thread overview]
Message-ID: <Z3ggQ_KxCOBPfsPa@orbyte.nwl.cc> (raw)
In-Reply-To: <20250102154443.2252675-1-pablo@netfilter.org>
Hi Pablo,
On Thu, Jan 02, 2025 at 04:44:43PM +0100, Pablo Neira Ayuso wrote:
> All these cases cause imbalance between BIND and UNBIND calls:
>
> - Delete an interface from a flowtable with multiple interfaces
>
> - Add a (device to a) flowtable with --check flag
>
> - Delete a netns containing a flowtable
>
> - In an interactive nft session, create a table with owner flag and
> flowtable inside, then quit.
>
> Fix it by calling FLOW_BLOCK_UNBIND when unregistering hooks, then
> remove late FLOW_BLOCK_UNBIND call when destroying flowtable.
>
> Fixes: ff4bf2f42a40 ("netfilter: nf_tables: add nft_unregister_flowtable_hook()")
> Reported-by: Phil Sutter <phil@nwl.cc>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Tested-by: Phil Sutter <phil@nwl.cc>
Added printk calls for debugging and recreated the above scenarios, no
imbalance found. Thanks for your fix!
I have to rebase my pending patch series upon this one now. :)
Cheers, Phil
next prev parent reply other threads:[~2025-01-03 17:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-02 15:44 [PATCH nf] netfilter: nf_tables: imbalance in flowtable binding Pablo Neira Ayuso
2025-01-03 17:37 ` Phil Sutter [this message]
2025-01-03 17:39 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3ggQ_KxCOBPfsPa@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.