All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] serial: 8250_it8768e: Create iTE IT8768E specific 8250 driver
@ 2025-01-09 12:08 WangYuli
  2025-01-09 12:40 ` Arnd Bergmann
  2025-01-11  1:35 ` kernel test robot
  0 siblings, 2 replies; 8+ messages in thread
From: WangYuli @ 2025-01-09 12:08 UTC (permalink / raw)
  To: gregkh, jirislaby, wangyuli
  Cc: linux-kernel, linux-serial, andriy.shevchenko, arnd, schnelle,
	pnewman, sunilvl, paulmck, arnd, zhanjun, guanwentao, Zhuozhen He,
	Guowei Chen

[ General description per its product manual: ]
  The IT8768E-I is a highly integrated Super I/O using the Low Pin
  Count Interface. The device’s LPC interface complies with Intel
  "LPC Interface Specification Rev. 1.1”. The IT8768E-I is ACPI &
  LANDesk compliant.

  Integrated in the IT8768E-I are five logical devices, which can
  be individually enabled or disabled via software configuration
  registers, and four 16C550standard compatible enhanced UARTs
  perofrmacing asynchronous communication. The devices also provide
  GPIO port controlling up to 12 GPIO pins.

  The IT8768E-I utilizes power-saving circuitry to reduce power
  consumption, and once a logical device is disabled, the inputs
  are inhibited with the clock disabled and the outputs are
  tri-stated. The device requires a single 24/48 MHz clock input
  and operates with +3.3V power supply. The IT8768E-I is available
  in 48-pin LQFP.

It has been determined that this chip is currently employed within
YIHUA STS-320 intelligent teller terminals utilizing
PCBA F21-2401 D2000 MB VerA LF motherboards.

Add a driver to support it.

[ Kernel logs without this driver: ]
  [    1.016170] EFI Variables Facility v0.08 2004-May-17
  [    1.034039] Serial: 8250/16550 driver, 32 ports, IRQ sharing enabled
  [    1.035215] serial 0000:06:00.0: enabling device (0000 -> 0002)
  [    1.035649] 0000:06:00.0: ttyS0 at MMIO 0x64100000 (irq = 31, base_baud = 7812500) is a XR17V35X
  [    1.035812] 0000:06:00.0: ttyS1 at MMIO 0x64100400 (irq = 31, base_baud = 7812500) is a XR17V35X
  [    1.035966] 0000:06:00.0: ttyS2 at MMIO 0x64100800 (irq = 31, base_baud = 7812500) is a XR17V35X
  [    1.036119] 0000:06:00.0: ttyS3 at MMIO 0x64100c00 (irq = 31, base_baud = 7812500) is a XR17V35X
  [    1.036271] 0000:06:00.0: ttyS4 at MMIO 0x64101000 (irq = 31, base_baud = 7812500) is a XR17V35X
  [    1.036425] 0000:06:00.0: ttyS5 at MMIO 0x64101400 (irq = 31, base_baud = 7812500) is a XR17V35X
  [    1.036576] 0000:06:00.0: ttyS6 at MMIO 0x64101800 (irq = 31, base_baud = 7812500) is a XR17V35X
  [    1.036727] 0000:06:00.0: ttyS7 at MMIO 0x64101c00 (irq = 31, base_baud = 7812500) is a XR17V35X

[ Kernel logs with this driver: ]
  [    1.017777] EFI Variables Facility v0.08 2004-May-17
  [    1.036036] Serial: 8250/16550 driver, 32 ports, IRQ sharing enabled
  [    1.037286] ITES0001:00: ttyS0 at MMIO 0x20000130 (irq = 0, base_baud = 115200) is a 16550A
  [    1.037444] ITES0001:01: ttyS1 at MMIO 0x20000138 (irq = 0, base_baud = 115200) is a 16550A
  [    1.037607] ITES0001:02: ttyS2 at MMIO 0x20000140 (irq = 0, base_baud = 115200) is a 16550A
  [    1.037759] ITES0001:03: ttyS3 at MMIO 0x20000148 (irq = 0, base_baud = 115200) is a 16550A
  [    1.037906] ITES0001:04: ttyS4 at MMIO 0x20000150 (irq = 0, base_baud = 115200) is a 16550A
  [    1.038056] serial 0000:06:00.0: enabling device (0000 -> 0002)
  [    1.038438] 0000:06:00.0: ttyS5 at MMIO 0x64100000 (irq = 31, base_baud = 7812500) is a XR17V35X
  [    1.038595] 0000:06:00.0: ttyS6 at MMIO 0x64100400 (irq = 31, base_baud = 7812500) is a XR17V35X
  [    1.038749] 0000:06:00.0: ttyS7 at MMIO 0x64100800 (irq = 31, base_baud = 7812500) is a XR17V35X
  [    1.038907] 0000:06:00.0: ttyS8 at MMIO 0x64100c00 (irq = 31, base_baud = 7812500) is a XR17V35X
  [    1.039059] 0000:06:00.0: ttyS9 at MMIO 0x64101000 (irq = 31, base_baud = 7812500) is a XR17V35X
  [    1.039214] 0000:06:00.0: ttyS10 at MMIO 0x64101400 (irq = 31, base_baud = 7812500) is a XR17V35X
  [    1.039367] 0000:06:00.0: ttyS11 at MMIO 0x64101800 (irq = 31, base_baud = 7812500) is a XR17V35X
  [    1.039519] 0000:06:00.0: ttyS12 at MMIO 0x64101c00 (irq = 31, base_baud = 7812500) is a XR17V35X

Reported-by: Zhuozhen He <hezhuozhen@uniontech.com>
Tested-by: Guowei Chen <chenguowei@uniontech.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 drivers/tty/serial/8250/8250_it8768e.c | 138 +++++++++++++++++++++++++
 drivers/tty/serial/8250/Kconfig        |   6 ++
 drivers/tty/serial/8250/Makefile       |   1 +
 3 files changed, 145 insertions(+)
 create mode 100644 drivers/tty/serial/8250/8250_it8768e.c

diff --git a/drivers/tty/serial/8250/8250_it8768e.c b/drivers/tty/serial/8250/8250_it8768e.c
new file mode 100644
index 000000000000..c2c0aeed3918
--- /dev/null
+++ b/drivers/tty/serial/8250/8250_it8768e.c
@@ -0,0 +1,138 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Probe for 8250/16550-type iTE IT8768E serial ports.
+ *
+ * Based on drivers/char/serial.c which is in the history, by Linus Torvalds, Theodore Ts'o.
+ *
+ * Copyright (C) 2025 Uniontech Ltd.
+ * Author: WangYuli <wangyuli@uniontech.com>
+ */
+#include <linux/bitops.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/pci.h>
+#include <linux/pnp.h>
+#include <linux/serial_core.h>
+#include <linux/string.h>
+
+#include <asm/byteorder.h>
+
+#include "8250.h"
+
+struct it8768e_data {
+	struct uart_8250_port uart;
+	int line;
+};
+
+static int it8768e_probe(struct platform_device *pdev)
+{
+	struct it8768e_data *data;
+	struct resource *res;
+	void *__iomem sio_base;
+
+	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+	if (!res) {
+		dev_err(&pdev->dev, "memory resource not found\n");
+		return -EINVAL;
+	}
+
+	sio_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
+	if (!sio_base) {
+		dev_err(&pdev->dev, "devm_ioremap error\n");
+		return -ENOMEM;
+	}
+
+	data = devm_kcalloc(&pdev->dev, 1,
+			sizeof(struct it8768e_data),
+			GFP_KERNEL);
+	if (!data) {
+		dev_err(&pdev->dev, "Failed to alloc private mem struct.\n");
+		return -ENOMEM;
+	}
+
+	spin_lock_init(&data->uart.port.lock);
+	data->uart.port.dev = &pdev->dev;
+	data->uart.port.regshift = 0;
+	data->uart.port.iotype = UPIO_MEM;
+	data->uart.port.type = PORT_16550A;
+	data->uart.port.membase = sio_base;
+	data->uart.port.mapbase = res->start;
+	data->uart.port.uartclk = 1843200;
+	data->uart.port.flags = UPF_FIXED_PORT | UPF_FIXED_TYPE | UPF_SKIP_TEST;
+
+	data->line = serial8250_register_8250_port(&data->uart);
+	if (data->line < 0) {
+		dev_err(&pdev->dev,
+			"unable to resigter 8250 port (MEM%llx): %d\n",
+			(unsigned long long)res->start, 0);
+		return data->line;
+	}
+
+	dev_set_drvdata(&pdev->dev, data);
+	return 0;
+}
+
+static void it8768e_remove(struct platform_device *pdev)
+{
+	struct it8768e_data *data = dev_get_drvdata(&pdev->dev);
+
+	if (!data)
+		return;
+
+	del_timer(&data->uart.timer);
+	serial8250_unregister_port(data->line);
+}
+
+#ifdef CONFIG_PM
+static int it8768e_suspend(struct platform_device *pdev, pm_message_t state)
+{
+	struct it8768e_data *data = dev_get_drvdata(&pdev->dev);
+
+	if (!data)
+		return -ENODEV;
+
+	serial8250_suspend_port(data->line);
+	return 0;
+}
+
+static int it8768e_resume(struct platform_device *pdev)
+{
+	struct it8768e_data *data = dev_get_drvdata(&pdev->dev);
+
+	if (!data)
+		return -ENODEV;
+
+	serial8250_resume_port(data->line);
+
+	return 0;
+}
+#else
+#define it8768e_suspend NULL
+#define it8768e_resume NULL
+#endif /* PM */
+
+#ifdef CONFIG_ACPI
+static const struct acpi_device_id it8768e_acpi_ids[] = {
+	{ .id = "ITES0001" },
+	{}
+};
+MODULE_DEVICE_TABLE(acpi, it8768e_acpi_ids);
+#else
+#define it8768e_acpi_ids NULL
+#endif /* ACPI */
+
+static struct platform_driver it8768e_driver = {
+	.probe	= it8768e_probe,
+	.remove = it8768e_remove,
+	.suspend = it8768e_suspend,
+	.resume	 = it8768e_resume,
+	.driver = {
+		.name = "it8768e",
+		.acpi_match_table = it8768e_acpi_ids,
+	},
+};
+module_platform_driver(it8768e_driver);
+
+MODULE_AUTHOR("WangYuli");
+MODULE_DESCRIPTION("8250 uart driver for iTE IT8768E");
+MODULE_LICENSE("GPL");
diff --git a/drivers/tty/serial/8250/Kconfig b/drivers/tty/serial/8250/Kconfig
index 55d26d16df9b..72e7f33d61d6 100644
--- a/drivers/tty/serial/8250/Kconfig
+++ b/drivers/tty/serial/8250/Kconfig
@@ -569,6 +569,12 @@ config SERIAL_8250_BCM7271
 	  including DMA support and high accuracy BAUD rates, say
 	  Y to this option. If unsure, say N.
 
+config SERIAL_8250_IT8768E
+	tristate "8250 support for iTE IT8768E uart"
+	depends on SERIAL_8250
+	help
+	  This option is used for iTE IT8768E serial ports.
+
 config SERIAL_OF_PLATFORM
 	tristate "Devicetree based probing for 8250 ports"
 	depends on SERIAL_8250 && OF
diff --git a/drivers/tty/serial/8250/Makefile b/drivers/tty/serial/8250/Makefile
index 1516de629b61..97bbf05a49bd 100644
--- a/drivers/tty/serial/8250/Makefile
+++ b/drivers/tty/serial/8250/Makefile
@@ -35,6 +35,7 @@ obj-$(CONFIG_SERIAL_8250_HP300)		+= 8250_hp300.o
 obj-$(CONFIG_SERIAL_8250_HUB6)		+= 8250_hub6.o
 obj-$(CONFIG_SERIAL_8250_INGENIC)	+= 8250_ingenic.o
 obj-$(CONFIG_SERIAL_8250_IOC3)		+= 8250_ioc3.o
+obj-$(CONFIG_SERIAL_8250_IT8768E)	+= 8250_it8768e.o
 obj-$(CONFIG_SERIAL_8250_LPC18XX)	+= 8250_lpc18xx.o
 obj-$(CONFIG_SERIAL_8250_LPSS)		+= 8250_lpss.o
 obj-$(CONFIG_SERIAL_8250_MEN_MCB)	+= 8250_men_mcb.o
-- 
2.47.1


^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2025-01-13 15:32 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-09 12:08 [PATCH] serial: 8250_it8768e: Create iTE IT8768E specific 8250 driver WangYuli
2025-01-09 12:40 ` Arnd Bergmann
2025-01-13  9:59   ` Andy Shevchenko
2025-01-13 10:36     ` Arnd Bergmann
2025-01-13 12:20       ` Andy Shevchenko
2025-01-13 13:12         ` Arnd Bergmann
2025-01-13 15:31           ` Andy Shevchenko
2025-01-11  1:35 ` kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.