From: Keith Busch <kbusch@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
keisuke.nishimura@inria.fr
Subject: Re: [PATCH] nvme: fix bogus kzalloc() return check in nvme_init_effects_log()
Date: Mon, 13 Jan 2025 10:39:19 -0700 [thread overview]
Message-ID: <Z4VPxy8G--jyYFm4@kbusch-mbp> (raw)
In-Reply-To: <9516d209-712a-4a48-9dda-b270e80e3abb@kernel.dk>
On Mon, Jan 13, 2025 at 10:30:06AM -0700, Jens Axboe wrote:
> nvme_init_effects_log() returns failure when kzalloc() is successful,
> which is obviously wrong and causes failures to boot. Correct the
> check.
>
> Fixes: d4a95adeabc6 ("nvme: Add error path for xa_store in nvme_init_effects")
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
Oops. Thanks for the fix
Reviewed-by: Keith Busch <kbusch@kernel.org>
Also applied to nvme-6.14, but feel free to take it directly to
block/for-6.14.
> Caused a boot failure on the first test system I tried. Not sure how
> this got this far without being seen...
I think we've a gap in our blktests for checking driver backward
compatibility. The devices we test against support the Effects log, so
we didn't see this fallback path for older spec revision devices tested
out.
next prev parent reply other threads:[~2025-01-13 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 17:30 [PATCH] nvme: fix bogus kzalloc() return check in nvme_init_effects_log() Jens Axboe
2025-01-13 17:39 ` Keith Busch [this message]
2025-01-13 18:00 ` Jens Axboe
2025-01-13 17:46 ` Keisuke Nishimura
2025-01-13 20:01 ` Chaitanya Kulkarni
2025-01-13 20:03 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z4VPxy8G--jyYFm4@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=keisuke.nishimura@inria.fr \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.