Re: [PATCH] nvme: fix bogus kzalloc() return check in nvme_init_effects_log()

[Jens Axboe <axboe@kernel.dk>]

On 1/13/25 10:39 AM, Keith Busch wrote:
> On Mon, Jan 13, 2025 at 10:30:06AM -0700, Jens Axboe wrote:
>> nvme_init_effects_log() returns failure when kzalloc() is successful,
>> which is obviously wrong and causes failures to boot. Correct the
>> check.
>>
>> Fixes: d4a95adeabc6 ("nvme: Add error path for xa_store in nvme_init_effects")
>> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> 
> Oops. Thanks for the fix
> 
> Reviewed-by: Keith Busch <kbusch@kernel.org>
> 
> Also applied to nvme-6.14, but feel free to take it directly to
> block/for-6.14.

I did, figured that was easier. And if it fails on the one test system
I tested on, guessing it'd break someone using linux-next as well. Hence
let's just shove it in and move on.

-- 
Jens Axboe