[PATCH v2 0/1] qga: Add log to guest-fsfreeze-thaw command

[PATCH v2 0/1] qga: Add log to guest-fsfreeze-thaw command

[Konstantin Kostiuk]

v1 -> v2:
Log only in case of successful thawing

v1: https://patchew.org/QEMU/20241209111817.31307-1-kkostiuk@redhat.com/

Konstantin Kostiuk (1):
  qga: Add log to guest-fsfreeze-thaw command

 qga/commands-posix.c | 2 ++
 qga/commands-win32.c | 3 +++
 2 files changed, 5 insertions(+)

--
2.47.1

[PATCH v2 1/1] qga: Add log to guest-fsfreeze-thaw command

[Konstantin Kostiuk]

Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
---
 qga/commands-posix.c | 2 ++
 qga/commands-win32.c | 3 +++
 2 files changed, 5 insertions(+)

diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 636307bedf..359a56be81 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -805,8 +805,10 @@ int64_t qmp_guest_fsfreeze_thaw(Error **errp)
     int ret;
 
     ret = qmp_guest_fsfreeze_do_thaw(errp);
+
     if (ret >= 0) {
         ga_unset_frozen(ga_state);
+        slog("guest-fsthaw called");
         execute_fsfreeze_hook(FSFREEZE_HOOK_THAW, errp);
     } else {
         ret = 0;
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 038beb8cfa..7d8e260e1f 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -1273,6 +1273,9 @@ int64_t qmp_guest_fsfreeze_thaw(Error **errp)
     qga_vss_fsfreeze(&i, false, NULL, errp);
 
     ga_unset_frozen(ga_state);
+
+    slog("guest-fsthaw called");
+
     return i;
 }
 
-- 
2.47.1

Re: [PATCH v2 1/1] qga: Add log to guest-fsfreeze-thaw command

[Konstantin Kostiuk]

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

ping

On Mon, Dec 16, 2024 at 5:47 PM Konstantin Kostiuk <kkostiuk@redhat.com>
wrote:

> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> ---
>  qga/commands-posix.c | 2 ++
>  qga/commands-win32.c | 3 +++
>  2 files changed, 5 insertions(+)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index 636307bedf..359a56be81 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -805,8 +805,10 @@ int64_t qmp_guest_fsfreeze_thaw(Error **errp)
>      int ret;
>
>      ret = qmp_guest_fsfreeze_do_thaw(errp);
> +
>      if (ret >= 0) {
>          ga_unset_frozen(ga_state);
> +        slog("guest-fsthaw called");
>          execute_fsfreeze_hook(FSFREEZE_HOOK_THAW, errp);
>      } else {
>          ret = 0;
> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
> index 038beb8cfa..7d8e260e1f 100644
> --- a/qga/commands-win32.c
> +++ b/qga/commands-win32.c
> @@ -1273,6 +1273,9 @@ int64_t qmp_guest_fsfreeze_thaw(Error **errp)
>      qga_vss_fsfreeze(&i, false, NULL, errp);
>
>      ga_unset_frozen(ga_state);
> +
> +    slog("guest-fsthaw called");
> +
>      return i;
>  }
>
> --
> 2.47.1
>
>
>

[-- Attachment #2: Type: text/html, Size: 1704 bytes --]

Re: [PATCH v2 1/1] qga: Add log to guest-fsfreeze-thaw command

[Konstantin Kostiuk]

[-- Attachment #1: Type: text/plain, Size: 1328 bytes --]

ping

On Mon, Jan 6, 2025 at 11:37 AM Konstantin Kostiuk <kkostiuk@redhat.com>
wrote:

> ping
>
> On Mon, Dec 16, 2024 at 5:47 PM Konstantin Kostiuk <kkostiuk@redhat.com>
> wrote:
>
>> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
>> ---
>>  qga/commands-posix.c | 2 ++
>>  qga/commands-win32.c | 3 +++
>>  2 files changed, 5 insertions(+)
>>
>> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
>> index 636307bedf..359a56be81 100644
>> --- a/qga/commands-posix.c
>> +++ b/qga/commands-posix.c
>> @@ -805,8 +805,10 @@ int64_t qmp_guest_fsfreeze_thaw(Error **errp)
>>      int ret;
>>
>>      ret = qmp_guest_fsfreeze_do_thaw(errp);
>> +
>>      if (ret >= 0) {
>>          ga_unset_frozen(ga_state);
>> +        slog("guest-fsthaw called");
>>          execute_fsfreeze_hook(FSFREEZE_HOOK_THAW, errp);
>>      } else {
>>          ret = 0;
>> diff --git a/qga/commands-win32.c b/qga/commands-win32.c
>> index 038beb8cfa..7d8e260e1f 100644
>> --- a/qga/commands-win32.c
>> +++ b/qga/commands-win32.c
>> @@ -1273,6 +1273,9 @@ int64_t qmp_guest_fsfreeze_thaw(Error **errp)
>>      qga_vss_fsfreeze(&i, false, NULL, errp);
>>
>>      ga_unset_frozen(ga_state);
>> +
>> +    slog("guest-fsthaw called");
>> +
>>      return i;
>>  }
>>
>> --
>> 2.47.1
>>
>>
>>

[-- Attachment #2: Type: text/html, Size: 2103 bytes --]

Re: [PATCH v2 1/1] qga: Add log to guest-fsfreeze-thaw command

[Daniel P. Berrangé]

On Mon, Dec 16, 2024 at 05:45:52PM +0200, Konstantin Kostiuk wrote:
> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> ---
>  qga/commands-posix.c | 2 ++
>  qga/commands-win32.c | 3 +++
>  2 files changed, 5 insertions(+)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|