All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Joel Granados <joel.granados@kernel.org>
Cc: Chris Down <chris@chrisdown.name>,
	linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	John Ogness <john.ogness@linutronix.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Tony Lindgren <tony.lindgren@linux.intel.com>,
	kernel-team@fb.com
Subject: Re: [PATCH v6 06/11] printk: console: Introduce sysfs interface for per-console loglevels
Date: Wed, 15 Jan 2025 11:31:32 +0100	[thread overview]
Message-ID: <Z4eOhBuzZiFU89Ry@pathway.suse.cz> (raw)
In-Reply-To: <ealgvcqabn5nwfyxk6cv6wwovrbbh6meihea7zfoomcr4gk2nr@7o4izfp2tbd5>

On Fri 2025-01-10 11:27:53, Joel Granados wrote:
> On Mon, Oct 28, 2024 at 04:45:46PM +0000, Chris Down wrote:
> > A sysfs interface under /sys/class/console/ is created that permits
> > viewing and configuring per-console attributes. This is the main
> > interface with which we expect users to interact with and configure
> > per-console loglevels.
> These are different from the knobs that you added to sysctl. right? The
> ones in sysctl are general values as opposed to console specific.
> 
> Would it make sense to put everything in here (sys) instead of having
> them separate?

I thought about this as well. It would be nice to have the setting
in one place.

But I am afraid that it can't be done easily. I think that I looked
this variant and did not find a way how to do it with the existing
API around struct device, /sys/class, ... That said, I am not familiar
with the API. It is quite possible that I just missed it.

One advantage of the /proc/sys/ is that the values might be modified
using the sysctl tool. It might be easier than searching the maze
of directories under /sys. And the global values might be enough
for most users.

Best Regards,
Petr

PS: AFAIK, Chris is going to send an updated version of this patchset.
    He postponed it until the per-console kthreads were introduced...

  reply	other threads:[~2025-01-15 10:31 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-28 16:45 [PATCH v6 00/11] printk: console: Per-console loglevels Chris Down
2024-10-28 16:45 ` [PATCH v6 01/11] printk: Avoid delaying messages that aren't solicited by any console Chris Down
2024-10-28 16:45 ` [PATCH v6 02/11] printk: Use struct console for suppression and extended console state Chris Down
2024-11-08  9:57   ` Petr Mladek
2024-11-15  8:30   ` John Ogness
2024-11-20  4:17     ` Chris Down
2024-11-20 12:03       ` Petr Mladek
2024-10-28 16:45 ` [PATCH v6 03/11] printk: console: Implement core per-console loglevel infrastructure Chris Down
2024-11-08 16:10   ` Petr Mladek
2024-11-12 10:25     ` Petr Mladek
2024-11-14 16:51     ` Petr Mladek
2024-10-28 16:45 ` [PATCH v6 04/11] printk: Support toggling per-console loglevel via syslog() and cmdline Chris Down
2024-11-12 10:56   ` Conflict with FORCE_CON: " Petr Mladek
2024-11-14 19:28     ` Chris Down
2024-11-15 11:41       ` Petr Mladek
2024-11-12 12:59   ` Petr Mladek
2024-11-14 17:14   ` syslog warning: was: " Petr Mladek
2024-11-14 18:53     ` Chris Down
2024-11-15 11:36       ` Petr Mladek
2024-10-28 16:45 ` [PATCH v6 05/11] MAINTAINERS: Mark printk-basics.rst as owned by printk subsystem Chris Down
2024-10-28 23:26   ` Thomas Gleixner
2024-10-28 23:52     ` Chris Down
2024-11-12 13:00   ` Petr Mladek
2024-10-28 16:45 ` [PATCH v6 06/11] printk: console: Introduce sysfs interface for per-console loglevels Chris Down
2024-11-13 15:58   ` Petr Mladek
2024-11-13 15:59   ` register_device: was: " Petr Mladek
2024-11-14 18:41     ` Chris Down
2024-11-15  4:08       ` Greg Kroah-Hartman
2024-11-18 15:19     ` Petr Mladek
2024-11-15  4:20   ` Greg Kroah-Hartman
2024-11-15 14:09     ` Petr Mladek
2024-11-20  5:01     ` Chris Down
2024-11-20  8:43       ` John Ogness
2024-11-20 14:54         ` Petr Mladek
2024-11-20 15:29           ` John Ogness
2024-11-20 14:45       ` Petr Mladek
2025-01-10 10:27   ` Joel Granados
2025-01-15 10:31     ` Petr Mladek [this message]
2024-10-28 16:45 ` [PATCH v6 07/11] printk: Constrain hardware-addressed console checks to name position Chris Down
2024-10-29  8:26   ` Tony Lindgren
2024-11-13 16:11   ` Petr Mladek
2024-10-28 16:45 ` [PATCH v6 08/11] printk: Support setting initial console loglevel via console= on cmdline Chris Down
2024-11-14  9:11   ` Petr Mladek
2024-10-28 16:45 ` [PATCH v6 09/11] printk: Add sysctl interface to set global loglevels Chris Down
2024-11-14 16:21   ` Petr Mladek
2025-01-10 10:09     ` Joel Granados
2024-10-28 16:45 ` [PATCH v6 10/11] printk: Deprecate the kernel.printk sysctl interface Chris Down
2024-11-14 16:25   ` Petr Mladek
2024-10-28 16:46 ` [PATCH v6 11/11] printk: Purge default_console_loglevel Chris Down
2024-11-14 16:38   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z4eOhBuzZiFU89Ry@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=chris@chrisdown.name \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joel.granados@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    --cc=tony.lindgren@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.