All of lore.kernel.org
 help / color / mirror / Atom feed
From: Charlie Jenkins <charlie@rivosinc.com>
To: Cyril Bur <cyrilbur@tenstorrent.com>
Cc: palmer@dabbelt.com, aou@eecs.berkeley.edu,
	paul.walmsley@sifive.com, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org, Jisheng Zhang <jszhang@kernel.org>
Subject: Re: [PATCH v2 3/4] riscv: uaccess: use 'asm goto' for put_user()
Date: Fri, 17 Jan 2025 15:24:16 -0800	[thread overview]
Message-ID: <Z4rmoAtW9vOuU4vz@ghost> (raw)
In-Reply-To: <20241118230112.2872978-4-cyrilbur@tenstorrent.com>

On Mon, Nov 18, 2024 at 11:01:11PM +0000, Cyril Bur wrote:
> From: Jisheng Zhang <jszhang@kernel.org>
> 
> 'asm goto' generates noticeably better code since we don't need to
> test the error etc, the exception just jumps to the error handling
> directly.
> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> Signed-off-by: Cyril Bur <cyrilbur@tenstorrent.com>

Reviewed-by: Charlie Jenkins <charlie@rivosinc.com>
Tested-by: Charlie Jenkins <charlie@rivosinc.com>


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

WARNING: multiple messages have this Message-ID (diff)
From: Charlie Jenkins <charlie@rivosinc.com>
To: Cyril Bur <cyrilbur@tenstorrent.com>
Cc: palmer@dabbelt.com, aou@eecs.berkeley.edu,
	paul.walmsley@sifive.com, linux-riscv@lists.infradead.org,
	linux-kernel@vger.kernel.org, Jisheng Zhang <jszhang@kernel.org>
Subject: Re: [PATCH v2 3/4] riscv: uaccess: use 'asm goto' for put_user()
Date: Fri, 17 Jan 2025 15:24:16 -0800	[thread overview]
Message-ID: <Z4rmoAtW9vOuU4vz@ghost> (raw)
In-Reply-To: <20241118230112.2872978-4-cyrilbur@tenstorrent.com>

On Mon, Nov 18, 2024 at 11:01:11PM +0000, Cyril Bur wrote:
> From: Jisheng Zhang <jszhang@kernel.org>
> 
> 'asm goto' generates noticeably better code since we don't need to
> test the error etc, the exception just jumps to the error handling
> directly.
> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> Signed-off-by: Cyril Bur <cyrilbur@tenstorrent.com>

Reviewed-by: Charlie Jenkins <charlie@rivosinc.com>
Tested-by: Charlie Jenkins <charlie@rivosinc.com>


  reply	other threads:[~2025-01-17 23:24 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-18 23:01 [PATCH v2 0/4] riscv: uaccess: optimizations Cyril Bur
2024-11-18 23:01 ` Cyril Bur
2024-11-18 23:01 ` [PATCH v2 1/4] riscv: implement user_access_begin and families Cyril Bur
2024-11-18 23:01   ` Cyril Bur
2025-01-17 23:21   ` Charlie Jenkins
2025-01-17 23:21     ` Charlie Jenkins
2025-02-05 15:08     ` Ben Dooks
2025-02-05 15:08       ` Ben Dooks
2025-02-13 17:07       ` Cyril Bur
2025-02-13 17:07         ` Cyril Bur
2025-02-13 17:16         ` Ben Dooks
2025-02-13 17:16           ` Ben Dooks
2025-02-18 19:21           ` Cyril Bur
2025-02-18 19:21             ` Cyril Bur
2024-11-18 23:01 ` [PATCH v2 2/4] riscv: uaccess: use input constraints for ptr of __put_user Cyril Bur
2024-11-18 23:01   ` Cyril Bur
2025-01-17 23:23   ` Charlie Jenkins
2025-01-17 23:23     ` Charlie Jenkins
2025-01-17 23:34   ` Jessica Clarke
2025-01-17 23:34     ` Jessica Clarke
2025-01-31  1:31     ` Cyril Bur
2025-01-31  1:31       ` Cyril Bur
2025-01-31  6:00       ` Charlie Jenkins
2025-01-31  6:00         ` Charlie Jenkins
2024-11-18 23:01 ` [PATCH v2 3/4] riscv: uaccess: use 'asm goto' for put_user() Cyril Bur
2024-11-18 23:01   ` Cyril Bur
2025-01-17 23:24   ` Charlie Jenkins [this message]
2025-01-17 23:24     ` Charlie Jenkins
2024-11-18 23:01 ` [PATCH v2 4/4] riscv: uaccess: use 'asm goto output' for get_user Cyril Bur
2024-11-18 23:01   ` Cyril Bur
2025-01-17 23:24   ` Charlie Jenkins
2025-01-17 23:24     ` Charlie Jenkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z4rmoAtW9vOuU4vz@ghost \
    --to=charlie@rivosinc.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=cyrilbur@tenstorrent.com \
    --cc=jszhang@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.