All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: alexandre.belloni@bootlin.com, pgaj@cadence.com,
	miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
	aniketmaurya@google.com, Shyam-sundar.S-k@amd.com,
	jarkko.nikula@linux.intel.com, xiaopei01@kylinos.cn,
	Guruvendra.Punugupati@amd.com, linux-i3c@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] i3c: mipi-i3c-hci: Use DMA-safe buffer for I2C transfers
Date: Tue, 21 Jan 2025 23:19:26 +0100	[thread overview]
Message-ID: <Z5AdbhSetlHIqAEN@ninjato> (raw)
In-Reply-To: <20250121110756.214714-2-billy_tsai@aspeedtech.com>


[-- Attachment #1.1: Type: text/plain, Size: 152 bytes --]


> -		xfer[i].data = i2c_xfers[i].buf;
> +		xfer[i].data = i2c_get_dma_safe_msg_buf(&i2c_xfers[i], 1);

Where is a 'get' there also should be a 'put'.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 111 bytes --]

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: alexandre.belloni@bootlin.com, pgaj@cadence.com,
	miquel.raynal@bootlin.com, conor.culhane@silvaco.com,
	aniketmaurya@google.com, Shyam-sundar.S-k@amd.com,
	jarkko.nikula@linux.intel.com, xiaopei01@kylinos.cn,
	Guruvendra.Punugupati@amd.com, linux-i3c@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] i3c: mipi-i3c-hci: Use DMA-safe buffer for I2C transfers
Date: Tue, 21 Jan 2025 23:19:26 +0100	[thread overview]
Message-ID: <Z5AdbhSetlHIqAEN@ninjato> (raw)
In-Reply-To: <20250121110756.214714-2-billy_tsai@aspeedtech.com>

[-- Attachment #1: Type: text/plain, Size: 152 bytes --]


> -		xfer[i].data = i2c_xfers[i].buf;
> +		xfer[i].data = i2c_get_dma_safe_msg_buf(&i2c_xfers[i], 1);

Where is a 'get' there also should be a 'put'.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-01-29 20:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-21 11:07 [PATCH v1 1/2] i3c: Remove the const qualifier from i2c_msg pointer in i2c_xfers API Billy Tsai
2025-01-21 11:07 ` Billy Tsai
2025-01-21 11:07 ` [PATCH v1 2/2] i3c: mipi-i3c-hci: Use DMA-safe buffer for I2C transfers Billy Tsai
2025-01-21 11:07   ` Billy Tsai
2025-01-21 22:19   ` Wolfram Sang [this message]
2025-01-21 22:19     ` Wolfram Sang
2025-01-23 10:23     ` Billy Tsai
2025-01-23 10:23       ` Billy Tsai
2025-01-22  7:11   ` Mukesh Kumar Savaliya
2025-01-22  7:11     ` Mukesh Kumar Savaliya
2025-01-22  8:28   ` Jarkko Nikula
2025-01-22  8:28     ` Jarkko Nikula
2025-01-21 22:18 ` [PATCH v1 1/2] i3c: Remove the const qualifier from i2c_msg pointer in i2c_xfers API Wolfram Sang
2025-01-21 22:18   ` Wolfram Sang
2025-01-22  7:11 ` Mukesh Kumar Savaliya
2025-01-22  7:11   ` Mukesh Kumar Savaliya
2025-01-22  7:21   ` Wolfram Sang
2025-01-22  7:21     ` Wolfram Sang
2025-01-22  8:42 ` Thomas Weißschuh
2025-01-22  8:42   ` Thomas Weißschuh
2025-02-04 15:15 ` Mukesh Kumar Savaliya
2025-02-04 15:15   ` Mukesh Kumar Savaliya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z5AdbhSetlHIqAEN@ninjato \
    --to=wsa+renesas@sang-engineering.com \
    --cc=Guruvendra.Punugupati@amd.com \
    --cc=Shyam-sundar.S-k@amd.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=aniketmaurya@google.com \
    --cc=billy_tsai@aspeedtech.com \
    --cc=conor.culhane@silvaco.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=pgaj@cadence.com \
    --cc=xiaopei01@kylinos.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.