All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Yury Norov <yury.norov@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-renesas-soc@vger.kernel.org, linux-i3c@lists.infradead.org,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Kuan-Wei Chiu <visitorckw@gmail.com>,
	linus@ucla.edu
Subject: Re: [PATCH] bitops: use safer link explaining the algorithm
Date: Mon, 27 Jan 2025 12:30:54 +0100	[thread overview]
Message-ID: <Z5dubh2mVR9vD0Ws@ninjato> (raw)
In-Reply-To: <CAKwiHFjM+H4ZQ5MjY9FVaHni3XiWnMkoVM8na=KPfHN2Q0eWTg@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 476 bytes --]


> So when I saw this, I even wondered why it needed a comment or
> reference at all. I thought table-in-a-constant was a standard trick
> everybody knows.

I wouldn't go that far.

> Isn't "The constant 0x6996 has bits set in exactly the positions
> corresponding to four-bit numbers with odd parity." enough?

As I wrote in the mail before, I want to aid users who wonder if they
can replace an existing implementation with this generic helper although
it looks different.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 111 bytes --]

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c

WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Yury Norov <yury.norov@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-renesas-soc@vger.kernel.org, linux-i3c@lists.infradead.org,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	Kuan-Wei Chiu <visitorckw@gmail.com>,
	linus@ucla.edu
Subject: Re: [PATCH] bitops: use safer link explaining the algorithm
Date: Mon, 27 Jan 2025 12:30:54 +0100	[thread overview]
Message-ID: <Z5dubh2mVR9vD0Ws@ninjato> (raw)
In-Reply-To: <CAKwiHFjM+H4ZQ5MjY9FVaHni3XiWnMkoVM8na=KPfHN2Q0eWTg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 476 bytes --]


> So when I saw this, I even wondered why it needed a comment or
> reference at all. I thought table-in-a-constant was a standard trick
> everybody knows.

I wouldn't go that far.

> Isn't "The constant 0x6996 has bits set in exactly the positions
> corresponding to four-bit numbers with odd parity." enough?

As I wrote in the mail before, I want to aid users who wonder if they
can replace an existing implementation with this generic helper although
it looks different.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-01-29 20:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-25 13:01 [PATCH] bitops: use safer link explaining the algorithm Wolfram Sang
2025-01-25 13:01 ` Wolfram Sang
2025-01-25 15:10 ` Geert Uytterhoeven
2025-01-25 15:10   ` Geert Uytterhoeven
2025-01-26 17:46   ` Yury Norov
2025-01-26 17:46     ` Yury Norov
2025-01-26 20:16     ` Rasmus Villemoes
2025-01-26 20:16       ` Rasmus Villemoes
2025-01-27 11:30       ` Wolfram Sang [this message]
2025-01-27 11:30         ` Wolfram Sang
2025-01-27 11:28     ` Wolfram Sang
2025-01-27 11:28       ` Wolfram Sang
2025-01-28 13:10       ` Linus Arver
2025-01-28 13:10         ` Linus Arver
2025-01-27 11:09   ` Wolfram Sang
2025-01-27 11:09     ` Wolfram Sang
2025-01-27 13:32     ` Geert Uytterhoeven
2025-01-27 13:32       ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z5dubh2mVR9vD0Ws@ninjato \
    --to=wsa+renesas@sang-engineering.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=geert@linux-m68k.org \
    --cc=linus@ucla.edu \
    --cc=linux-i3c@lists.infradead.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=visitorckw@gmail.com \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.