From: Charlie Jenkins <charlie@rivosinc.com>
To: Quentin Monnet <qmo@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Eduard Zingerman <eddyz87@gmail.com>, Song Liu <song@kernel.org>,
Yonghong Song <yonghong.song@linux.dev>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@fomichev.me>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Mykola Lysenko <mykolal@fb.com>, Shuah Khan <shuah@kernel.org>,
Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <bentiss@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-perf-users@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kselftest@vger.kernel.org, linux-input@vger.kernel.org,
linux-trace-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] tools: Remove redundant quiet setup
Date: Thu, 13 Feb 2025 12:37:16 -0800 [thread overview]
Message-ID: <Z65X_KimLfbE0DG2@ghost> (raw)
In-Reply-To: <21f98687-f715-449c-86f0-c095ea499450@kernel.org>
On Tue, Feb 11, 2025 at 12:00:49AM +0000, Quentin Monnet wrote:
> 2025-02-10 10:34 UTC-0800 ~ Charlie Jenkins <charlie@rivosinc.com>
> > Q is exported from Makefile.include so it is not necessary to manually
> > set it.
> >
> > Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> > ---
> > tools/arch/arm64/tools/Makefile | 6 ------
> > tools/bpf/Makefile | 6 ------
> > tools/bpf/bpftool/Documentation/Makefile | 6 ------
> > tools/bpf/bpftool/Makefile | 6 ------
> > tools/bpf/resolve_btfids/Makefile | 2 --
> > tools/bpf/runqslower/Makefile | 5 +----
> > tools/lib/bpf/Makefile | 13 -------------
> > tools/lib/perf/Makefile | 13 -------------
> > tools/lib/thermal/Makefile | 13 -------------
> > tools/objtool/Makefile | 6 ------
> > tools/testing/selftests/bpf/Makefile.docs | 6 ------
> > tools/testing/selftests/hid/Makefile | 2 --
> > tools/thermal/lib/Makefile | 13 -------------
> > tools/tracing/latency/Makefile | 6 ------
> > tools/tracing/rtla/Makefile | 6 ------
> > tools/verification/rv/Makefile | 6 ------
> > 16 files changed, 1 insertion(+), 114 deletions(-)
> >
>
>
> [...]
>
>
> > diff --git a/tools/bpf/bpftool/Documentation/Makefile b/tools/bpf/bpftool/Documentation/Makefile
> > index 4315652678b9f2e27e48b7815f3b9ddc70a57165..bf843f328812e10dd65a73f355f74e6825ad95b9 100644
> > --- a/tools/bpf/bpftool/Documentation/Makefile
> > +++ b/tools/bpf/bpftool/Documentation/Makefile
> > @@ -5,12 +5,6 @@ INSTALL ?= install
> > RM ?= rm -f
> > RMDIR ?= rmdir --ignore-fail-on-non-empty
> >
> > -ifeq ($(V),1)
> > - Q =
> > -else
> > - Q = @
> > -endif
> > -
> > prefix ?= /usr/local
> > mandir ?= $(prefix)/man
> > man8dir = $(mandir)/man8
> > diff --git a/tools/bpf/bpftool/Makefile b/tools/bpf/bpftool/Makefile
> > index dd9f3ec842017f1dd24054bf3a0986d546811dc4..6ea4823b770cbbe7fd9eb7da79956cc1dae1f204 100644
> > --- a/tools/bpf/bpftool/Makefile
> > +++ b/tools/bpf/bpftool/Makefile
> > @@ -7,12 +7,6 @@ srctree := $(patsubst %/,%,$(dir $(srctree)))
> > srctree := $(patsubst %/,%,$(dir $(srctree)))
> > endif
> >
> > -ifeq ($(V),1)
> > - Q =
> > -else
> > - Q = @
> > -endif
> > -
> > BPF_DIR = $(srctree)/tools/lib/bpf
> >
> > ifneq ($(OUTPUT),)
>
>
> This is OK from bpftool's side, the GitHub mirror has a Makefile.include
> included from both main and doc Makefiles, and where I can move this
> definition.
I am glad to hear. Thank you for helping me unify this infrastructure!
- Charlie
>
> Acked-by: Quentin Monnet <qmo@kernel.org>
>
> Thanks
prev parent reply other threads:[~2025-02-13 20:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 18:34 [PATCH v2 0/2] tools: Unify top-level quiet infrastructure Charlie Jenkins
2025-02-10 18:34 ` [PATCH v2 1/2] " Charlie Jenkins
2025-02-11 13:38 ` Jiri Olsa
2025-02-13 20:36 ` Charlie Jenkins
2025-02-10 18:34 ` [PATCH v2 2/2] tools: Remove redundant quiet setup Charlie Jenkins
2025-02-11 0:00 ` Quentin Monnet
2025-02-13 20:37 ` Charlie Jenkins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z65X_KimLfbE0DG2@ghost \
--to=charlie@rivosinc.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bentiss@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=irogers@google.com \
--cc=jikos@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=mark.rutland@arm.com \
--cc=martin.lau@linux.dev \
--cc=mingo@redhat.com \
--cc=mykolal@fb.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=qmo@kernel.org \
--cc=rafael@kernel.org \
--cc=rostedt@goodmis.org \
--cc=rui.zhang@intel.com \
--cc=sdf@fomichev.me \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.