From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: don't kobject_put in the error case
Date: Mon, 3 Feb 2025 18:32:37 +0000 [thread overview]
Message-ID: <Z6ELxSbeYXaKIhNo@google.com> (raw)
In-Reply-To: <20250131222457.1634039-1-jaegeuk@kernel.org>
I checked this patch is wrong. Sorry for the noise.
On 01/31, Jaegeuk Kim wrote:
> Fix a wrong kobject_put in the error path.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/sysfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> index d15c68b28952..001e97cd0a96 100644
> --- a/fs/f2fs/sysfs.c
> +++ b/fs/f2fs/sysfs.c
> @@ -1605,7 +1605,7 @@ int __init f2fs_init_sysfs(void)
> ret = kobject_init_and_add(&f2fs_feat, &f2fs_feat_ktype,
> NULL, "features");
> if (ret)
> - goto put_kobject;
> + goto unregister_out;
>
> f2fs_proc_root = proc_mkdir("fs/f2fs", NULL);
> if (!f2fs_proc_root) {
> @@ -1616,6 +1616,7 @@ int __init f2fs_init_sysfs(void)
> return 0;
> put_kobject:
> kobject_put(&f2fs_feat);
> +unregister_out:
> kset_unregister(&f2fs_kset);
> return ret;
> }
> --
> 2.48.1.362.g079036d154-goog
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/2] f2fs: don't kobject_put in the error case
Date: Mon, 3 Feb 2025 18:32:37 +0000 [thread overview]
Message-ID: <Z6ELxSbeYXaKIhNo@google.com> (raw)
In-Reply-To: <20250131222457.1634039-1-jaegeuk@kernel.org>
I checked this patch is wrong. Sorry for the noise.
On 01/31, Jaegeuk Kim wrote:
> Fix a wrong kobject_put in the error path.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/sysfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c
> index d15c68b28952..001e97cd0a96 100644
> --- a/fs/f2fs/sysfs.c
> +++ b/fs/f2fs/sysfs.c
> @@ -1605,7 +1605,7 @@ int __init f2fs_init_sysfs(void)
> ret = kobject_init_and_add(&f2fs_feat, &f2fs_feat_ktype,
> NULL, "features");
> if (ret)
> - goto put_kobject;
> + goto unregister_out;
>
> f2fs_proc_root = proc_mkdir("fs/f2fs", NULL);
> if (!f2fs_proc_root) {
> @@ -1616,6 +1616,7 @@ int __init f2fs_init_sysfs(void)
> return 0;
> put_kobject:
> kobject_put(&f2fs_feat);
> +unregister_out:
> kset_unregister(&f2fs_kset);
> return ret;
> }
> --
> 2.48.1.362.g079036d154-goog
next prev parent reply other threads:[~2025-02-03 18:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 22:24 [f2fs-dev] [PATCH 1/2] f2fs: don't kobject_put in the error case Jaegeuk Kim via Linux-f2fs-devel
2025-01-31 22:24 ` Jaegeuk Kim
2025-01-31 22:24 ` [f2fs-dev] [PATCH 2/2] f2fs: introduce f2fs_base_attr for global sysfs entries Jaegeuk Kim via Linux-f2fs-devel
2025-01-31 22:24 ` Jaegeuk Kim
2025-02-06 2:11 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-02-06 2:11 ` Chao Yu
2025-02-02 14:58 ` [f2fs-dev] [PATCH 1/2] f2fs: don't kobject_put in the error case Markus Elfring via Linux-f2fs-devel
2025-02-02 14:58 ` Markus Elfring
2025-02-03 18:32 ` Jaegeuk Kim via Linux-f2fs-devel [this message]
2025-02-03 18:32 ` Jaegeuk Kim
2025-02-06 18:40 ` [f2fs-dev] " patchwork-bot+f2fs--- via Linux-f2fs-devel
2025-02-06 18:40 ` patchwork-bot+f2fs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6ELxSbeYXaKIhNo@google.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=jaegeuk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.