* Re: [PATCH] rockchip: io-domain: Enable by default for all supported SoCs
2025-02-04 17:23 [PATCH] rockchip: io-domain: Enable by default for all supported SoCs Chen-Yu Tsai
@ 2025-02-04 17:41 ` Quentin Schulz
2025-02-04 18:19 ` Paul Kocialkowski
` (3 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Quentin Schulz @ 2025-02-04 17:41 UTC (permalink / raw)
To: Chen-Yu Tsai, u-boot
Cc: Chen-Yu Tsai, Akash Gajjar, Alexandre Vicenzi, Alper Nebi Yasak,
Andy Yan, Christopher Obbard, Deepak Das, Dragan Simic,
FUKAUMI Naoki, Heiko Stuebner, Jagan Teki, Jonas Karlman,
Kever Yang, Klaus Goger, Levin Du, Manivannan Sadhasivam,
Marek Behún, Nick Xie, Paul Kocialkowski, Peter Robinson,
Raymond Mao, Shantur Rathore, Simon Glass, Stefan Roese,
Suniel Mahesh, Tien Fong Chee, Tom Rini, Wan Yee Lau, Xiaobo Tian
Hi Chen-Yu,
On 2/4/25 6:23 PM, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@csie.org>
>
> The IO domain driver controls the I/O voltage for various pins,
> MMC included.
>
> Enable it by default for all supported Rockchip SoCs.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Thanks!
Quentin
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] rockchip: io-domain: Enable by default for all supported SoCs
2025-02-04 17:23 [PATCH] rockchip: io-domain: Enable by default for all supported SoCs Chen-Yu Tsai
2025-02-04 17:41 ` Quentin Schulz
@ 2025-02-04 18:19 ` Paul Kocialkowski
2025-03-30 10:52 ` Jonas Karlman
` (2 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Paul Kocialkowski @ 2025-02-04 18:19 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: u-boot, Chen-Yu Tsai, Akash Gajjar, Alexandre Vicenzi,
Alper Nebi Yasak, Andy Yan, Christopher Obbard, Deepak Das,
Dragan Simic, FUKAUMI Naoki, Heiko Stuebner, Jagan Teki,
Jonas Karlman, Kever Yang, Klaus Goger, Levin Du,
Manivannan Sadhasivam, Marek Behún, Nick Xie, Peter Robinson,
Philipp Tomsich, Quentin Schulz, Raymond Mao, Shantur Rathore,
Simon Glass, Stefan Roese, Suniel Mahesh, Tien Fong Chee,
Tom Rini, Wan Yee Lau, Xiaobo Tian
[-- Attachment #1: Type: text/plain, Size: 17208 bytes --]
Hi Chen-Yu,
Le Wed 05 Feb 25, 01:23, Chen-Yu Tsai a écrit :
> From: Chen-Yu Tsai <wens@csie.org>
>
> The IO domain driver controls the I/O voltage for various pins,
> MMC included.
>
> Enable it by default for all supported Rockchip SoCs.
Thanks for the cleanup!
Reviewed-by: Paul Kocialkowski <paulk@sys-base.io>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>
> configs/chromebook_bob_defconfig | 1 -
> configs/chromebook_kevin_defconfig | 1 -
> configs/eaidk-610-rk3399_defconfig | 1 -
> configs/ficus-rk3399_defconfig | 1 -
> configs/firefly-rk3399_defconfig | 1 -
> configs/khadas-edge-captain-rk3399_defconfig | 1 -
> configs/khadas-edge-rk3399_defconfig | 1 -
> configs/khadas-edge-v-rk3399_defconfig | 1 -
> configs/leez-rk3399_defconfig | 1 -
> configs/nanopc-t4-rk3399_defconfig | 1 -
> configs/nanopi-m4-2gb-rk3399_defconfig | 1 -
> configs/nanopi-m4-rk3399_defconfig | 1 -
> configs/nanopi-m4b-rk3399_defconfig | 1 -
> configs/nanopi-neo4-rk3399_defconfig | 1 -
> configs/nanopi-r4s-rk3399_defconfig | 1 -
> configs/orangepi-rk3399_defconfig | 1 -
> configs/pinebook-pro-rk3399_defconfig | 1 -
> configs/pinephone-pro-rk3399_defconfig | 1 -
> configs/puma-rk3399_defconfig | 1 -
> configs/ringneck-px30_defconfig | 1 -
> configs/roc-pc-mezzanine-rk3399_defconfig | 1 -
> configs/roc-pc-rk3399_defconfig | 1 -
> configs/rock-4c-plus-rk3399_defconfig | 1 -
> configs/rock-4se-rk3399_defconfig | 1 -
> configs/rock-pi-4-rk3399_defconfig | 1 -
> configs/rock-pi-4c-rk3399_defconfig | 1 -
> configs/rock-pi-n10-rk3399pro_defconfig | 1 -
> configs/rock-pi-s-rk3308_defconfig | 1 -
> configs/rock-s0-rk3308_defconfig | 1 -
> configs/rock960-rk3399_defconfig | 1 -
> configs/rockpro64-rk3399_defconfig | 1 -
> drivers/misc/Kconfig | 6 +++++-
> 32 files changed, 5 insertions(+), 32 deletions(-)
>
> diff --git a/configs/chromebook_bob_defconfig b/configs/chromebook_bob_defconfig
> index 1b018ef4d7c8..7b45095fc041 100644
> --- a/configs/chromebook_bob_defconfig
> +++ b/configs/chromebook_bob_defconfig
> @@ -57,7 +57,6 @@ CONFIG_I2C_CROS_EC_TUNNEL=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_I2C_MUX=y
> CONFIG_CROS_EC_KEYB=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_CROS_EC=y
> CONFIG_CROS_EC_SPI=y
> CONFIG_PWRSEQ=y
> diff --git a/configs/chromebook_kevin_defconfig b/configs/chromebook_kevin_defconfig
> index 1ee0c0e6c9d8..cecd89cded45 100644
> --- a/configs/chromebook_kevin_defconfig
> +++ b/configs/chromebook_kevin_defconfig
> @@ -58,7 +58,6 @@ CONFIG_I2C_CROS_EC_TUNNEL=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_I2C_MUX=y
> CONFIG_CROS_EC_KEYB=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_CROS_EC=y
> CONFIG_CROS_EC_SPI=y
> CONFIG_PWRSEQ=y
> diff --git a/configs/eaidk-610-rk3399_defconfig b/configs/eaidk-610-rk3399_defconfig
> index 8f9a76157f16..45a2d9016830 100644
> --- a/configs/eaidk-610-rk3399_defconfig
> +++ b/configs/eaidk-610-rk3399_defconfig
> @@ -31,7 +31,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/ficus-rk3399_defconfig b/configs/ficus-rk3399_defconfig
> index b32ca726b6cf..3a72156d3894 100644
> --- a/configs/ficus-rk3399_defconfig
> +++ b/configs/ficus-rk3399_defconfig
> @@ -37,7 +37,6 @@ CONFIG_SCSI_AHCI=y
> CONFIG_AHCI_PCI=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig
> index 3871627318b6..be8cde094466 100644
> --- a/configs/firefly-rk3399_defconfig
> +++ b/configs/firefly-rk3399_defconfig
> @@ -34,7 +34,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/khadas-edge-captain-rk3399_defconfig b/configs/khadas-edge-captain-rk3399_defconfig
> index 89611a0535ed..ce425eb9b20c 100644
> --- a/configs/khadas-edge-captain-rk3399_defconfig
> +++ b/configs/khadas-edge-captain-rk3399_defconfig
> @@ -45,7 +45,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> # CONFIG_USB_FUNCTION_FASTBOOT is not set
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/khadas-edge-rk3399_defconfig b/configs/khadas-edge-rk3399_defconfig
> index 3816f4327a61..10a20d749ba5 100644
> --- a/configs/khadas-edge-rk3399_defconfig
> +++ b/configs/khadas-edge-rk3399_defconfig
> @@ -43,7 +43,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> # CONFIG_USB_FUNCTION_FASTBOOT is not set
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/khadas-edge-v-rk3399_defconfig b/configs/khadas-edge-v-rk3399_defconfig
> index 35e209425729..d3345c12fe25 100644
> --- a/configs/khadas-edge-v-rk3399_defconfig
> +++ b/configs/khadas-edge-v-rk3399_defconfig
> @@ -45,7 +45,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> # CONFIG_USB_FUNCTION_FASTBOOT is not set
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/leez-rk3399_defconfig b/configs/leez-rk3399_defconfig
> index 57b097377fab..f12f39857e00 100644
> --- a/configs/leez-rk3399_defconfig
> +++ b/configs/leez-rk3399_defconfig
> @@ -31,7 +31,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/nanopc-t4-rk3399_defconfig b/configs/nanopc-t4-rk3399_defconfig
> index 26c12c510785..40844753ccd8 100644
> --- a/configs/nanopc-t4-rk3399_defconfig
> +++ b/configs/nanopc-t4-rk3399_defconfig
> @@ -34,7 +34,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/nanopi-m4-2gb-rk3399_defconfig b/configs/nanopi-m4-2gb-rk3399_defconfig
> index d24b7bc6d174..31b0e83cdea6 100644
> --- a/configs/nanopi-m4-2gb-rk3399_defconfig
> +++ b/configs/nanopi-m4-2gb-rk3399_defconfig
> @@ -38,7 +38,6 @@ CONFIG_SCSI_AHCI=y
> CONFIG_AHCI_PCI=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/nanopi-m4-rk3399_defconfig b/configs/nanopi-m4-rk3399_defconfig
> index da3e44af8418..1a9b770c1692 100644
> --- a/configs/nanopi-m4-rk3399_defconfig
> +++ b/configs/nanopi-m4-rk3399_defconfig
> @@ -37,7 +37,6 @@ CONFIG_SCSI_AHCI=y
> CONFIG_AHCI_PCI=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/nanopi-m4b-rk3399_defconfig b/configs/nanopi-m4b-rk3399_defconfig
> index 247056ab58b4..d3a8b5bb6d1f 100644
> --- a/configs/nanopi-m4b-rk3399_defconfig
> +++ b/configs/nanopi-m4b-rk3399_defconfig
> @@ -37,7 +37,6 @@ CONFIG_SCSI_AHCI=y
> CONFIG_AHCI_PCI=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/nanopi-neo4-rk3399_defconfig b/configs/nanopi-neo4-rk3399_defconfig
> index 305877d20796..1e422befdf8e 100644
> --- a/configs/nanopi-neo4-rk3399_defconfig
> +++ b/configs/nanopi-neo4-rk3399_defconfig
> @@ -32,7 +32,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/nanopi-r4s-rk3399_defconfig b/configs/nanopi-r4s-rk3399_defconfig
> index a6dafe3d9eb5..04642bca7cbd 100644
> --- a/configs/nanopi-r4s-rk3399_defconfig
> +++ b/configs/nanopi-r4s-rk3399_defconfig
> @@ -32,7 +32,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/orangepi-rk3399_defconfig b/configs/orangepi-rk3399_defconfig
> index fdf3d6989393..d5091ee8a0c5 100644
> --- a/configs/orangepi-rk3399_defconfig
> +++ b/configs/orangepi-rk3399_defconfig
> @@ -32,7 +32,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/pinebook-pro-rk3399_defconfig b/configs/pinebook-pro-rk3399_defconfig
> index dfa927ccb170..676d1e718945 100644
> --- a/configs/pinebook-pro-rk3399_defconfig
> +++ b/configs/pinebook-pro-rk3399_defconfig
> @@ -51,7 +51,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_IO_VOLTAGE=y
> CONFIG_SPL_MMC_IO_VOLTAGE=y
> CONFIG_MMC_UHS_SUPPORT=y
> diff --git a/configs/pinephone-pro-rk3399_defconfig b/configs/pinephone-pro-rk3399_defconfig
> index 5e16749ba7d4..85833c654b8f 100644
> --- a/configs/pinephone-pro-rk3399_defconfig
> +++ b/configs/pinephone-pro-rk3399_defconfig
> @@ -47,7 +47,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/puma-rk3399_defconfig b/configs/puma-rk3399_defconfig
> index 7a180b141303..95ed6eea953d 100644
> --- a/configs/puma-rk3399_defconfig
> +++ b/configs/puma-rk3399_defconfig
> @@ -64,7 +64,6 @@ CONFIG_GPIO_HOG=y
> CONFIG_SPL_GPIO_HOG=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/ringneck-px30_defconfig b/configs/ringneck-px30_defconfig
> index 324581b4082e..93caaf68e2d7 100644
> --- a/configs/ringneck-px30_defconfig
> +++ b/configs/ringneck-px30_defconfig
> @@ -81,7 +81,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_MISC=y
> CONFIG_ROCKCHIP_OTP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_SUPPORT_EMMC_RPMB=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> diff --git a/configs/roc-pc-mezzanine-rk3399_defconfig b/configs/roc-pc-mezzanine-rk3399_defconfig
> index 3ab5fd69c62a..9c063ce82d34 100644
> --- a/configs/roc-pc-mezzanine-rk3399_defconfig
> +++ b/configs/roc-pc-mezzanine-rk3399_defconfig
> @@ -45,7 +45,6 @@ CONFIG_ENV_IS_IN_SPI_FLASH=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/roc-pc-rk3399_defconfig b/configs/roc-pc-rk3399_defconfig
> index 0ef867487787..68c4267d2426 100644
> --- a/configs/roc-pc-rk3399_defconfig
> +++ b/configs/roc-pc-rk3399_defconfig
> @@ -43,7 +43,6 @@ CONFIG_ENV_IS_IN_SPI_FLASH=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/rock-4c-plus-rk3399_defconfig b/configs/rock-4c-plus-rk3399_defconfig
> index 0c73a212ea1f..2f1ea314302f 100644
> --- a/configs/rock-4c-plus-rk3399_defconfig
> +++ b/configs/rock-4c-plus-rk3399_defconfig
> @@ -49,7 +49,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/rock-4se-rk3399_defconfig b/configs/rock-4se-rk3399_defconfig
> index 3ae19692155a..7387130ecc18 100644
> --- a/configs/rock-4se-rk3399_defconfig
> +++ b/configs/rock-4se-rk3399_defconfig
> @@ -53,7 +53,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/rock-pi-4-rk3399_defconfig b/configs/rock-pi-4-rk3399_defconfig
> index f3a5c2c45f35..97a7db3730df 100644
> --- a/configs/rock-pi-4-rk3399_defconfig
> +++ b/configs/rock-pi-4-rk3399_defconfig
> @@ -54,7 +54,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/rock-pi-4c-rk3399_defconfig b/configs/rock-pi-4c-rk3399_defconfig
> index 9bda50c8c77f..7da7ee4bce16 100644
> --- a/configs/rock-pi-4c-rk3399_defconfig
> +++ b/configs/rock-pi-4c-rk3399_defconfig
> @@ -54,7 +54,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/rock-pi-n10-rk3399pro_defconfig b/configs/rock-pi-n10-rk3399pro_defconfig
> index a9c6d8a907a9..a38670d95d0e 100644
> --- a/configs/rock-pi-n10-rk3399pro_defconfig
> +++ b/configs/rock-pi-n10-rk3399pro_defconfig
> @@ -35,7 +35,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/rock-pi-s-rk3308_defconfig b/configs/rock-pi-s-rk3308_defconfig
> index 4b08af309b1b..907b999b274d 100644
> --- a/configs/rock-pi-s-rk3308_defconfig
> +++ b/configs/rock-pi-s-rk3308_defconfig
> @@ -40,7 +40,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_SUPPORT_EMMC_RPMB=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> diff --git a/configs/rock-s0-rk3308_defconfig b/configs/rock-s0-rk3308_defconfig
> index 0a46e7bb1871..a762734231a0 100644
> --- a/configs/rock-s0-rk3308_defconfig
> +++ b/configs/rock-s0-rk3308_defconfig
> @@ -40,7 +40,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_SUPPORT_EMMC_RPMB=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> diff --git a/configs/rock960-rk3399_defconfig b/configs/rock960-rk3399_defconfig
> index aebfa73459ca..607aa61ba172 100644
> --- a/configs/rock960-rk3399_defconfig
> +++ b/configs/rock960-rk3399_defconfig
> @@ -41,7 +41,6 @@ CONFIG_SYS_MMC_ENV_DEV=1
> # CONFIG_USB_FUNCTION_FASTBOOT is not set
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig
> index 75322073285c..1b887cd9f3ea 100644
> --- a/configs/rockpro64-rk3399_defconfig
> +++ b/configs/rockpro64-rk3399_defconfig
> @@ -49,7 +49,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index da84b35e8043..9f8bef5068c8 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -104,7 +104,11 @@ config ROCKCHIP_OTP
> config ROCKCHIP_IODOMAIN
> bool "Rockchip IO-domain driver support"
> depends on DM_REGULATOR && ARCH_ROCKCHIP
> - default y if ROCKCHIP_RK3328 || ROCKCHIP_RK3568
> + default y if ROCKCHIP_PX30
> + default y if ROCKCHIP_RK3308
> + default y if ROCKCHIP_RK3328
> + default y if ROCKCHIP_RK3399
> + default y if ROCKCHIP_RK3568
> help
> Enable support for IO-domains in Rockchip SoCs. It is necessary
> for the IO-domain setting of the SoC to match the voltage supplied
> --
> 2.39.5
>
--
Paul Kocialkowski,
Independent contractor - sys-base - https://www.sys-base.io/
Free software developer - https://www.paulk.fr/
Expert in multimedia, graphics and embedded hardware support with Linux.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] rockchip: io-domain: Enable by default for all supported SoCs
2025-02-04 17:23 [PATCH] rockchip: io-domain: Enable by default for all supported SoCs Chen-Yu Tsai
2025-02-04 17:41 ` Quentin Schulz
2025-02-04 18:19 ` Paul Kocialkowski
@ 2025-03-30 10:52 ` Jonas Karlman
2025-03-30 13:33 ` Anand Moon
2025-05-06 8:06 ` Kever Yang
4 siblings, 0 replies; 12+ messages in thread
From: Jonas Karlman @ 2025-03-30 10:52 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: u-boot@lists.denx.de, Chen-Yu Tsai, Akash Gajjar,
Alexandre Vicenzi, Alper Nebi Yasak, Andy Yan, Christopher Obbard,
Deepak Das, Dragan Simic, FUKAUMI Naoki, Heiko Stuebner,
Jagan Teki, Kever Yang, Klaus Goger, Levin Du,
Manivannan Sadhasivam, Marek Behún, Nick Xie,
Paul Kocialkowski, Peter Robinson, Philipp Tomsich,
Quentin Schulz, Raymond Mao, Shantur Rathore, Simon Glass,
Stefan Roese, Suniel Mahesh, Tien Fong Chee, Tom Rini,
Wan Yee Lau, Xiaobo Tian
Hi,
On 2025-02-04 18:23, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@csie.org>
>
> The IO domain driver controls the I/O voltage for various pins,
> MMC included.
>
> Enable it by default for all supported Rockchip SoCs.
This will also enable the IO domain driver for evb-rk3399_defconfig,
something we want to avoid as that target has typically also been used
as a fallback/generic rk3399 target.
The IO domain driver was excluded from the evb-rk3328_defconfig for that
specific reason.
I have sent a series that adds generic-rk3328/rk3399 targets that can
help replace such use of the evb-rk3328/rk3399 targets. However, I
suggest we keep IO domain driver disabled on the evb targets for one
more release before enabling it. Will shortly send a v2 of the generic
series with ROCKCHIP_IODOMAIN=n for the rk3399 target.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
>
> configs/chromebook_bob_defconfig | 1 -
> configs/chromebook_kevin_defconfig | 1 -
> configs/eaidk-610-rk3399_defconfig | 1 -
> configs/ficus-rk3399_defconfig | 1 -
> configs/firefly-rk3399_defconfig | 1 -
> configs/khadas-edge-captain-rk3399_defconfig | 1 -
> configs/khadas-edge-rk3399_defconfig | 1 -
> configs/khadas-edge-v-rk3399_defconfig | 1 -
> configs/leez-rk3399_defconfig | 1 -
> configs/nanopc-t4-rk3399_defconfig | 1 -
> configs/nanopi-m4-2gb-rk3399_defconfig | 1 -
> configs/nanopi-m4-rk3399_defconfig | 1 -
> configs/nanopi-m4b-rk3399_defconfig | 1 -
> configs/nanopi-neo4-rk3399_defconfig | 1 -
> configs/nanopi-r4s-rk3399_defconfig | 1 -
> configs/orangepi-rk3399_defconfig | 1 -
> configs/pinebook-pro-rk3399_defconfig | 1 -
> configs/pinephone-pro-rk3399_defconfig | 1 -
> configs/puma-rk3399_defconfig | 1 -
> configs/ringneck-px30_defconfig | 1 -
> configs/roc-pc-mezzanine-rk3399_defconfig | 1 -
> configs/roc-pc-rk3399_defconfig | 1 -
> configs/rock-4c-plus-rk3399_defconfig | 1 -
> configs/rock-4se-rk3399_defconfig | 1 -
> configs/rock-pi-4-rk3399_defconfig | 1 -
> configs/rock-pi-4c-rk3399_defconfig | 1 -
> configs/rock-pi-n10-rk3399pro_defconfig | 1 -
> configs/rock-pi-s-rk3308_defconfig | 1 -
> configs/rock-s0-rk3308_defconfig | 1 -
> configs/rock960-rk3399_defconfig | 1 -
> configs/rockpro64-rk3399_defconfig | 1 -
> drivers/misc/Kconfig | 6 +++++-
> 32 files changed, 5 insertions(+), 32 deletions(-)
>
Please add following to evb-rk3399_defconfig in a v2.
# CONFIG_ROCKCHIP_IODOMAIN is not set
With that fixed, this is:
Reviewed-by: Jonas Karlman <jonas@kwiboo.se>
Regards,
Jonas
[snip]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] rockchip: io-domain: Enable by default for all supported SoCs
2025-02-04 17:23 [PATCH] rockchip: io-domain: Enable by default for all supported SoCs Chen-Yu Tsai
` (2 preceding siblings ...)
2025-03-30 10:52 ` Jonas Karlman
@ 2025-03-30 13:33 ` Anand Moon
2025-03-31 15:08 ` Chen-Yu Tsai
2025-04-01 3:00 ` Kever Yang
2025-05-06 8:06 ` Kever Yang
4 siblings, 2 replies; 12+ messages in thread
From: Anand Moon @ 2025-03-30 13:33 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: u-boot, Chen-Yu Tsai, Akash Gajjar, Alexandre Vicenzi,
Alper Nebi Yasak, Andy Yan, Christopher Obbard, Deepak Das,
Dragan Simic, FUKAUMI Naoki, Heiko Stuebner, Jagan Teki,
Jonas Karlman, Kever Yang, Klaus Goger, Levin Du,
Manivannan Sadhasivam, Marek Behún, Nick Xie,
Paul Kocialkowski, Peter Robinson, Philipp Tomsich,
Quentin Schulz, Raymond Mao, Shantur Rathore, Simon Glass,
Stefan Roese, Suniel Mahesh, Tien Fong Chee, Tom Rini,
Wan Yee Lau, Xiaobo Tian
Hi Chen-Yu
On Wed, 5 Feb 2025 at 07:39, Chen-Yu Tsai <wens@kernel.org> wrote:
>
> From: Chen-Yu Tsai <wens@csie.org>
>
> The IO domain driver controls the I/O voltage for various pins,
> MMC included.
>
> Enable it by default for all supported Rockchip SoCs.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Reviewed-by: Anand Moon <linux.amoon@gmail.com>
Can we enable following config default for all the boards
CONFIG_MMC_DW=y
CONFIG_MMC_DW_ROCKCHIP=y
CONFIG_MMC_SDHCI=y
Thanks
-Anand
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] rockchip: io-domain: Enable by default for all supported SoCs
2025-03-30 13:33 ` Anand Moon
@ 2025-03-31 15:08 ` Chen-Yu Tsai
2025-04-01 3:00 ` Kever Yang
1 sibling, 0 replies; 12+ messages in thread
From: Chen-Yu Tsai @ 2025-03-31 15:08 UTC (permalink / raw)
To: Anand Moon
Cc: u-boot, Akash Gajjar, Alexandre Vicenzi, Alper Nebi Yasak,
Andy Yan, Christopher Obbard, Deepak Das, Dragan Simic,
FUKAUMI Naoki, Heiko Stuebner, Jagan Teki, Jonas Karlman,
Kever Yang, Klaus Goger, Levin Du, Manivannan Sadhasivam,
Marek Behún, Nick Xie, Paul Kocialkowski, Peter Robinson,
Philipp Tomsich, Quentin Schulz, Raymond Mao, Shantur Rathore,
Simon Glass, Stefan Roese, Suniel Mahesh, Tien Fong Chee,
Tom Rini, Wan Yee Lau, Xiaobo Tian
On Sun, Mar 30, 2025 at 9:34 PM Anand Moon <linux.amoon@gmail.com> wrote:
>
> Hi Chen-Yu
>
> On Wed, 5 Feb 2025 at 07:39, Chen-Yu Tsai <wens@kernel.org> wrote:
> >
> > From: Chen-Yu Tsai <wens@csie.org>
> >
> > The IO domain driver controls the I/O voltage for various pins,
> > MMC included.
> >
> > Enable it by default for all supported Rockchip SoCs.
> >
> > Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> Reviewed-by: Anand Moon <linux.amoon@gmail.com>
>
> Can we enable following config default for all the boards
>
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
I can do a separate patch for these.
Would it make sense to enable MMC_DW and MMC_DW_ROCKCHIP for the whole
Rockchip family, and MMC_SDHCI and co. for the SoCs that has SDHCI?
ChenYu
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] rockchip: io-domain: Enable by default for all supported SoCs
2025-03-30 13:33 ` Anand Moon
2025-03-31 15:08 ` Chen-Yu Tsai
@ 2025-04-01 3:00 ` Kever Yang
2025-04-01 3:41 ` Anand Moon
1 sibling, 1 reply; 12+ messages in thread
From: Kever Yang @ 2025-04-01 3:00 UTC (permalink / raw)
To: Anand Moon, Chen-Yu Tsai
Cc: u-boot, Chen-Yu Tsai, Akash Gajjar, Alexandre Vicenzi,
Alper Nebi Yasak, Andy Yan, Christopher Obbard, Deepak Das,
Dragan Simic, FUKAUMI Naoki, Heiko Stuebner, Jagan Teki,
Jonas Karlman, Klaus Goger, Levin Du, Manivannan Sadhasivam,
Marek Behún, Nick Xie, Paul Kocialkowski, Peter Robinson,
Philipp Tomsich, Quentin Schulz, Raymond Mao, Shantur Rathore,
Simon Glass, Stefan Roese, Suniel Mahesh, Tien Fong Chee,
Tom Rini, Wan Yee Lau, Xiaobo Tian
Hi Anand,
On 2025/3/30 21:33, Anand Moon wrote:
> Hi Chen-Yu
>
> On Wed, 5 Feb 2025 at 07:39, Chen-Yu Tsai <wens@kernel.org> wrote:
>> From: Chen-Yu Tsai <wens@csie.org>
>>
>> The IO domain driver controls the I/O voltage for various pins,
>> MMC included.
>>
>> Enable it by default for all supported Rockchip SoCs.
>>
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> Reviewed-by: Anand Moon <linux.amoon@gmail.com>
>
> Can we enable following config default for all the boards
>
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
These two driver, SD card and eMMC, are board specific, not all the
board has enable all these two interface.
Thanks,
- Kever
>
> Thanks
> -Anand
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] rockchip: io-domain: Enable by default for all supported SoCs
2025-04-01 3:00 ` Kever Yang
@ 2025-04-01 3:41 ` Anand Moon
2025-04-01 7:21 ` Anand Moon
0 siblings, 1 reply; 12+ messages in thread
From: Anand Moon @ 2025-04-01 3:41 UTC (permalink / raw)
To: Kever Yang
Cc: Chen-Yu Tsai, u-boot, Chen-Yu Tsai, Akash Gajjar,
Alexandre Vicenzi, Alper Nebi Yasak, Andy Yan, Christopher Obbard,
Deepak Das, Dragan Simic, FUKAUMI Naoki, Heiko Stuebner,
Jagan Teki, Jonas Karlman, Klaus Goger, Levin Du,
Manivannan Sadhasivam, Marek Behún, Nick Xie,
Paul Kocialkowski, Peter Robinson, Philipp Tomsich,
Quentin Schulz, Raymond Mao, Shantur Rathore, Simon Glass,
Stefan Roese, Suniel Mahesh, Tien Fong Chee, Tom Rini,
Wan Yee Lau, Xiaobo Tian
Hi Kever,
On Tue, 1 Apr 2025 at 08:30, Kever Yang <kever.yang@rock-chips.com> wrote:
>
> Hi Anand,
>
> On 2025/3/30 21:33, Anand Moon wrote:
> > Hi Chen-Yu
> >
> > On Wed, 5 Feb 2025 at 07:39, Chen-Yu Tsai <wens@kernel.org> wrote:
> >> From: Chen-Yu Tsai <wens@csie.org>
> >>
> >> The IO domain driver controls the I/O voltage for various pins,
> >> MMC included.
> >>
> >> Enable it by default for all supported Rockchip SoCs.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> > Reviewed-by: Anand Moon <linux.amoon@gmail.com>
> >
> > Can we enable following config default for all the boards
> >
> > CONFIG_MMC_DW=y
> > CONFIG_MMC_DW_ROCKCHIP=y
> > CONFIG_MMC_SDHCI=y
> These two driver, SD card and eMMC, are board specific, not all the
> board has enable all these two interface.
>
Ok,I thought it should reduce the configuration options on all the boards.
> Thanks,
> - Kever
Thanks
-Anand
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] rockchip: io-domain: Enable by default for all supported SoCs
2025-04-01 3:41 ` Anand Moon
@ 2025-04-01 7:21 ` Anand Moon
2025-04-01 7:31 ` Chen-Yu Tsai
0 siblings, 1 reply; 12+ messages in thread
From: Anand Moon @ 2025-04-01 7:21 UTC (permalink / raw)
To: Kever Yang
Cc: Chen-Yu Tsai, u-boot, Chen-Yu Tsai, Akash Gajjar,
Alexandre Vicenzi, Alper Nebi Yasak, Andy Yan, Christopher Obbard,
Deepak Das, Dragan Simic, FUKAUMI Naoki, Heiko Stuebner,
Jagan Teki, Jonas Karlman, Klaus Goger, Levin Du,
Manivannan Sadhasivam, Marek Behún, Nick Xie,
Paul Kocialkowski, Peter Robinson, Philipp Tomsich,
Quentin Schulz, Raymond Mao, Shantur Rathore, Simon Glass,
Stefan Roese, Suniel Mahesh, Tien Fong Chee, Tom Rini,
Wan Yee Lau, Xiaobo Tian
Hi Kever,
On Tue, 1 Apr 2025 at 09:11, Anand Moon <linux.amoon@gmail.com> wrote:
>
> Hi Kever,
>
> On Tue, 1 Apr 2025 at 08:30, Kever Yang <kever.yang@rock-chips.com> wrote:
> >
> > Hi Anand,
> >
> > On 2025/3/30 21:33, Anand Moon wrote:
> > > Hi Chen-Yu
> > >
> > > On Wed, 5 Feb 2025 at 07:39, Chen-Yu Tsai <wens@kernel.org> wrote:
> > >> From: Chen-Yu Tsai <wens@csie.org>
> > >>
> > >> The IO domain driver controls the I/O voltage for various pins,
> > >> MMC included.
> > >>
> > >> Enable it by default for all supported Rockchip SoCs.
> > >>
> > >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> > > Reviewed-by: Anand Moon <linux.amoon@gmail.com>
> > >
> > > Can we enable following config default for all the boards
> > >
> > > CONFIG_MMC_DW=y
> > > CONFIG_MMC_DW_ROCKCHIP=y
> > > CONFIG_MMC_SDHCI=y
> > These two driver, SD card and eMMC, are board specific, not all the
> > board has enable all these two interface.
> >
> Ok,I thought it should reduce the configuration options on all the boards.
But can we implement this for each SoC, such as the RK3399 and RK3588?"
Thanks
-Anand
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] rockchip: io-domain: Enable by default for all supported SoCs
2025-04-01 7:21 ` Anand Moon
@ 2025-04-01 7:31 ` Chen-Yu Tsai
2025-04-06 15:39 ` Kever Yang
0 siblings, 1 reply; 12+ messages in thread
From: Chen-Yu Tsai @ 2025-04-01 7:31 UTC (permalink / raw)
To: Anand Moon, Kever Yang
Cc: u-boot, Akash Gajjar, Alexandre Vicenzi, Alper Nebi Yasak,
Andy Yan, Christopher Obbard, Deepak Das, Dragan Simic,
FUKAUMI Naoki, Heiko Stuebner, Jagan Teki, Jonas Karlman,
Klaus Goger, Levin Du, Manivannan Sadhasivam, Marek Behún,
Nick Xie, Paul Kocialkowski, Peter Robinson, Quentin Schulz,
Raymond Mao, Shantur Rathore, Simon Glass, Stefan Roese,
Suniel Mahesh, Tien Fong Chee, Tom Rini, Wan Yee Lau, Xiaobo Tian
On Tue, Apr 1, 2025 at 3:22 PM Anand Moon <linux.amoon@gmail.com> wrote:
>
> Hi Kever,
>
> On Tue, 1 Apr 2025 at 09:11, Anand Moon <linux.amoon@gmail.com> wrote:
> >
> > Hi Kever,
> >
> > On Tue, 1 Apr 2025 at 08:30, Kever Yang <kever.yang@rock-chips.com> wrote:
> > >
> > > Hi Anand,
> > >
> > > On 2025/3/30 21:33, Anand Moon wrote:
> > > > Hi Chen-Yu
> > > >
> > > > On Wed, 5 Feb 2025 at 07:39, Chen-Yu Tsai <wens@kernel.org> wrote:
> > > >> From: Chen-Yu Tsai <wens@csie.org>
> > > >>
> > > >> The IO domain driver controls the I/O voltage for various pins,
> > > >> MMC included.
> > > >>
> > > >> Enable it by default for all supported Rockchip SoCs.
> > > >>
> > > >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> > > > Reviewed-by: Anand Moon <linux.amoon@gmail.com>
> > > >
> > > > Can we enable following config default for all the boards
> > > >
> > > > CONFIG_MMC_DW=y
> > > > CONFIG_MMC_DW_ROCKCHIP=y
> > > > CONFIG_MMC_SDHCI=y
> > > These two driver, SD card and eMMC, are board specific, not all the
> > > board has enable all these two interface.
> > >
> > Ok,I thought it should reduce the configuration options on all the boards.
> But can we implement this for each SoC, such as the RK3399 and RK3588?"
Of all the defconfigs that have ARCH_ROCKCHIP, only three don't have MMC_DW:
configs/coolpi-cm5-genbook-rk3588_defconfig
configs/evb-rv1108_defconfig
configs/geekbox_defconfig
So maybe we could have the default by y, and negate the option where
it makes sense.
For MMC_SDHCI there would be more defconfigs, but only a couple SoCs
support this controller, and we could narrow it down to those.
ChenYu
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [PATCH] rockchip: io-domain: Enable by default for all supported SoCs
2025-04-01 7:31 ` Chen-Yu Tsai
@ 2025-04-06 15:39 ` Kever Yang
0 siblings, 0 replies; 12+ messages in thread
From: Kever Yang @ 2025-04-06 15:39 UTC (permalink / raw)
To: wens, Anand Moon; +Cc: u-boot, Heiko Stuebner, Quentin Schulz, Tom Rini
Hi Chen-Yu,
On 2025/4/1 15:31, Chen-Yu Tsai wrote:
> On Tue, Apr 1, 2025 at 3:22 PM Anand Moon <linux.amoon@gmail.com> wrote:
>> Hi Kever,
>>
>> On Tue, 1 Apr 2025 at 09:11, Anand Moon <linux.amoon@gmail.com> wrote:
>>> Hi Kever,
>>>
>>> On Tue, 1 Apr 2025 at 08:30, Kever Yang <kever.yang@rock-chips.com> wrote:
>>>> Hi Anand,
>>>>
>>>> On 2025/3/30 21:33, Anand Moon wrote:
>>>>> Hi Chen-Yu
>>>>>
>>>>> On Wed, 5 Feb 2025 at 07:39, Chen-Yu Tsai <wens@kernel.org> wrote:
>>>>>> From: Chen-Yu Tsai <wens@csie.org>
>>>>>>
>>>>>> The IO domain driver controls the I/O voltage for various pins,
>>>>>> MMC included.
>>>>>>
>>>>>> Enable it by default for all supported Rockchip SoCs.
>>>>>>
>>>>>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>>>>> Reviewed-by: Anand Moon <linux.amoon@gmail.com>
>>>>>
>>>>> Can we enable following config default for all the boards
>>>>>
>>>>> CONFIG_MMC_DW=y
>>>>> CONFIG_MMC_DW_ROCKCHIP=y
>>>>> CONFIG_MMC_SDHCI=y
>>>> These two driver, SD card and eMMC, are board specific, not all the
>>>> board has enable all these two interface.
>>>>
>>> Ok,I thought it should reduce the configuration options on all the boards.
>> But can we implement this for each SoC, such as the RK3399 and RK3588?"
> Of all the defconfigs that have ARCH_ROCKCHIP, only three don't have MMC_DW:
>
> configs/coolpi-cm5-genbook-rk3588_defconfig
> configs/evb-rv1108_defconfig
> configs/geekbox_defconfig
>
> So maybe we could have the default by y, and negate the option where
> it makes sense.
Yes, sounds reasonable for DW MMC, both SD and eMMC use this controller
for legacy SoCs.
For new SoCs, the eMMC is using MMC_SDHCI, and maybe more boards does
not enable it.
Thanks,
- Kever
>
> For MMC_SDHCI there would be more defconfigs, but only a couple SoCs
> support this controller, and we could narrow it down to those.
>
>
> ChenYu
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] rockchip: io-domain: Enable by default for all supported SoCs
2025-02-04 17:23 [PATCH] rockchip: io-domain: Enable by default for all supported SoCs Chen-Yu Tsai
` (3 preceding siblings ...)
2025-03-30 13:33 ` Anand Moon
@ 2025-05-06 8:06 ` Kever Yang
4 siblings, 0 replies; 12+ messages in thread
From: Kever Yang @ 2025-05-06 8:06 UTC (permalink / raw)
To: Chen-Yu Tsai, u-boot
Cc: Chen-Yu Tsai, Akash Gajjar, Alexandre Vicenzi, Alper Nebi Yasak,
Andy Yan, Christopher Obbard, Deepak Das, Dragan Simic,
FUKAUMI Naoki, Heiko Stuebner, Jagan Teki, Jonas Karlman,
Klaus Goger, Levin Du, Manivannan Sadhasivam, Marek Behún,
Nick Xie, Paul Kocialkowski, Peter Robinson, Philipp Tomsich,
Quentin Schulz, Raymond Mao, Shantur Rathore, Simon Glass,
Stefan Roese, Suniel Mahesh, Tien Fong Chee, Tom Rini,
Wan Yee Lau, Xiaobo Tian
On 2025/2/5 01:23, Chen-Yu Tsai wrote:
> From: Chen-Yu Tsai <wens@csie.org>
>
> The IO domain driver controls the I/O voltage for various pins,
> MMC included.
>
> Enable it by default for all supported Rockchip SoCs.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
Thanks,
- Kever
> ---
>
> configs/chromebook_bob_defconfig | 1 -
> configs/chromebook_kevin_defconfig | 1 -
> configs/eaidk-610-rk3399_defconfig | 1 -
> configs/ficus-rk3399_defconfig | 1 -
> configs/firefly-rk3399_defconfig | 1 -
> configs/khadas-edge-captain-rk3399_defconfig | 1 -
> configs/khadas-edge-rk3399_defconfig | 1 -
> configs/khadas-edge-v-rk3399_defconfig | 1 -
> configs/leez-rk3399_defconfig | 1 -
> configs/nanopc-t4-rk3399_defconfig | 1 -
> configs/nanopi-m4-2gb-rk3399_defconfig | 1 -
> configs/nanopi-m4-rk3399_defconfig | 1 -
> configs/nanopi-m4b-rk3399_defconfig | 1 -
> configs/nanopi-neo4-rk3399_defconfig | 1 -
> configs/nanopi-r4s-rk3399_defconfig | 1 -
> configs/orangepi-rk3399_defconfig | 1 -
> configs/pinebook-pro-rk3399_defconfig | 1 -
> configs/pinephone-pro-rk3399_defconfig | 1 -
> configs/puma-rk3399_defconfig | 1 -
> configs/ringneck-px30_defconfig | 1 -
> configs/roc-pc-mezzanine-rk3399_defconfig | 1 -
> configs/roc-pc-rk3399_defconfig | 1 -
> configs/rock-4c-plus-rk3399_defconfig | 1 -
> configs/rock-4se-rk3399_defconfig | 1 -
> configs/rock-pi-4-rk3399_defconfig | 1 -
> configs/rock-pi-4c-rk3399_defconfig | 1 -
> configs/rock-pi-n10-rk3399pro_defconfig | 1 -
> configs/rock-pi-s-rk3308_defconfig | 1 -
> configs/rock-s0-rk3308_defconfig | 1 -
> configs/rock960-rk3399_defconfig | 1 -
> configs/rockpro64-rk3399_defconfig | 1 -
> drivers/misc/Kconfig | 6 +++++-
> 32 files changed, 5 insertions(+), 32 deletions(-)
>
> diff --git a/configs/chromebook_bob_defconfig b/configs/chromebook_bob_defconfig
> index 1b018ef4d7c8..7b45095fc041 100644
> --- a/configs/chromebook_bob_defconfig
> +++ b/configs/chromebook_bob_defconfig
> @@ -57,7 +57,6 @@ CONFIG_I2C_CROS_EC_TUNNEL=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_I2C_MUX=y
> CONFIG_CROS_EC_KEYB=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_CROS_EC=y
> CONFIG_CROS_EC_SPI=y
> CONFIG_PWRSEQ=y
> diff --git a/configs/chromebook_kevin_defconfig b/configs/chromebook_kevin_defconfig
> index 1ee0c0e6c9d8..cecd89cded45 100644
> --- a/configs/chromebook_kevin_defconfig
> +++ b/configs/chromebook_kevin_defconfig
> @@ -58,7 +58,6 @@ CONFIG_I2C_CROS_EC_TUNNEL=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_I2C_MUX=y
> CONFIG_CROS_EC_KEYB=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_CROS_EC=y
> CONFIG_CROS_EC_SPI=y
> CONFIG_PWRSEQ=y
> diff --git a/configs/eaidk-610-rk3399_defconfig b/configs/eaidk-610-rk3399_defconfig
> index 8f9a76157f16..45a2d9016830 100644
> --- a/configs/eaidk-610-rk3399_defconfig
> +++ b/configs/eaidk-610-rk3399_defconfig
> @@ -31,7 +31,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/ficus-rk3399_defconfig b/configs/ficus-rk3399_defconfig
> index b32ca726b6cf..3a72156d3894 100644
> --- a/configs/ficus-rk3399_defconfig
> +++ b/configs/ficus-rk3399_defconfig
> @@ -37,7 +37,6 @@ CONFIG_SCSI_AHCI=y
> CONFIG_AHCI_PCI=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/firefly-rk3399_defconfig b/configs/firefly-rk3399_defconfig
> index 3871627318b6..be8cde094466 100644
> --- a/configs/firefly-rk3399_defconfig
> +++ b/configs/firefly-rk3399_defconfig
> @@ -34,7 +34,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/khadas-edge-captain-rk3399_defconfig b/configs/khadas-edge-captain-rk3399_defconfig
> index 89611a0535ed..ce425eb9b20c 100644
> --- a/configs/khadas-edge-captain-rk3399_defconfig
> +++ b/configs/khadas-edge-captain-rk3399_defconfig
> @@ -45,7 +45,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> # CONFIG_USB_FUNCTION_FASTBOOT is not set
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/khadas-edge-rk3399_defconfig b/configs/khadas-edge-rk3399_defconfig
> index 3816f4327a61..10a20d749ba5 100644
> --- a/configs/khadas-edge-rk3399_defconfig
> +++ b/configs/khadas-edge-rk3399_defconfig
> @@ -43,7 +43,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> # CONFIG_USB_FUNCTION_FASTBOOT is not set
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/khadas-edge-v-rk3399_defconfig b/configs/khadas-edge-v-rk3399_defconfig
> index 35e209425729..d3345c12fe25 100644
> --- a/configs/khadas-edge-v-rk3399_defconfig
> +++ b/configs/khadas-edge-v-rk3399_defconfig
> @@ -45,7 +45,6 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> # CONFIG_USB_FUNCTION_FASTBOOT is not set
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/leez-rk3399_defconfig b/configs/leez-rk3399_defconfig
> index 57b097377fab..f12f39857e00 100644
> --- a/configs/leez-rk3399_defconfig
> +++ b/configs/leez-rk3399_defconfig
> @@ -31,7 +31,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/nanopc-t4-rk3399_defconfig b/configs/nanopc-t4-rk3399_defconfig
> index 26c12c510785..40844753ccd8 100644
> --- a/configs/nanopc-t4-rk3399_defconfig
> +++ b/configs/nanopc-t4-rk3399_defconfig
> @@ -34,7 +34,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/nanopi-m4-2gb-rk3399_defconfig b/configs/nanopi-m4-2gb-rk3399_defconfig
> index d24b7bc6d174..31b0e83cdea6 100644
> --- a/configs/nanopi-m4-2gb-rk3399_defconfig
> +++ b/configs/nanopi-m4-2gb-rk3399_defconfig
> @@ -38,7 +38,6 @@ CONFIG_SCSI_AHCI=y
> CONFIG_AHCI_PCI=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/nanopi-m4-rk3399_defconfig b/configs/nanopi-m4-rk3399_defconfig
> index da3e44af8418..1a9b770c1692 100644
> --- a/configs/nanopi-m4-rk3399_defconfig
> +++ b/configs/nanopi-m4-rk3399_defconfig
> @@ -37,7 +37,6 @@ CONFIG_SCSI_AHCI=y
> CONFIG_AHCI_PCI=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/nanopi-m4b-rk3399_defconfig b/configs/nanopi-m4b-rk3399_defconfig
> index 247056ab58b4..d3a8b5bb6d1f 100644
> --- a/configs/nanopi-m4b-rk3399_defconfig
> +++ b/configs/nanopi-m4b-rk3399_defconfig
> @@ -37,7 +37,6 @@ CONFIG_SCSI_AHCI=y
> CONFIG_AHCI_PCI=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/nanopi-neo4-rk3399_defconfig b/configs/nanopi-neo4-rk3399_defconfig
> index 305877d20796..1e422befdf8e 100644
> --- a/configs/nanopi-neo4-rk3399_defconfig
> +++ b/configs/nanopi-neo4-rk3399_defconfig
> @@ -32,7 +32,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/nanopi-r4s-rk3399_defconfig b/configs/nanopi-r4s-rk3399_defconfig
> index a6dafe3d9eb5..04642bca7cbd 100644
> --- a/configs/nanopi-r4s-rk3399_defconfig
> +++ b/configs/nanopi-r4s-rk3399_defconfig
> @@ -32,7 +32,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/orangepi-rk3399_defconfig b/configs/orangepi-rk3399_defconfig
> index fdf3d6989393..d5091ee8a0c5 100644
> --- a/configs/orangepi-rk3399_defconfig
> +++ b/configs/orangepi-rk3399_defconfig
> @@ -32,7 +32,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/pinebook-pro-rk3399_defconfig b/configs/pinebook-pro-rk3399_defconfig
> index dfa927ccb170..676d1e718945 100644
> --- a/configs/pinebook-pro-rk3399_defconfig
> +++ b/configs/pinebook-pro-rk3399_defconfig
> @@ -51,7 +51,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_IO_VOLTAGE=y
> CONFIG_SPL_MMC_IO_VOLTAGE=y
> CONFIG_MMC_UHS_SUPPORT=y
> diff --git a/configs/pinephone-pro-rk3399_defconfig b/configs/pinephone-pro-rk3399_defconfig
> index 5e16749ba7d4..85833c654b8f 100644
> --- a/configs/pinephone-pro-rk3399_defconfig
> +++ b/configs/pinephone-pro-rk3399_defconfig
> @@ -47,7 +47,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/puma-rk3399_defconfig b/configs/puma-rk3399_defconfig
> index 7a180b141303..95ed6eea953d 100644
> --- a/configs/puma-rk3399_defconfig
> +++ b/configs/puma-rk3399_defconfig
> @@ -64,7 +64,6 @@ CONFIG_GPIO_HOG=y
> CONFIG_SPL_GPIO_HOG=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/ringneck-px30_defconfig b/configs/ringneck-px30_defconfig
> index 324581b4082e..93caaf68e2d7 100644
> --- a/configs/ringneck-px30_defconfig
> +++ b/configs/ringneck-px30_defconfig
> @@ -81,7 +81,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_MISC=y
> CONFIG_ROCKCHIP_OTP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_SUPPORT_EMMC_RPMB=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> diff --git a/configs/roc-pc-mezzanine-rk3399_defconfig b/configs/roc-pc-mezzanine-rk3399_defconfig
> index 3ab5fd69c62a..9c063ce82d34 100644
> --- a/configs/roc-pc-mezzanine-rk3399_defconfig
> +++ b/configs/roc-pc-mezzanine-rk3399_defconfig
> @@ -45,7 +45,6 @@ CONFIG_ENV_IS_IN_SPI_FLASH=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/roc-pc-rk3399_defconfig b/configs/roc-pc-rk3399_defconfig
> index 0ef867487787..68c4267d2426 100644
> --- a/configs/roc-pc-rk3399_defconfig
> +++ b/configs/roc-pc-rk3399_defconfig
> @@ -43,7 +43,6 @@ CONFIG_ENV_IS_IN_SPI_FLASH=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/rock-4c-plus-rk3399_defconfig b/configs/rock-4c-plus-rk3399_defconfig
> index 0c73a212ea1f..2f1ea314302f 100644
> --- a/configs/rock-4c-plus-rk3399_defconfig
> +++ b/configs/rock-4c-plus-rk3399_defconfig
> @@ -49,7 +49,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/rock-4se-rk3399_defconfig b/configs/rock-4se-rk3399_defconfig
> index 3ae19692155a..7387130ecc18 100644
> --- a/configs/rock-4se-rk3399_defconfig
> +++ b/configs/rock-4se-rk3399_defconfig
> @@ -53,7 +53,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/rock-pi-4-rk3399_defconfig b/configs/rock-pi-4-rk3399_defconfig
> index f3a5c2c45f35..97a7db3730df 100644
> --- a/configs/rock-pi-4-rk3399_defconfig
> +++ b/configs/rock-pi-4-rk3399_defconfig
> @@ -54,7 +54,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/rock-pi-4c-rk3399_defconfig b/configs/rock-pi-4c-rk3399_defconfig
> index 9bda50c8c77f..7da7ee4bce16 100644
> --- a/configs/rock-pi-4c-rk3399_defconfig
> +++ b/configs/rock-pi-4c-rk3399_defconfig
> @@ -54,7 +54,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/rock-pi-n10-rk3399pro_defconfig b/configs/rock-pi-n10-rk3399pro_defconfig
> index a9c6d8a907a9..a38670d95d0e 100644
> --- a/configs/rock-pi-n10-rk3399pro_defconfig
> +++ b/configs/rock-pi-n10-rk3399pro_defconfig
> @@ -35,7 +35,6 @@ CONFIG_ENV_IS_IN_MMC=y
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/rock-pi-s-rk3308_defconfig b/configs/rock-pi-s-rk3308_defconfig
> index 4b08af309b1b..907b999b274d 100644
> --- a/configs/rock-pi-s-rk3308_defconfig
> +++ b/configs/rock-pi-s-rk3308_defconfig
> @@ -40,7 +40,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_SUPPORT_EMMC_RPMB=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> diff --git a/configs/rock-s0-rk3308_defconfig b/configs/rock-s0-rk3308_defconfig
> index 0a46e7bb1871..a762734231a0 100644
> --- a/configs/rock-s0-rk3308_defconfig
> +++ b/configs/rock-s0-rk3308_defconfig
> @@ -40,7 +40,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_SUPPORT_EMMC_RPMB=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> diff --git a/configs/rock960-rk3399_defconfig b/configs/rock960-rk3399_defconfig
> index aebfa73459ca..607aa61ba172 100644
> --- a/configs/rock960-rk3399_defconfig
> +++ b/configs/rock960-rk3399_defconfig
> @@ -41,7 +41,6 @@ CONFIG_SYS_MMC_ENV_DEV=1
> # CONFIG_USB_FUNCTION_FASTBOOT is not set
> CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig
> index 75322073285c..1b887cd9f3ea 100644
> --- a/configs/rockpro64-rk3399_defconfig
> +++ b/configs/rockpro64-rk3399_defconfig
> @@ -49,7 +49,6 @@ CONFIG_ROCKCHIP_GPIO=y
> CONFIG_SYS_I2C_ROCKCHIP=y
> CONFIG_LED=y
> CONFIG_LED_GPIO=y
> -CONFIG_ROCKCHIP_IODOMAIN=y
> CONFIG_MMC_DW=y
> CONFIG_MMC_DW_ROCKCHIP=y
> CONFIG_MMC_SDHCI=y
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index da84b35e8043..9f8bef5068c8 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -104,7 +104,11 @@ config ROCKCHIP_OTP
> config ROCKCHIP_IODOMAIN
> bool "Rockchip IO-domain driver support"
> depends on DM_REGULATOR && ARCH_ROCKCHIP
> - default y if ROCKCHIP_RK3328 || ROCKCHIP_RK3568
> + default y if ROCKCHIP_PX30
> + default y if ROCKCHIP_RK3308
> + default y if ROCKCHIP_RK3328
> + default y if ROCKCHIP_RK3399
> + default y if ROCKCHIP_RK3568
> help
> Enable support for IO-domains in Rockchip SoCs. It is necessary
> for the IO-domain setting of the SoC to match the voltage supplied
^ permalink raw reply [flat|nested] 12+ messages in thread