From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Matti Vaittinen <mazziesaccount@gmail.com>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Danilo Krummrich <dakr@kernel.org>
Subject: Re: [PATCH v1 1/1] regmap: irq: Use one way of setting all bits in the register
Date: Thu, 6 Feb 2025 21:00:09 +0200 [thread overview]
Message-ID: <Z6UGue-OUujUKYi6@smile.fi.intel.com> (raw)
In-Reply-To: <1a60ef2d-365b-49ea-99b1-b83faee910c2@sirena.org.uk>
On Thu, Feb 06, 2025 at 04:51:35PM +0000, Mark Brown wrote:
> On Thu, Feb 06, 2025 at 06:29:33PM +0200, Andy Shevchenko wrote:
> > Currently there are two ways of how we represent all bits set, i.e.
> > UINT_MAX and GENMASK(31, 0). Use the latter as the single way of
> > doing that, which is crystal clear on how many bits we are talking
> > about.
>
> I think I'd rather go to UINT_MAX since it's more obviously correct if
> we see platforms with int that isn't 32 bits.
Okay!
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2025-02-06 19:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 16:29 [PATCH v1 1/1] regmap: irq: Use one way of setting all bits in the register Andy Shevchenko
2025-02-06 16:51 ` Mark Brown
2025-02-06 19:00 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6UGue-OUujUKYi6@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=dakr@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.