[PATCH v1 1/1] regmap: irq: Use one way of setting all bits in the register

[PATCH v1 1/1] regmap: irq: Use one way of setting all bits in the register

[Andy Shevchenko]

Currently there are two ways of how we represent all bits set, i.e.
UINT_MAX and GENMASK(31, 0). Use the latter as the single way of
doing that, which is crystal clear on how many bits we are talking
about.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/base/regmap/regmap-irq.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
index 0bcd81389a29..c5fda76cd27e 100644
--- a/drivers/base/regmap/regmap-irq.c
+++ b/drivers/base/regmap/regmap-irq.c
@@ -166,7 +166,7 @@ static void regmap_irq_sync_unlock(struct irq_data *data)
 				ret = regmap_write(map, reg, d->mask_buf[i]);
 			if (d->chip->clear_ack) {
 				if (d->chip->ack_invert && !ret)
-					ret = regmap_write(map, reg, UINT_MAX);
+					ret = regmap_write(map, reg, GENMASK(31, 0));
 				else if (!ret)
 					ret = regmap_write(map, reg, 0);
 			}
@@ -480,7 +480,7 @@ static irqreturn_t regmap_irq_thread(int irq, void *d)
 						data->status_buf[i]);
 			if (chip->clear_ack) {
 				if (chip->ack_invert && !ret)
-					ret = regmap_write(map, reg, UINT_MAX);
+					ret = regmap_write(map, reg, GENMASK(31, 0));
 				else if (!ret)
 					ret = regmap_write(map, reg, 0);
 			}
@@ -847,7 +847,7 @@ int regmap_add_irq_chip_fwnode(struct fwnode_handle *fwnode,
 					d->status_buf[i] & d->mask_buf[i]);
 			if (chip->clear_ack) {
 				if (chip->ack_invert && !ret)
-					ret = regmap_write(map, reg, UINT_MAX);
+					ret = regmap_write(map, reg, GENMASK(31, 0));
 				else if (!ret)
 					ret = regmap_write(map, reg, 0);
 			}
-- 
2.43.0.rc1.1336.g36b5255a03ac

Re: [PATCH v1 1/1] regmap: irq: Use one way of setting all bits in the register

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 398 bytes --]

On Thu, Feb 06, 2025 at 06:29:33PM +0200, Andy Shevchenko wrote:
> Currently there are two ways of how we represent all bits set, i.e.
> UINT_MAX and GENMASK(31, 0). Use the latter as the single way of
> doing that, which is crystal clear on how many bits we are talking
> about.

I think I'd rather go to UINT_MAX since it's more obviously correct if
we see platforms with int that isn't 32 bits.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH v1 1/1] regmap: irq: Use one way of setting all bits in the register

[Andy Shevchenko]

On Thu, Feb 06, 2025 at 04:51:35PM +0000, Mark Brown wrote:
> On Thu, Feb 06, 2025 at 06:29:33PM +0200, Andy Shevchenko wrote:
> > Currently there are two ways of how we represent all bits set, i.e.
> > UINT_MAX and GENMASK(31, 0). Use the latter as the single way of
> > doing that, which is crystal clear on how many bits we are talking
> > about.
> 
> I think I'd rather go to UINT_MAX since it's more obviously correct if
> we see platforms with int that isn't 32 bits.

Okay!

-- 
With Best Regards,
Andy Shevchenko