From: Joe Damato <jdamato@fastly.com>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
andrew+netdev@lunn.ch, edumazet@google.com, kuba@kernel.org,
horms@kernel.org, pabeni@redhat.com, davem@davemloft.net,
michael.chan@broadcom.com, tariqt@nvidia.com,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
shayd@nvidia.com, akpm@linux-foundation.org, shayagr@amazon.com,
kalesh-anakkur.purayil@broadcom.com
Subject: Re: [Intel-wired-lan] [PATCH net-next v7 0/5] net: napi: add CPU affinity to napi->config
Date: Thu, 6 Feb 2025 16:24:26 -0800 [thread overview]
Message-ID: <Z6VSumnSnqa3wHfu@LQ3V64L9R2> (raw)
In-Reply-To: <20250204220622.156061-1-ahmed.zaki@intel.com>
On Tue, Feb 04, 2025 at 03:06:17PM -0700, Ahmed Zaki wrote:
> Drivers usually need to re-apply the user-set IRQ affinity to their IRQs
> after reset. However, since there can be only one IRQ affinity notifier
> for each IRQ, registering IRQ notifiers conflicts with the ARFS rmap
> management in the core (which also registers separate IRQ affinity
> notifiers).
>
> Move the IRQ affinity management to the napi struct. This way we can have
> a unified IRQ notifier to re-apply the user-set affinity and also manage
> the ARFS rmaps. The first patch moves the ARFS rmap management to CORE.
> The second patch adds the IRQ affinity mask to napi_config and re-applies
> the mask after reset. Patches 3-5 use the new API for bnxt, ice and idpf
> drivers.
If there's another version maybe adding this to netdevsim might be
good?
Was just thinking that if one day in the distant future netdev-genl
was extended to expose the per NAPI affinity mask, a test could
probably be written.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Damato <jdamato@fastly.com>
To: Ahmed Zaki <ahmed.zaki@intel.com>
Cc: netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
andrew+netdev@lunn.ch, edumazet@google.com, kuba@kernel.org,
horms@kernel.org, pabeni@redhat.com, davem@davemloft.net,
michael.chan@broadcom.com, tariqt@nvidia.com,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
shayd@nvidia.com, akpm@linux-foundation.org, shayagr@amazon.com,
kalesh-anakkur.purayil@broadcom.com
Subject: Re: [PATCH net-next v7 0/5] net: napi: add CPU affinity to napi->config
Date: Thu, 6 Feb 2025 16:24:26 -0800 [thread overview]
Message-ID: <Z6VSumnSnqa3wHfu@LQ3V64L9R2> (raw)
In-Reply-To: <20250204220622.156061-1-ahmed.zaki@intel.com>
On Tue, Feb 04, 2025 at 03:06:17PM -0700, Ahmed Zaki wrote:
> Drivers usually need to re-apply the user-set IRQ affinity to their IRQs
> after reset. However, since there can be only one IRQ affinity notifier
> for each IRQ, registering IRQ notifiers conflicts with the ARFS rmap
> management in the core (which also registers separate IRQ affinity
> notifiers).
>
> Move the IRQ affinity management to the napi struct. This way we can have
> a unified IRQ notifier to re-apply the user-set affinity and also manage
> the ARFS rmaps. The first patch moves the ARFS rmap management to CORE.
> The second patch adds the IRQ affinity mask to napi_config and re-applies
> the mask after reset. Patches 3-5 use the new API for bnxt, ice and idpf
> drivers.
If there's another version maybe adding this to netdevsim might be
good?
Was just thinking that if one day in the distant future netdev-genl
was extended to expose the per NAPI affinity mask, a test could
probably be written.
next prev parent reply other threads:[~2025-02-07 0:24 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 22:06 [Intel-wired-lan] [PATCH net-next v7 0/5] net: napi: add CPU affinity to napi->config Ahmed Zaki
2025-02-04 22:06 ` Ahmed Zaki
2025-02-04 22:06 ` [Intel-wired-lan] [PATCH net-next v7 1/5] net: move ARFS rmap management to core Ahmed Zaki
2025-02-04 22:06 ` Ahmed Zaki
2025-02-07 2:29 ` [Intel-wired-lan] " Jakub Kicinski
2025-02-07 2:29 ` Jakub Kicinski
2025-02-10 15:04 ` [Intel-wired-lan] " Ahmed Zaki
2025-02-10 15:04 ` Ahmed Zaki
2025-02-11 0:13 ` [Intel-wired-lan] " Jakub Kicinski
2025-02-11 0:13 ` Jakub Kicinski
2025-02-04 22:06 ` [Intel-wired-lan] [PATCH net-next v7 2/5] net: napi: add CPU affinity to napi_config Ahmed Zaki
2025-02-04 22:06 ` Ahmed Zaki
2025-02-04 22:43 ` [Intel-wired-lan] " Joe Damato
2025-02-04 22:43 ` Joe Damato
2025-02-05 15:20 ` [Intel-wired-lan] " Ahmed Zaki
2025-02-05 15:20 ` Ahmed Zaki
2025-02-07 2:33 ` [Intel-wired-lan] " Jakub Kicinski
2025-02-07 2:33 ` Jakub Kicinski
2025-02-07 2:37 ` [Intel-wired-lan] " Jakub Kicinski
2025-02-07 2:37 ` Jakub Kicinski
2025-02-04 22:06 ` [Intel-wired-lan] [PATCH net-next v7 3/5] bnxt: use napi's irq affinity Ahmed Zaki
2025-02-04 22:06 ` Ahmed Zaki
2025-02-04 22:06 ` [Intel-wired-lan] [PATCH net-next v7 4/5] ice: " Ahmed Zaki
2025-02-04 22:06 ` Ahmed Zaki
2025-02-04 22:06 ` [Intel-wired-lan] [PATCH net-next v7 5/5] idpf: " Ahmed Zaki
2025-02-04 22:06 ` Ahmed Zaki
2025-02-07 0:24 ` Joe Damato [this message]
2025-02-07 0:24 ` [PATCH net-next v7 0/5] net: napi: add CPU affinity to napi->config Joe Damato
2025-02-07 18:47 ` [Intel-wired-lan] " Jakub Kicinski
2025-02-07 18:47 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6VSumnSnqa3wHfu@LQ3V64L9R2 \
--to=jdamato@fastly.com \
--cc=ahmed.zaki@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=shayagr@amazon.com \
--cc=shayd@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.