Re: [PATCH 01/14] dt-bindings: soc: Document Renesas RZ/T2H (R9A09G077) SoC

[Thierry Bultel <thierry.bultel.yh@bp.renesas.com>]

On Mon, Feb 10, 2025 at 01:52:44PM +0100, Geert Uytterhoeven wrote:
> Hi Thierry,
> 

Hi Geert,

> On Wed, 29 Jan 2025 at 17:51, Thierry Bultel
> <thierry.bultel.yh@bp.renesas.com> wrote:
> > Add RZ/T2H (R9A09G077) and variants in documentation.
> >
> > Signed-off-by: Thierry Bultel <thierry.bultel.yh@bp.renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > +++ b/Documentation/devicetree/bindings/soc/renesas/renesas.yaml
> > @@ -535,6 +535,14 @@ properties:
> >                - renesas,r9a09g057h44 # RZ/V2HP with Mali-G31 + Mali-C55 support
> >            - const: renesas,r9a09g057
> >
> > +      - description: RZ/T2H (R9A09G077)
> > +        items:
> > +          - enum:
> > +            - renesas,r9a09g077 # RZ/T2H with Quad Cortex-A55 + Dual Cortex-R52
> > +            - renesas,r9a09g077m04 # RZ/T2H with Single Cortex-A55 + Dual Cortex-R52 - no security
> > +            - renesas,r9a09g077m24 # RZ/T2H with Dual Cortex-A55 + Dual Cortex-R52 - no security
> > +            - renesas,r9a09g077m44 # RZ/T2H with Quad Cortex-A55 + Dual Cortex-R52 - no security
> 
> While the part numbers match, the grouping (variant-specific + fallback).
> do not.
> 

Do you mean that this would be better ?

          - enum:
              - renesas,r9a09g077m04 # RZ/T2H with Single Cortex-A55 + Dual Cortex-R52 - no security
              - renesas,r9a09g077m24 # RZ/T2H with Dual Cortex-A55 + Dual Cortex-R52 - no security
              - renesas,r9a09g077m44 # RZ/T2H with Quad Cortex-A55 + Dual Cortex-R52 - no security
          - const: renesas,r9a09g077


> > +
> >  additionalProperties: true
> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> -- 
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds