From: Patrick Steinhardt <ps@pks.im>
To: Emily M Klassen <forivall@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] revision: fix missing null for freed memory
Date: Tue, 11 Feb 2025 08:55:54 +0100 [thread overview]
Message-ID: <Z6sCeYmljrqWRFnS@pks.im> (raw)
In-Reply-To: <20250208061702.88469-1-forivall@gmail.com>
On Fri, Feb 07, 2025 at 10:17:02PM -0800, Emily M Klassen wrote:
> "git log --graph --no-graph" missed cleaning up the output_prefix and
> output_prefix_data pointers. This resulted in a segfault when using "--patch",
> "--name-status" or "--name-only", as the output_prefix_data continued to be in
> use after free()
>
> Signed-off-by: Emily M Klassen <forivall@gmail.com>
> ---
> I previously reported this a few hours ago, and ended up digging in and figuring
> it out. I'll make sure to bottom reply in the follow ups to this patch.
Do we know when this bug was introduced? Is it a recent regression or a
long-standing issue? Might be nice to point out in the commit message if
we do know.
Patrick
next prev parent reply other threads:[~2025-02-11 7:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-08 6:17 [PATCH] revision: fix missing null for freed memory Emily M Klassen
2025-02-08 21:53 ` Junio C Hamano
2025-02-10 16:02 ` Junio C Hamano
2025-02-10 20:56 ` Emily Klassen
2025-02-13 0:42 ` Junio C Hamano
2025-02-11 7:55 ` Patrick Steinhardt [this message]
2025-02-11 19:31 ` D. Ben Knoble
2025-02-11 20:22 ` D. Ben Knoble
2025-02-11 21:29 ` Jeff King
2025-02-11 23:09 ` Junio C Hamano
2025-02-12 5:30 ` Patrick Steinhardt
2025-02-13 21:07 ` Ben Knoble
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z6sCeYmljrqWRFnS@pks.im \
--to=ps@pks.im \
--cc=forivall@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.