All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "D. Ben Knoble" <ben.knoble@gmail.com>,
	 Patrick Steinhardt <ps@pks.im>,
	Emily M Klassen <forivall@gmail.com>,
	 git@vger.kernel.org
Subject: Re: [PATCH] revision: fix missing null for freed memory
Date: Tue, 11 Feb 2025 15:09:58 -0800	[thread overview]
Message-ID: <xmqqmsesw01l.fsf@gitster.g> (raw)
In-Reply-To: <20250211212909.GA3113114@coredump.intra.peff.net> (Jeff King's message of "Tue, 11 Feb 2025 16:29:09 -0500")

Jeff King <peff@peff.net> writes:

> Doing that shows that v2.37.0 is actually bad. And bisecting shows that
> it has been broken since 087c745833 (log: add a --no-graph option,
> 2022-02-11), which is not too surprising.

Yeah, broken from its beginning is usually how these kinds of bugs
turn out to be.

> I've also run into non-determinism when bisecting like this, because my
> test command depends on the value of HEAD. The best solution here is to
> just feed a stable tip to git-log. I bisected on:
>
>   git log --graph --no-graph --patch origin >/dev/null
>
> (I didn't need "-2" because good commits failed with "unrecognized
> argument" and bad ones were killed by ASan immediately ;) ).

Thanks for sharing a good tip.

  reply	other threads:[~2025-02-11 23:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-08  6:17 [PATCH] revision: fix missing null for freed memory Emily M Klassen
2025-02-08 21:53 ` Junio C Hamano
2025-02-10 16:02 ` Junio C Hamano
2025-02-10 20:56   ` Emily Klassen
2025-02-13  0:42     ` Junio C Hamano
2025-02-11  7:55 ` Patrick Steinhardt
2025-02-11 19:31   ` D. Ben Knoble
2025-02-11 20:22     ` D. Ben Knoble
2025-02-11 21:29       ` Jeff King
2025-02-11 23:09         ` Junio C Hamano [this message]
2025-02-12  5:30         ` Patrick Steinhardt
2025-02-13 21:07         ` Ben Knoble

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmsesw01l.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ben.knoble@gmail.com \
    --cc=forivall@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.