[meta-arm][PATCH 1/1] optee-client: disable build on qemux86-64

[meta-arm][PATCH 1/1] optee-client: disable build on qemux86-64

[haixiao.yan.cn]

From: Haixiao Yan <haixiao.yan.cn@windriver.com>

optee-client will be built on qemux86-64, there is no OP-TEE supplicant
device on this platform.

Signed-off-by: Haixiao Yan <haixiao.yan.cn@windriver.com>
---
 meta-arm/recipes-security/optee/optee-client.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta-arm/recipes-security/optee/optee-client.inc b/meta-arm/recipes-security/optee/optee-client.inc
index f387c80574b0..aafb1efcf726 100644
--- a/meta-arm/recipes-security/optee/optee-client.inc
+++ b/meta-arm/recipes-security/optee/optee-client.inc
@@ -6,6 +6,7 @@ LICENSE = "BSD-2-Clause"
 LIC_FILES_CHKSUM = "file://LICENSE;md5=69663ab153298557a59c67a60a743e5b"
 
 inherit systemd update-rc.d cmake useradd
+require optee.inc
 
 SRC_URI = " \
     git://github.com/OP-TEE/optee_client.git;branch=master;protocol=https \
-- 
2.34.1

Re: [meta-arm][PATCH 1/1] optee-client: disable build on qemux86-64

[Jon Mason]

On Thu, Feb 20, 2025 at 8:34 PM Yan, Haixiao (CN) via
lists.yoctoproject.org
<Haixiao.Yan.CN=windriver.com@lists.yoctoproject.org> wrote:
>
> From: Haixiao Yan <haixiao.yan.cn@windriver.com>
>
> optee-client will be built on qemux86-64, there is no OP-TEE supplicant
> device on this platform.

I don't think I understand what you mean.  More verbosity in the
commit message might help in the future.
I was able to add optee-client to qemux86-64 and it compiled without issue.

Either way, this patch breaks corstone1000 and fvp-base (with
fvp-base-ts).  You can see it in
https://gitlab.com/jonmason00/meta-arm/-/jobs/9203534679
https://gitlab.com/jonmason00/meta-arm/-/jobs/9203534694

Thanks,
Jon

> Signed-off-by: Haixiao Yan <haixiao.yan.cn@windriver.com>
> ---
>  meta-arm/recipes-security/optee/optee-client.inc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta-arm/recipes-security/optee/optee-client.inc b/meta-arm/recipes-security/optee/optee-client.inc
> index f387c80574b0..aafb1efcf726 100644
> --- a/meta-arm/recipes-security/optee/optee-client.inc
> +++ b/meta-arm/recipes-security/optee/optee-client.inc
> @@ -6,6 +6,7 @@ LICENSE = "BSD-2-Clause"
>  LIC_FILES_CHKSUM = "file://LICENSE;md5=69663ab153298557a59c67a60a743e5b"
>
>  inherit systemd update-rc.d cmake useradd
> +require optee.inc
>
>  SRC_URI = " \
>      git://github.com/OP-TEE/optee_client.git;branch=master;protocol=https \
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#6376): https://lists.yoctoproject.org/g/meta-arm/message/6376
> Mute This Topic: https://lists.yoctoproject.org/mt/111301214/3616920
> Group Owner: meta-arm+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [jdmason@kudzu.us]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [meta-arm][PATCH 1/1] optee-client: disable build on qemux86-64

[Yan, Haixiao (CN)]

My local branch is mickledore. tee-supplicant.service start failed on 
qemux86-64.

https://git.yoctoproject.org/meta-arm/commit/meta-arm/recipes-security/optee/optee-client.inc?id=1bff41eee67d6dafc7c58b0c88923a3c6f7a2a7c 


this commit can resolve my issue.

My question is could we add the COMPATIBLE_MACHINE for optee-client?  So 
for qemux86-64, if there is no OP-TEE supplicant device, optee-client build

can skip.


root@qemux86-64:~#  systemctl status tee-supplicant.service

x tee-supplicant.service - TEE Supplicant

      Loaded: loaded (/lib/systemd/system/tee-supplicant.service; 
enabled; preset: enabled)

      Active: failed (Result: exit-code) since Sun 2025-02-23 22:41:08 
UTC; 32s ago

    Duration: 191ms

     Process: 468 ExecStart=/usr/sbin/tee-supplicant $OPTARGS 
(code=exited, status=1/FAILURE)

    Main PID: 468 (code=exited, status=1/FAILURE)

Feb 23 22:41:08 qemux86-64 systemd[1]: Started TEE Supplicant.

Feb 23 22:41:08 qemux86-64 tee-supplicant[468]: ERR [468] TSUP:main:884: 
failed to find an OP-TEE suppli>

Feb 23 22:41:08 qemux86-64 systemd[1]: tee-supplicant.service: Main 
process exited, code=exited, status=>

Feb 23 22:41:08 qemux86-64 systemd[1]: tee-supplicant.service: Failed 
with result 'exit-code'.

Thanks,
Haixiao


On 2/21/2025 11:06 PM, Jon Mason wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> On Thu, Feb 20, 2025 at 8:34 PM Yan, Haixiao (CN) via
> lists.yoctoproject.org
> <Haixiao.Yan.CN=windriver.com@lists.yoctoproject.org> wrote:
>> From: Haixiao Yan <haixiao.yan.cn@windriver.com>
>>
>> optee-client will be built on qemux86-64, there is no OP-TEE supplicant
>> device on this platform.
> I don't think I understand what you mean.  More verbosity in the
> commit message might help in the future.
> I was able to add optee-client to qemux86-64 and it compiled without issue.
>
> Either way, this patch breaks corstone1000 and fvp-base (with
> fvp-base-ts).  You can see it in
> https://gitlab.com/jonmason00/meta-arm/-/jobs/9203534679
> https://gitlab.com/jonmason00/meta-arm/-/jobs/9203534694
>
> Thanks,
> Jon
>
>> Signed-off-by: Haixiao Yan <haixiao.yan.cn@windriver.com>
>> ---
>>   meta-arm/recipes-security/optee/optee-client.inc | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/meta-arm/recipes-security/optee/optee-client.inc b/meta-arm/recipes-security/optee/optee-client.inc
>> index f387c80574b0..aafb1efcf726 100644
>> --- a/meta-arm/recipes-security/optee/optee-client.inc
>> +++ b/meta-arm/recipes-security/optee/optee-client.inc
>> @@ -6,6 +6,7 @@ LICENSE = "BSD-2-Clause"
>>   LIC_FILES_CHKSUM = "file://LICENSE;md5=69663ab153298557a59c67a60a743e5b"
>>
>>   inherit systemd update-rc.d cmake useradd
>> +require optee.inc
>>
>>   SRC_URI = " \
>>       git://github.com/OP-TEE/optee_client.git;branch=master;protocol=https \
>> --
>> 2.34.1
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#6376): https://lists.yoctoproject.org/g/meta-arm/message/6376
>> Mute This Topic: https://lists.yoctoproject.org/mt/111301214/3616920
>> Group Owner: meta-arm+owner@lists.yoctoproject.org
>> Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [jdmason@kudzu.us]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>

Re: [meta-arm][PATCH 1/1] optee-client: disable build on qemux86-64

[Mikko Rapeli]

Hi,

On Tue, Feb 25, 2025 at 08:41:04AM +0800, Yan, Haixiao (CN) via lists.yoctoproject.org wrote:
> My local branch is mickledore. tee-supplicant.service start failed on
> qemux86-64.
> 
> https://git.yoctoproject.org/meta-arm/commit/meta-arm/recipes-security/optee/optee-client.inc?id=1bff41eee67d6dafc7c58b0c88923a3c6f7a2a7c
> 
> 
> this commit can resolve my issue.
> 
> My question is could we add the COMPATIBLE_MACHINE for optee-client?  So for
> qemux86-64, if there is no OP-TEE supplicant device, optee-client build
> 
> can skip.
> 
> 
> root@qemux86-64:~#  systemctl status tee-supplicant.service
> 
> x tee-supplicant.service - TEE Supplicant
> 
>      Loaded: loaded (/lib/systemd/system/tee-supplicant.service; enabled;
> preset: enabled)
> 
>      Active: failed (Result: exit-code) since Sun 2025-02-23 22:41:08 UTC;
> 32s ago
> 
>    Duration: 191ms
> 
>     Process: 468 ExecStart=/usr/sbin/tee-supplicant $OPTARGS (code=exited,
> status=1/FAILURE)
> 
>    Main PID: 468 (code=exited, status=1/FAILURE)
> 
> Feb 23 22:41:08 qemux86-64 systemd[1]: Started TEE Supplicant.
> 
> Feb 23 22:41:08 qemux86-64 tee-supplicant[468]: ERR [468] TSUP:main:884:
> failed to find an OP-TEE suppli>
> 
> Feb 23 22:41:08 qemux86-64 systemd[1]: tee-supplicant.service: Main process
> exited, code=exited, status=>
> 
> Feb 23 22:41:08 qemux86-64 systemd[1]: tee-supplicant.service: Failed with
> result 'exit-code'.

One way to fix this is to change tee-supplicante.service to be started by udev
when optee kernel drivers get loaded and optee is found from firmware.

Patches were sent but caused regressions and fixing those are on my todo list, sadly
way back there.

https://lists.yoctoproject.org/g/meta-arm/message/6203

sysvinit scripts are a different story.

Cheers,

-Mikko

> Thanks,
> Haixiao
> 
> 
> On 2/21/2025 11:06 PM, Jon Mason wrote:
> > CAUTION: This email comes from a non Wind River email account!
> > Do not click links or open attachments unless you recognize the sender and know the content is safe.
> > 
> > On Thu, Feb 20, 2025 at 8:34 PM Yan, Haixiao (CN) via
> > lists.yoctoproject.org
> > <Haixiao.Yan.CN=windriver.com@lists.yoctoproject.org> wrote:
> > > From: Haixiao Yan <haixiao.yan.cn@windriver.com>
> > > 
> > > optee-client will be built on qemux86-64, there is no OP-TEE supplicant
> > > device on this platform.
> > I don't think I understand what you mean.  More verbosity in the
> > commit message might help in the future.
> > I was able to add optee-client to qemux86-64 and it compiled without issue.
> > 
> > Either way, this patch breaks corstone1000 and fvp-base (with
> > fvp-base-ts).  You can see it in
> > https://gitlab.com/jonmason00/meta-arm/-/jobs/9203534679
> > https://gitlab.com/jonmason00/meta-arm/-/jobs/9203534694
> > 
> > Thanks,
> > Jon
> > 
> > > Signed-off-by: Haixiao Yan <haixiao.yan.cn@windriver.com>
> > > ---
> > >   meta-arm/recipes-security/optee/optee-client.inc | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/meta-arm/recipes-security/optee/optee-client.inc b/meta-arm/recipes-security/optee/optee-client.inc
> > > index f387c80574b0..aafb1efcf726 100644
> > > --- a/meta-arm/recipes-security/optee/optee-client.inc
> > > +++ b/meta-arm/recipes-security/optee/optee-client.inc
> > > @@ -6,6 +6,7 @@ LICENSE = "BSD-2-Clause"
> > >   LIC_FILES_CHKSUM = "file://LICENSE;md5=69663ab153298557a59c67a60a743e5b"
> > > 
> > >   inherit systemd update-rc.d cmake useradd
> > > +require optee.inc
> > > 
> > >   SRC_URI = " \
> > >       git://github.com/OP-TEE/optee_client.git;branch=master;protocol=https \
> > > --
> > > 2.34.1
> > > 
> > > 
> > > 
> > > 

> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#6383): https://lists.yoctoproject.org/g/meta-arm/message/6383
> Mute This Topic: https://lists.yoctoproject.org/mt/111301214/7159507
> Group Owner: meta-arm+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-arm/unsub [mikko.rapeli@linaro.org]
> -=-=-=-=-=-=-=-=-=-=-=-
>