* [PATCH] libmpathutils/uxsock.c: Include string.h for memcpy
@ 2025-02-17 20:05 Khem Raj
2025-02-17 21:03 ` Benjamin Marzinski
0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2025-02-17 20:05 UTC (permalink / raw)
To: dm-devel; +Cc: Khem Raj, Benjamin Marzinski, Martin Wilck
Fixes
uxsock.c:72:2: error: call to undeclared library function 'memcpy' with type 'void *(void *, const void *, unsigned long)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Cc: Benjamin Marzinski <bmarzins@redhat.com>
Cc: Martin Wilck <mwilck@suse.com>
---
libmpathutil/uxsock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/libmpathutil/uxsock.c b/libmpathutil/uxsock.c
index 2135476d..a474874e 100644
--- a/libmpathutil/uxsock.c
+++ b/libmpathutil/uxsock.c
@@ -8,6 +8,7 @@
#include <stdlib.h>
#include <unistd.h>
#include <stdarg.h>
+#include <string.h>
#include <fcntl.h>
#include <sys/ioctl.h>
#include <sys/types.h>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] libmpathutils/uxsock.c: Include string.h for memcpy
2025-02-17 20:05 [PATCH] libmpathutils/uxsock.c: Include string.h for memcpy Khem Raj
@ 2025-02-17 21:03 ` Benjamin Marzinski
2025-02-24 22:03 ` Martin Wilck
0 siblings, 1 reply; 3+ messages in thread
From: Benjamin Marzinski @ 2025-02-17 21:03 UTC (permalink / raw)
To: Khem Raj; +Cc: dm-devel, Martin Wilck
On Mon, Feb 17, 2025 at 12:05:03PM -0800, Khem Raj wrote:
> Fixes
> uxsock.c:72:2: error: call to undeclared library function 'memcpy' with type 'void *(void *, const void *, unsigned long)'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: Benjamin Marzinski <bmarzins@redhat.com>
> Cc: Martin Wilck <mwilck@suse.com>
> ---
> libmpathutil/uxsock.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libmpathutil/uxsock.c b/libmpathutil/uxsock.c
> index 2135476d..a474874e 100644
> --- a/libmpathutil/uxsock.c
> +++ b/libmpathutil/uxsock.c
> @@ -8,6 +8,7 @@
> #include <stdlib.h>
> #include <unistd.h>
> #include <stdarg.h>
> +#include <string.h>
> #include <fcntl.h>
> #include <sys/ioctl.h>
> #include <sys/types.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] libmpathutils/uxsock.c: Include string.h for memcpy
2025-02-17 21:03 ` Benjamin Marzinski
@ 2025-02-24 22:03 ` Martin Wilck
0 siblings, 0 replies; 3+ messages in thread
From: Martin Wilck @ 2025-02-24 22:03 UTC (permalink / raw)
To: Benjamin Marzinski, Khem Raj; +Cc: dm-devel
On Mon, 2025-02-17 at 16:03 -0500, Benjamin Marzinski wrote:
> On Mon, Feb 17, 2025 at 12:05:03PM -0800, Khem Raj wrote:
> > Fixes
> > uxsock.c:72:2: error: call to undeclared library function 'memcpy'
> > with type 'void *(void *, const void *, unsigned long)'; ISO C99
> > and later do not support implicit function declarations [-
> > Wimplicit-function-declaration]
>
> Reviewed-by: Benjamin Marzinski <bmarzins@redhat.com>
Thanks, it turns out that we have this include already in the queue
branch, but I applied your patch on stable-0.11.y and stable-0.10.y.
Regards
Martin
> >
> > Signed-off-by: Khem Raj <raj.khem@gmail.com>
> > Cc: Benjamin Marzinski <bmarzins@redhat.com>
> > Cc: Martin Wilck <mwilck@suse.com>
> > ---
> > libmpathutil/uxsock.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/libmpathutil/uxsock.c b/libmpathutil/uxsock.c
> > index 2135476d..a474874e 100644
> > --- a/libmpathutil/uxsock.c
> > +++ b/libmpathutil/uxsock.c
> > @@ -8,6 +8,7 @@
> > #include <stdlib.h>
> > #include <unistd.h>
> > #include <stdarg.h>
> > +#include <string.h>
> > #include <fcntl.h>
> > #include <sys/ioctl.h>
> > #include <sys/types.h>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-02-24 22:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-17 20:05 [PATCH] libmpathutils/uxsock.c: Include string.h for memcpy Khem Raj
2025-02-17 21:03 ` Benjamin Marzinski
2025-02-24 22:03 ` Martin Wilck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.