From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@gmail.com, simona@ffwll.ch,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
imx@lists.linux.dev, linux-samsung-soc@vger.kernel.org,
nouveau@lists.freedesktop.org, virtualization@lists.linux.dev,
spice-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org,
intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 06/25] drm/armada: Compute dumb-buffer sizes with drm_mode_size_dumb()
Date: Tue, 18 Feb 2025 15:57:04 +0000 [thread overview]
Message-ID: <Z7St0O3A_mXEYK49@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250218142542.438557-7-tzimmermann@suse.de>
On Tue, Feb 18, 2025 at 03:23:29PM +0100, Thomas Zimmermann wrote:
> Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and
> buffer size. No alignment required.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Russell King <linux@armlinux.org.uk>
armada_pitch() does have some special alignment (it aligns the pitch to
128 bytes). I've no idea what drm_mode_size_dumb() does. Can you check
whether it does the same please?
If it doesn't, then this patch is incorrect.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
WARNING: multiple messages have this Message-ID (diff)
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@gmail.com, simona@ffwll.ch,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org,
freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
imx@lists.linux.dev, linux-samsung-soc@vger.kernel.org,
nouveau@lists.freedesktop.org, virtualization@lists.linux.dev,
spice-devel@lists.freedesktop.org,
linux-renesas-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org, linux-tegra@vger.kernel.org,
intel-xe@lists.freedesktop.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v3 06/25] drm/armada: Compute dumb-buffer sizes with drm_mode_size_dumb()
Date: Tue, 18 Feb 2025 15:57:04 +0000 [thread overview]
Message-ID: <Z7St0O3A_mXEYK49@shell.armlinux.org.uk> (raw)
In-Reply-To: <20250218142542.438557-7-tzimmermann@suse.de>
On Tue, Feb 18, 2025 at 03:23:29PM +0100, Thomas Zimmermann wrote:
> Call drm_mode_size_dumb() to compute dumb-buffer scanline pitch and
> buffer size. No alignment required.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> Cc: Russell King <linux@armlinux.org.uk>
armada_pitch() does have some special alignment (it aligns the pitch to
128 bytes). I've no idea what drm_mode_size_dumb() does. Can you check
whether it does the same please?
If it doesn't, then this patch is incorrect.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2025-02-18 15:57 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-18 14:23 [PATCH v3 00/25] drm/dumb-buffers: Fix and improve buffer-size calculation Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 01/25] drm/dumb-buffers: Sanitize output on errors Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 02/25] drm/dumb-buffers: Provide helper to set pitch and size Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 19:32 ` Geert Uytterhoeven
2025-02-18 19:32 ` Geert Uytterhoeven
2025-02-19 8:08 ` Thomas Zimmermann
2025-02-19 8:08 ` Thomas Zimmermann
2025-02-20 9:18 ` Tomi Valkeinen
2025-02-20 9:18 ` Tomi Valkeinen
2025-02-20 10:05 ` Thomas Zimmermann
2025-02-20 10:05 ` Thomas Zimmermann
2025-02-20 10:53 ` Tomi Valkeinen
2025-02-20 10:53 ` Tomi Valkeinen
2025-02-21 9:19 ` Thomas Zimmermann
2025-02-21 9:19 ` Thomas Zimmermann
2025-02-21 9:57 ` Geert Uytterhoeven
2025-02-21 9:57 ` Geert Uytterhoeven
2025-02-21 10:08 ` Thomas Zimmermann
2025-02-21 10:08 ` Thomas Zimmermann
2025-02-25 13:45 ` Tomi Valkeinen
2025-02-25 13:45 ` Tomi Valkeinen
2025-02-26 10:16 ` Thomas Zimmermann
2025-02-26 10:16 ` Thomas Zimmermann
2025-03-07 8:42 ` Simona Vetter
2025-03-07 8:42 ` Simona Vetter
2025-03-07 13:19 ` Simona Vetter
2025-03-07 13:19 ` Simona Vetter
2025-02-18 14:23 ` [PATCH v3 03/25] drm/gem-dma: Compute dumb-buffer sizes with drm_mode_size_dumb() Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 04/25] drm/gem-shmem: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 05/25] drm/gem-vram: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 06/25] drm/armada: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 15:57 ` Russell King (Oracle) [this message]
2025-02-18 15:57 ` Russell King (Oracle)
2025-02-19 8:09 ` Thomas Zimmermann
2025-02-19 8:09 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 07/25] drm/exynos: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 08/25] drm/gma500: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 09/25] drm/hibmc: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 10/25] drm/imx/ipuv3: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 11/25] drm/loongson: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 12/25] drm/mediatek: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 13/25] drm/msm: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 14/25] drm/nouveau: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-20 22:17 ` Lyude Paul
2025-02-20 22:17 ` Lyude Paul
2025-02-18 14:23 ` [PATCH v3 15/25] drm/omapdrm: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 16/25] drm/qxl: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 17/25] drm/renesas/rcar-du: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 18/25] drm/renesas/rz-du: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 19/25] drm/rockchip: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 20/25] drm/tegra: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-03-06 19:26 ` Thierry Reding
2025-03-06 19:26 ` Thierry Reding
2025-02-18 14:23 ` [PATCH v3 21/25] drm/virtio: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 22/25] drm/vmwgfx: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 23/25] drm/xe: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-20 10:08 ` Matthew Auld
2025-02-20 10:08 ` Matthew Auld
2025-02-18 14:23 ` [PATCH v3 24/25] drm/xen: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 14:23 ` [PATCH v3 25/25] drm/xlnx: " Thomas Zimmermann
2025-02-18 14:23 ` Thomas Zimmermann
2025-02-18 15:06 ` ✓ CI.Patch_applied: success for drm/dumb-buffers: Fix and improve buffer-size calculation (rev3) Patchwork
2025-02-18 15:06 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-18 15:08 ` ✓ CI.KUnit: success " Patchwork
2025-02-18 15:24 ` ✓ CI.Build: " Patchwork
2025-02-18 15:27 ` ✓ CI.Hooks: " Patchwork
2025-02-18 15:28 ` ✗ CI.checksparse: warning " Patchwork
2025-02-18 15:57 ` ✓ Xe.CI.BAT: success " Patchwork
2025-02-19 8:27 ` ✓ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z7St0O3A_mXEYK49@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=imx@lists.linux.dev \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
--cc=spice-devel@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux.dev \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.