Re: [PATCH v2 08/10] net: phy: add Analog Devices ADIN1300

[Sascha Hauer <s.hauer@pengutronix.de>]

On Tue, Feb 18, 2025 at 10:21:33AM +0100, Steffen Trumtrar wrote:
> The Analog Devices ADIN1300 is a low power 10Mbps,100Mbps, and 1Gbps
> ethernet phy.
> (https://www.analog.com/media/en/technical-documentation/data-sheets/adin1300.pdf)

Where is this driver from? Can you add a reference to the commit
message?

> 
> Signed-off-by: Steffen Trumtrar <s.trumtrar@pengutronix.de>
> ---
>  drivers/net/phy/Kconfig  |   7 +
>  drivers/net/phy/Makefile |   1 +
>  drivers/net/phy/adin.c   | 360 +++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 368 insertions(+)
> 

...

> +static u16 adin_ext_read(struct phy_device *phydev, const u32 regnum)
> +{
> +	u16 val;
> +
> +	phy_write(phydev, ADIN1300_MII_EXT_REG_PTR, regnum);
> +	val = phy_read(phydev, ADIN1300_MII_EXT_REG_DATA);
> +
> +	debug("%s: adin@0x%x 0x%x=0x%x\n", __func__, phydev->addr, regnum, val);

phydev_dbg() please.

> +
> +	return val;
> +}
> +
> +static int adin_ext_write(struct phy_device *phydev, const u32 regnum, const u16 val)
> +{
> +	debug("%s: adin@0x%x 0x%x=0x%x\n", __func__, phydev->addr, regnum, val);

ditto

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |