[PATCH v1 1/1] auxdisplay: panel: Fix an API misuse in panel.c

[PATCH v1 1/1] auxdisplay: panel: Fix an API misuse in panel.c

[Andy Shevchenko]

Variable allocated by charlcd_alloc() should be released
by charlcd_free(). The following patch changed kfree() to
charlcd_free() to fix an API misuse.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/auxdisplay/panel.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/auxdisplay/panel.c b/drivers/auxdisplay/panel.c
index 098d490c1cf9..4da142692d55 100644
--- a/drivers/auxdisplay/panel.c
+++ b/drivers/auxdisplay/panel.c
@@ -1664,7 +1664,7 @@ static void panel_attach(struct parport *port)
 	if (lcd.enabled)
 		charlcd_unregister(lcd.charlcd);
 err_unreg_device:
-	kfree(lcd.charlcd);
+	charlcd_free(lcd.charlcd);
 	lcd.charlcd = NULL;
 	parport_unregister_device(pprt);
 	pprt = NULL;
@@ -1692,7 +1692,7 @@ static void panel_detach(struct parport *port)
 		charlcd_unregister(lcd.charlcd);
 		lcd.initialized = false;
 		kfree(lcd.charlcd->drvdata);
-		kfree(lcd.charlcd);
+		charlcd_free(lcd.charlcd);
 		lcd.charlcd = NULL;
 	}
 
-- 
2.45.1.3035.g276e886db78b

Re: [PATCH v1 1/1] auxdisplay: panel: Fix an API misuse in panel.c

[Geert Uytterhoeven]

On Mon, 24 Feb 2025 at 13:36, Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Variable allocated by charlcd_alloc() should be released
> by charlcd_free(). The following patch changed kfree() to
> charlcd_free() to fix an API misuse.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v1 1/1] auxdisplay: panel: Fix an API misuse in panel.c

[Andy Shevchenko]

On Mon, Feb 24, 2025 at 02:36:25PM +0200, Andy Shevchenko wrote:
> Variable allocated by charlcd_alloc() should be released
> by charlcd_free(). The following patch changed kfree() to
> charlcd_free() to fix an API misuse.

As discussed with Geert in another similar change this would also need
Fixes: 718e05ed92ec ("auxdisplay: Introduce hd44780_common.[ch]")

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v1 1/1] auxdisplay: panel: Fix an API misuse in panel.c

[Andy Shevchenko]

On Mon, Feb 24, 2025 at 02:39:48PM +0100, Geert Uytterhoeven wrote:
> On Mon, 24 Feb 2025 at 13:36, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> > Variable allocated by charlcd_alloc() should be released
> > by charlcd_free(). The following patch changed kfree() to
> > charlcd_free() to fix an API misuse.
> >
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko