* [PATCH] nvme-tcp: Fix a C2HTermReq error message
@ 2025-02-24 14:40 Maurizio Lombardi
2025-02-27 10:30 ` Maurizio Lombardi
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Maurizio Lombardi @ 2025-02-24 14:40 UTC (permalink / raw)
To: kbusch; +Cc: sagi, linux-nvme, hare, mlombard
In H2CTermReq, a FES with value 0x05 means "R2T Limit Exceeded"; but
in C2HTermReq the same value has a different meaning (Data Transfer Limit
Exceeded).
Fixes: 84e009042d0f ("nvme-tcp: add basic support for the C2HTermReq PDU")
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
---
drivers/nvme/host/tcp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
index 8a9131c95a3d..183cc58ecded 100644
--- a/drivers/nvme/host/tcp.c
+++ b/drivers/nvme/host/tcp.c
@@ -775,7 +775,7 @@ static void nvme_tcp_handle_c2h_term(struct nvme_tcp_queue *queue,
[NVME_TCP_FES_PDU_SEQ_ERR] = "PDU Sequence Error",
[NVME_TCP_FES_HDR_DIGEST_ERR] = "Header Digest Error",
[NVME_TCP_FES_DATA_OUT_OF_RANGE] = "Data Transfer Out Of Range",
- [NVME_TCP_FES_R2T_LIMIT_EXCEEDED] = "R2T Limit Exceeded",
+ [NVME_TCP_FES_DATA_LIMIT_EXCEEDED] = "Data Transfer Limit Exceeded",
[NVME_TCP_FES_UNSUPPORTED_PARAM] = "Unsupported Parameter",
};
--
2.43.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] nvme-tcp: Fix a C2HTermReq error message
2025-02-24 14:40 [PATCH] nvme-tcp: Fix a C2HTermReq error message Maurizio Lombardi
@ 2025-02-27 10:30 ` Maurizio Lombardi
2025-02-27 11:28 ` Sagi Grimberg
2025-02-28 17:59 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Maurizio Lombardi @ 2025-02-27 10:30 UTC (permalink / raw)
To: Maurizio Lombardi, kbusch; +Cc: sagi, linux-nvme, hare
Ping.
Sagi, can you review this? It's just a trivial fix.
Thanks!
Maurizio
On Mon Feb 24, 2025 at 3:40 PM CET, Maurizio Lombardi wrote:
> In H2CTermReq, a FES with value 0x05 means "R2T Limit Exceeded"; but
> in C2HTermReq the same value has a different meaning (Data Transfer Limit
> Exceeded).
>
> Fixes: 84e009042d0f ("nvme-tcp: add basic support for the C2HTermReq PDU")
>
> Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
> ---
> drivers/nvme/host/tcp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c
> index 8a9131c95a3d..183cc58ecded 100644
> --- a/drivers/nvme/host/tcp.c
> +++ b/drivers/nvme/host/tcp.c
> @@ -775,7 +775,7 @@ static void nvme_tcp_handle_c2h_term(struct nvme_tcp_queue *queue,
> [NVME_TCP_FES_PDU_SEQ_ERR] = "PDU Sequence Error",
> [NVME_TCP_FES_HDR_DIGEST_ERR] = "Header Digest Error",
> [NVME_TCP_FES_DATA_OUT_OF_RANGE] = "Data Transfer Out Of Range",
> - [NVME_TCP_FES_R2T_LIMIT_EXCEEDED] = "R2T Limit Exceeded",
> + [NVME_TCP_FES_DATA_LIMIT_EXCEEDED] = "Data Transfer Limit Exceeded",
> [NVME_TCP_FES_UNSUPPORTED_PARAM] = "Unsupported Parameter",
> };
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] nvme-tcp: Fix a C2HTermReq error message
2025-02-24 14:40 [PATCH] nvme-tcp: Fix a C2HTermReq error message Maurizio Lombardi
2025-02-27 10:30 ` Maurizio Lombardi
@ 2025-02-27 11:28 ` Sagi Grimberg
2025-02-28 17:59 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Sagi Grimberg @ 2025-02-27 11:28 UTC (permalink / raw)
To: Maurizio Lombardi, kbusch; +Cc: linux-nvme, hare, mlombard
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] nvme-tcp: Fix a C2HTermReq error message
2025-02-24 14:40 [PATCH] nvme-tcp: Fix a C2HTermReq error message Maurizio Lombardi
2025-02-27 10:30 ` Maurizio Lombardi
2025-02-27 11:28 ` Sagi Grimberg
@ 2025-02-28 17:59 ` Keith Busch
2 siblings, 0 replies; 4+ messages in thread
From: Keith Busch @ 2025-02-28 17:59 UTC (permalink / raw)
To: Maurizio Lombardi; +Cc: sagi, linux-nvme, hare, mlombard
On Mon, Feb 24, 2025 at 03:40:58PM +0100, Maurizio Lombardi wrote:
> In H2CTermReq, a FES with value 0x05 means "R2T Limit Exceeded"; but
> in C2HTermReq the same value has a different meaning (Data Transfer Limit
> Exceeded).
>
> Fixes: 84e009042d0f ("nvme-tcp: add basic support for the C2HTermReq PDU")
Thanks, applied to nvme-6.14.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-02-28 17:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-24 14:40 [PATCH] nvme-tcp: Fix a C2HTermReq error message Maurizio Lombardi
2025-02-27 10:30 ` Maurizio Lombardi
2025-02-27 11:28 ` Sagi Grimberg
2025-02-28 17:59 ` Keith Busch
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.