All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yao Zi <ziyao@disroot.org>
To: "Diederik de Haas" <didi.debian@cknow.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Dragan Simic" <dsimic@manjaro.org>,
	"Johan Jonker" <jbx6244@gmail.com>,
	"Wenhao Cui" <lasstp5011@gmail.com>,
	"Yuteng Zhong" <zonyitoo@gmail.com>
Cc: <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-rockchip@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Remove undocumented sdmmc property from lubancat-1
Date: Fri, 28 Feb 2025 17:59:42 +0000	[thread overview]
Message-ID: <Z8H5jjE24cZb4IBQ@pie.lan> (raw)
In-Reply-To: <D848JET5TDL6.2L4ZQR0YHYQU6@cknow.org>

On Fri, Feb 28, 2025 at 05:55:47PM +0100, Diederik de Haas wrote:
> On Fri Feb 28, 2025 at 5:31 PM CET, Yao Zi wrote:
> > Property "supports-cd" isn't documented anywhere and is unnecessary for
> 
> s/supports-cd/supports-sd/ ?

Oops, yes, it's a typo.

As it's a trival patch, could it be fixed on merging? Or should I send
another version?

> Cheers,
>   Diederik

Thanks,
Yao Zi

> > mainline driver to function. It seems a property used by downstream
> > kernel was brought into mainline.
> >
> > This should be reported by dtbs_check, but mmc-controller-common.yaml
> > defaults additionalProperties to true thus allows it. Remove the
> > property to clean the devicetree up and avoid possible confusion.
> >
> > Fixes: 8d94da58de53 ("arm64: dts: rockchip: Add EmbedFire LubanCat 1")
> > Signed-off-by: Yao Zi <ziyao@disroot.org>


WARNING: multiple messages have this Message-ID (diff)
From: Yao Zi <ziyao@disroot.org>
To: "Diederik de Haas" <didi.debian@cknow.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Heiko Stuebner" <heiko@sntech.de>,
	"Dragan Simic" <dsimic@manjaro.org>,
	"Johan Jonker" <jbx6244@gmail.com>,
	"Wenhao Cui" <lasstp5011@gmail.com>,
	"Yuteng Zhong" <zonyitoo@gmail.com>
Cc: <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-rockchip@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Remove undocumented sdmmc property from lubancat-1
Date: Fri, 28 Feb 2025 17:59:42 +0000	[thread overview]
Message-ID: <Z8H5jjE24cZb4IBQ@pie.lan> (raw)
In-Reply-To: <D848JET5TDL6.2L4ZQR0YHYQU6@cknow.org>

On Fri, Feb 28, 2025 at 05:55:47PM +0100, Diederik de Haas wrote:
> On Fri Feb 28, 2025 at 5:31 PM CET, Yao Zi wrote:
> > Property "supports-cd" isn't documented anywhere and is unnecessary for
> 
> s/supports-cd/supports-sd/ ?

Oops, yes, it's a typo.

As it's a trival patch, could it be fixed on merging? Or should I send
another version?

> Cheers,
>   Diederik

Thanks,
Yao Zi

> > mainline driver to function. It seems a property used by downstream
> > kernel was brought into mainline.
> >
> > This should be reported by dtbs_check, but mmc-controller-common.yaml
> > defaults additionalProperties to true thus allows it. Remove the
> > property to clean the devicetree up and avoid possible confusion.
> >
> > Fixes: 8d94da58de53 ("arm64: dts: rockchip: Add EmbedFire LubanCat 1")
> > Signed-off-by: Yao Zi <ziyao@disroot.org>

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2025-02-28 18:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-28 16:31 [PATCH] arm64: dts: rockchip: Remove undocumented sdmmc property from lubancat-1 Yao Zi
2025-02-28 16:31 ` Yao Zi
2025-02-28 16:55 ` Diederik de Haas
2025-02-28 16:55   ` Diederik de Haas
2025-02-28 17:59   ` Yao Zi [this message]
2025-02-28 17:59     ` Yao Zi
2025-02-28 18:05     ` Heiko Stübner
2025-02-28 18:05       ` Heiko Stübner
2025-02-28 22:01 ` Heiko Stuebner
2025-02-28 22:01   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z8H5jjE24cZb4IBQ@pie.lan \
    --to=ziyao@disroot.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=didi.debian@cknow.org \
    --cc=dsimic@manjaro.org \
    --cc=heiko@sntech.de \
    --cc=jbx6244@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lasstp5011@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    --cc=zonyitoo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.