From: Andy Shevchenko <andy@kernel.org>
To: George Cherian <george.cherian@marvell.com>
Cc: linux@roeck-us.net, wim@linux-watchdog.org, jwerner@chromium.org,
evanbenn@chromium.org, kabel@kernel.org, krzk@kernel.org,
mazziesaccount@gmail.com, thomas.richard@bootlin.com,
lma@chromium.org, bleung@chromium.org,
support.opensource@diasemi.com, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, paul@crapouillou.net,
alexander.usyskin@intel.com, andreas.werner@men.de,
daniel@thingy.jp, romain.perier@gmail.com,
avifishman70@gmail.com, tmaimon77@gmail.com,
tali.perry1@gmail.com, venture@google.com, yuenn@google.com,
benjaminfair@google.com, maddy@linux.ibm.com, mpe@ellerman.id.au,
npiggin@gmail.com, christophe.leroy@csgroup.eu,
naveen@kernel.org, mwalle@kernel.org, xingyu.wu@starfivetech.com,
ziv.xu@starfivetech.com, hayashi.kunihiko@socionext.com,
mhiramat@kernel.org, linux-watchdog@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
chrome-platform@lists.linux.dev, imx@lists.linux.dev,
linux-mips@vger.kernel.org, openbmc@lists.ozlabs.org,
linuxppc-dev@lists.ozlabs.org, patches@opensource.cirrus.com
Subject: Re: [PATCH v4 2/2] drivers: watchdog: Add support for panic notifier callback
Date: Wed, 5 Mar 2025 12:33:41 +0200 [thread overview]
Message-ID: <Z8gohVIQqlA6QquZ@smile.fi.intel.com> (raw)
In-Reply-To: <20250305101025.2279951-3-george.cherian@marvell.com>
On Wed, Mar 05, 2025 at 10:10:25AM +0000, George Cherian wrote:
> Watchdog is not turned off in kernel panic situation.
> In certain systems this might prevent the successful loading
> of kdump kernel. The kdump kernel might hit a watchdog reset
> while it is booting.
>
> To avoid such scenarios add a panic notifier call back function
> which can stop the watchdog. This provision can be enabled by
> passing watchdog.stop_on_panic=1 via kernel command-line parameter.
...
First of all, do we really need a new module parameter for that? Why can't it
be done automatically if kdump is expected?
> +static bool stop_on_panic;
> +module_param(stop_on_panic, bool, 0444);
> +MODULE_PARM_DESC(stop_on_panic, "Stop watchdogs on panic (0=keep watching, 1=stop)");
+ blank line.
Also I do not see the documentation update. Where is it lost?
> /*
--
With Best Regards,
Andy Shevchenko
WARNING: multiple messages have this Message-ID (diff)
From: Andy Shevchenko <andy@kernel.org>
To: George Cherian <george.cherian@marvell.com>
Cc: imx@lists.linux.dev, mwalle@kernel.org, tmaimon77@gmail.com,
hayashi.kunihiko@socionext.com, alexander.usyskin@intel.com,
tali.perry1@gmail.com, paul@crapouillou.net, daniel@thingy.jp,
patches@opensource.cirrus.com, christophe.leroy@csgroup.eu,
festevam@gmail.com, kabel@kernel.org,
chrome-platform@lists.linux.dev, maddy@linux.ibm.com,
benjaminfair@google.com, lma@chromium.org, mpe@ellerman.id.au,
openbmc@lists.ozlabs.org, krzk@kernel.org, evanbenn@chromium.org,
linux-mips@vger.kernel.org, linux@roeck-us.net,
linux-watchdog@vger.kernel.org, mazziesaccount@gmail.com,
s.hauer@pengutronix.de, naveen@kernel.org, npiggin@gmail.com,
xingyu.wu@starfivetech.com, ziv.xu@starfivetech.com,
wim@linux-watchdog.org, bleung@chromium.org,
linux-arm-kernel@lists.infradead.org,
support.opensource@diasemi.com, andreas.werner@men.de,
avifishman70@gmail.com, thomas.richard@bootlin.com,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
mhiramat@kernel.org, kernel@pengutronix.de, venture@google.com,
jwerner@chromium.org, romain.perier@gmail.com,
shawnguo@kernel.org
Subject: Re: [PATCH v4 2/2] drivers: watchdog: Add support for panic notifier callback
Date: Wed, 5 Mar 2025 12:33:41 +0200 [thread overview]
Message-ID: <Z8gohVIQqlA6QquZ@smile.fi.intel.com> (raw)
In-Reply-To: <20250305101025.2279951-3-george.cherian@marvell.com>
On Wed, Mar 05, 2025 at 10:10:25AM +0000, George Cherian wrote:
> Watchdog is not turned off in kernel panic situation.
> In certain systems this might prevent the successful loading
> of kdump kernel. The kdump kernel might hit a watchdog reset
> while it is booting.
>
> To avoid such scenarios add a panic notifier call back function
> which can stop the watchdog. This provision can be enabled by
> passing watchdog.stop_on_panic=1 via kernel command-line parameter.
...
First of all, do we really need a new module parameter for that? Why can't it
be done automatically if kdump is expected?
> +static bool stop_on_panic;
> +module_param(stop_on_panic, bool, 0444);
> +MODULE_PARM_DESC(stop_on_panic, "Stop watchdogs on panic (0=keep watching, 1=stop)");
+ blank line.
Also I do not see the documentation update. Where is it lost?
> /*
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2025-03-05 10:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 10:10 [PATCH v4 0/2] Add stop_on_panic support for watchdog George Cherian
2025-03-05 10:10 ` [PATCH v4 1/2] watchdog: Add a new flag WDIOF_STOP_MAYSLEEP George Cherian
2025-03-05 10:18 ` Marek Behún
2025-03-05 10:18 ` Marek Behún
2025-03-05 10:34 ` George Cherian
2025-03-05 10:34 ` George Cherian
2025-03-05 11:01 ` Ahmad Fatoum
2025-03-05 11:01 ` Ahmad Fatoum
2025-03-05 23:58 ` Guenter Roeck
2025-03-05 23:58 ` Guenter Roeck
2025-03-06 12:18 ` [EXTERNAL] " George Cherian
2025-03-06 12:18 ` George Cherian
2025-03-06 17:22 ` Guenter Roeck
2025-03-06 17:22 ` Guenter Roeck
2025-03-05 10:30 ` Andy Shevchenko
2025-03-05 10:30 ` Andy Shevchenko
2025-03-05 22:50 ` Julius Werner
2025-03-05 22:50 ` Julius Werner
2025-03-06 9:40 ` George Cherian
2025-03-06 9:40 ` George Cherian
2025-03-05 23:03 ` Guenter Roeck
2025-03-05 23:03 ` Guenter Roeck
2025-03-05 10:10 ` [PATCH v4 2/2] drivers: watchdog: Add support for panic notifier callback George Cherian
2025-03-05 10:33 ` Andy Shevchenko [this message]
2025-03-05 10:33 ` Andy Shevchenko
2025-03-06 0:00 ` Guenter Roeck
2025-03-06 0:00 ` Guenter Roeck
2025-03-05 10:31 ` [PATCH v4 0/2] Add stop_on_panic support for watchdog Andy Shevchenko
2025-03-05 10:31 ` Andy Shevchenko
2025-03-05 10:41 ` Ahmad Fatoum
2025-03-05 11:28 ` [EXTERNAL] " George Cherian
2025-03-05 11:39 ` Ahmad Fatoum
2025-03-05 12:15 ` George Cherian
2025-03-05 12:23 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8gohVIQqlA6QquZ@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=alexander.usyskin@intel.com \
--cc=andreas.werner@men.de \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=bleung@chromium.org \
--cc=christophe.leroy@csgroup.eu \
--cc=chrome-platform@lists.linux.dev \
--cc=daniel@thingy.jp \
--cc=evanbenn@chromium.org \
--cc=festevam@gmail.com \
--cc=george.cherian@marvell.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=imx@lists.linux.dev \
--cc=jwerner@chromium.org \
--cc=kabel@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lma@chromium.org \
--cc=maddy@linux.ibm.com \
--cc=mazziesaccount@gmail.com \
--cc=mhiramat@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=mwalle@kernel.org \
--cc=naveen@kernel.org \
--cc=npiggin@gmail.com \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@opensource.cirrus.com \
--cc=paul@crapouillou.net \
--cc=romain.perier@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=support.opensource@diasemi.com \
--cc=tali.perry1@gmail.com \
--cc=thomas.richard@bootlin.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=wim@linux-watchdog.org \
--cc=xingyu.wu@starfivetech.com \
--cc=yuenn@google.com \
--cc=ziv.xu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.