From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: Chao Yu <chao@kernel.org>
Cc: Daeho Jeong <daehojeong@google.com>,
kernel-team@android.com, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: subtract current_reserved_blocks from total
Date: Wed, 5 Mar 2025 14:35:18 +0000 [thread overview]
Message-ID: <Z8hhJs_fUOBN7U8y@google.com> (raw)
In-Reply-To: <41160b37-16ad-4c12-aad2-1214d87d3df0@kernel.org>
On 03/05, Chao Yu wrote:
> On 3/5/25 03:20, Daeho Jeong wrote:
> > From: Daeho Jeong <daehojeong@google.com>
> >
> > current_reserved_blocks is not allowed to utilize. For some zoned
> > storage devices, vendors will provide extra space which was used for
> > device level GC than specs and we will use this space for filesystem
> > level GC. This extra space should not be shown to users, otherwise,
> > users will see not standardized size number like 530GB, not 512GB.
>
> Hi Daeho,
>
> However, if there are other users e.g. oem or vendor want to use
> reserved_blocks and current_reserved_blocks sysfs interface to
> reserve space, then, total size will be less than 512GB?
>
> What do you think of adding a new variable to indicate reserved
> space for zoned storage case only?
Or, adding a sysfs entry like "carve_out" to determine this?
>
> Thanks,
>
> >
> > Signed-off-by: Daeho Jeong <daehojeong@google.com>
> > ---
> > fs/f2fs/super.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> > index 19b67828ae32..c346dcc2518a 100644
> > --- a/fs/f2fs/super.c
> > +++ b/fs/f2fs/super.c
> > @@ -1833,10 +1833,9 @@ static int f2fs_statfs(struct dentry *dentry, struct kstatfs *buf)
> > buf->f_type = F2FS_SUPER_MAGIC;
> > buf->f_bsize = sbi->blocksize;
> >
> > - buf->f_blocks = total_count - start_count;
> > -
> > spin_lock(&sbi->stat_lock);
> >
> > + buf->f_blocks = total_count - start_count - sbi->current_reserved_blocks;
> > user_block_count = sbi->user_block_count;
> > total_valid_node_count = valid_node_count(sbi);
> > avail_node_count = sbi->total_node_count - F2FS_RESERVED_NODE_NUM;
>
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <chao@kernel.org>
Cc: Daeho Jeong <daeho43@gmail.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
Daeho Jeong <daehojeong@google.com>
Subject: Re: [f2fs-dev] [PATCH] f2fs: subtract current_reserved_blocks from total
Date: Wed, 5 Mar 2025 14:35:18 +0000 [thread overview]
Message-ID: <Z8hhJs_fUOBN7U8y@google.com> (raw)
In-Reply-To: <41160b37-16ad-4c12-aad2-1214d87d3df0@kernel.org>
On 03/05, Chao Yu wrote:
> On 3/5/25 03:20, Daeho Jeong wrote:
> > From: Daeho Jeong <daehojeong@google.com>
> >
> > current_reserved_blocks is not allowed to utilize. For some zoned
> > storage devices, vendors will provide extra space which was used for
> > device level GC than specs and we will use this space for filesystem
> > level GC. This extra space should not be shown to users, otherwise,
> > users will see not standardized size number like 530GB, not 512GB.
>
> Hi Daeho,
>
> However, if there are other users e.g. oem or vendor want to use
> reserved_blocks and current_reserved_blocks sysfs interface to
> reserve space, then, total size will be less than 512GB?
>
> What do you think of adding a new variable to indicate reserved
> space for zoned storage case only?
Or, adding a sysfs entry like "carve_out" to determine this?
>
> Thanks,
>
> >
> > Signed-off-by: Daeho Jeong <daehojeong@google.com>
> > ---
> > fs/f2fs/super.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> > index 19b67828ae32..c346dcc2518a 100644
> > --- a/fs/f2fs/super.c
> > +++ b/fs/f2fs/super.c
> > @@ -1833,10 +1833,9 @@ static int f2fs_statfs(struct dentry *dentry, struct kstatfs *buf)
> > buf->f_type = F2FS_SUPER_MAGIC;
> > buf->f_bsize = sbi->blocksize;
> >
> > - buf->f_blocks = total_count - start_count;
> > -
> > spin_lock(&sbi->stat_lock);
> >
> > + buf->f_blocks = total_count - start_count - sbi->current_reserved_blocks;
> > user_block_count = sbi->user_block_count;
> > total_valid_node_count = valid_node_count(sbi);
> > avail_node_count = sbi->total_node_count - F2FS_RESERVED_NODE_NUM;
>
next prev parent reply other threads:[~2025-03-05 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 19:20 [f2fs-dev] [PATCH] f2fs: subtract current_reserved_blocks from total Daeho Jeong
2025-03-04 19:20 ` Daeho Jeong
2025-03-05 9:10 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-03-05 9:10 ` Chao Yu
2025-03-05 14:35 ` Jaegeuk Kim via Linux-f2fs-devel [this message]
2025-03-05 14:35 ` Jaegeuk Kim
2025-03-05 16:03 ` Daeho Jeong
2025-03-05 16:03 ` Daeho Jeong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8hhJs_fUOBN7U8y@google.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=chao@kernel.org \
--cc=daehojeong@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.