From: Catalin Marinas <catalin.marinas@arm.com>
To: "Kristina Martšenko" <kristina.martsenko@arm.com>
Cc: linux-arm-kernel@lists.infradead.org,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Tong Tiangen <tongtiangen@huawei.com>,
Robin Murphy <robin.murphy@arm.com>,
James Morse <james.morse@arm.com>
Subject: Re: [PATCH v2 2/3] arm64: mm: Handle PAN faults on uaccess CPY* instructions
Date: Fri, 7 Mar 2025 18:45:52 +0000 [thread overview]
Message-ID: <Z8s-4OPE2DNSogwB@arm.com> (raw)
In-Reply-To: <20250228170006.390100-3-kristina.martsenko@arm.com>
On Fri, Feb 28, 2025 at 05:00:05PM +0000, Kristina Martsenko wrote:
> +bool extable_insn_may_access_user(const struct exception_table_entry *ex,
> + unsigned long esr)
> +{
> + switch (ex->type) {
> + case EX_TYPE_UACCESS_CPY:
> + return cpy_faulted_on_uaccess(ex, esr);
> + default:
> + return true;
> + }
> +}
Not a problem with this patch but I wonder whether we should return
false for EX_TYPE_LOAD_UNALIGNED_ZEROPAD for completeness (and remove
the EX_TYPE_KACCESS_ERR_ZERO, it's no longer used.
--
Catalin
next prev parent reply other threads:[~2025-03-07 18:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 17:00 [PATCH v2 0/3] arm64: Use memory copy instructions in usercopy routines Kristina Martšenko
2025-02-28 17:00 ` [PATCH v2 1/3] arm64: extable: Add fixup handling for uaccess CPY* instructions Kristina Martšenko
2025-03-06 15:23 ` Robin Murphy
2025-02-28 17:00 ` [PATCH v2 2/3] arm64: mm: Handle PAN faults on " Kristina Martšenko
2025-03-06 15:28 ` Robin Murphy
2025-03-07 16:57 ` Catalin Marinas
2025-03-07 18:45 ` Catalin Marinas [this message]
2025-03-07 18:53 ` Robin Murphy
2025-03-07 21:37 ` Catalin Marinas
2025-03-10 14:15 ` Kristina Martšenko
2025-03-10 15:43 ` Catalin Marinas
2025-02-28 17:00 ` [PATCH v2 3/3] arm64: lib: Use MOPS for usercopy routines Kristina Martšenko
2025-03-06 15:47 ` Robin Murphy
2025-03-07 19:23 ` [PATCH v2 0/3] arm64: Use memory copy instructions in " Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8s-4OPE2DNSogwB@arm.com \
--to=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kristina.martsenko@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
--cc=tongtiangen@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.