From: Catalin Marinas <catalin.marinas@arm.com>
To: Robin Murphy <robin.murphy@arm.com>
Cc: "Kristina Martšenko" <kristina.martsenko@arm.com>,
linux-arm-kernel@lists.infradead.org,
"Will Deacon" <will@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Tong Tiangen" <tongtiangen@huawei.com>,
"James Morse" <james.morse@arm.com>
Subject: Re: [PATCH v2 2/3] arm64: mm: Handle PAN faults on uaccess CPY* instructions
Date: Fri, 7 Mar 2025 16:57:28 +0000 [thread overview]
Message-ID: <Z8sleC_1d1ozYdOO@arm.com> (raw)
In-Reply-To: <03dc25a3-c8a6-443b-ade7-2d3f69f2d0f4@arm.com>
On Thu, Mar 06, 2025 at 03:28:26PM +0000, Robin Murphy wrote:
> On 28/02/2025 5:00 pm, Kristina Martšenko wrote:
> > A subsequent patch will use CPY* instructions to copy between user and
> > kernel memory. Add handling for PAN faults caused by an intended kernel
> > memory access erroneously accessing user memory, in order to make it
> > easier to debug kernel bugs and to keep the same behavior as with
> > regular loads/stores.
>
> I'd be tempted to fold the search_exception_tables() call into
> insn_may_access_user() itself, but either way,
Yeah, I think it looks better folded in. I did it locally.
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>
Thanks.
--
Catalin
next prev parent reply other threads:[~2025-03-07 17:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-28 17:00 [PATCH v2 0/3] arm64: Use memory copy instructions in usercopy routines Kristina Martšenko
2025-02-28 17:00 ` [PATCH v2 1/3] arm64: extable: Add fixup handling for uaccess CPY* instructions Kristina Martšenko
2025-03-06 15:23 ` Robin Murphy
2025-02-28 17:00 ` [PATCH v2 2/3] arm64: mm: Handle PAN faults on " Kristina Martšenko
2025-03-06 15:28 ` Robin Murphy
2025-03-07 16:57 ` Catalin Marinas [this message]
2025-03-07 18:45 ` Catalin Marinas
2025-03-07 18:53 ` Robin Murphy
2025-03-07 21:37 ` Catalin Marinas
2025-03-10 14:15 ` Kristina Martšenko
2025-03-10 15:43 ` Catalin Marinas
2025-02-28 17:00 ` [PATCH v2 3/3] arm64: lib: Use MOPS for usercopy routines Kristina Martšenko
2025-03-06 15:47 ` Robin Murphy
2025-03-07 19:23 ` [PATCH v2 0/3] arm64: Use memory copy instructions in " Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8sleC_1d1ozYdOO@arm.com \
--to=catalin.marinas@arm.com \
--cc=james.morse@arm.com \
--cc=kristina.martsenko@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robin.murphy@arm.com \
--cc=tongtiangen@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.