From: Jaegeuk Kim via Linux-f2fs-devel <linux-f2fs-devel@lists.sourceforge.net>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 0/4] f2fs: Remove uses of writepage
Date: Fri, 7 Mar 2025 20:39:56 +0000 [thread overview]
Message-ID: <Z8tZnN-CAS20Dpi7@google.com> (raw)
In-Reply-To: <20250307182151.3397003-1-willy@infradead.org>
On 03/07, Matthew Wilcox (Oracle) wrote:
> I was planning on sending this next cycle, but maybe there's time to
> squeeze these patches into the upcoming merge window?
>
> f2fs already implements writepages and migrate_folio for all three
> address_space_operations, so either ->writepage will never be called (by
> migration) or it will only be harmful (if called from pageout()).
My tree sitting on [1] doesn't have mm-next, which looks difficult to test this
series for test alone. Matthew, can you point which patches I need to apply
in mm along with this for test?
[1] f286757b644c "Merge tag 'timers-urgent-2025-02-03' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip"
>
> The only remaining filesystem with ->writepage defined in next-20250307
> is vboxsf, so the concept of removing ->writepage is well proven. I
> have some follow-up patches which simplify f2fs writeback afterwards,
> but I think we can postpone them to next cycle.
>
> See
> https://lore.kernel.org/linux-fsdevel/20250307135414.2987755-1-willy@infradead.org/
> for where we're going; the first four patches in that series are the
> same as the four patches in this series, and I've split them out here
> for your convenience.
>
> Matthew Wilcox (Oracle) (4):
> f2fs: Remove check for ->writepage
> f2fs: Remove f2fs_write_data_page()
> f2fs: Remove f2fs_write_meta_page()
> f2fs: Remove f2fs_write_node_page()
>
> fs/f2fs/checkpoint.c | 7 -------
> fs/f2fs/data.c | 28 ----------------------------
> fs/f2fs/node.c | 8 --------
> 3 files changed, 43 deletions(-)
>
> --
> 2.47.2
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Chao Yu <chao@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 0/4] f2fs: Remove uses of writepage
Date: Fri, 7 Mar 2025 20:39:56 +0000 [thread overview]
Message-ID: <Z8tZnN-CAS20Dpi7@google.com> (raw)
In-Reply-To: <20250307182151.3397003-1-willy@infradead.org>
On 03/07, Matthew Wilcox (Oracle) wrote:
> I was planning on sending this next cycle, but maybe there's time to
> squeeze these patches into the upcoming merge window?
>
> f2fs already implements writepages and migrate_folio for all three
> address_space_operations, so either ->writepage will never be called (by
> migration) or it will only be harmful (if called from pageout()).
My tree sitting on [1] doesn't have mm-next, which looks difficult to test this
series for test alone. Matthew, can you point which patches I need to apply
in mm along with this for test?
[1] f286757b644c "Merge tag 'timers-urgent-2025-02-03' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip"
>
> The only remaining filesystem with ->writepage defined in next-20250307
> is vboxsf, so the concept of removing ->writepage is well proven. I
> have some follow-up patches which simplify f2fs writeback afterwards,
> but I think we can postpone them to next cycle.
>
> See
> https://lore.kernel.org/linux-fsdevel/20250307135414.2987755-1-willy@infradead.org/
> for where we're going; the first four patches in that series are the
> same as the four patches in this series, and I've split them out here
> for your convenience.
>
> Matthew Wilcox (Oracle) (4):
> f2fs: Remove check for ->writepage
> f2fs: Remove f2fs_write_data_page()
> f2fs: Remove f2fs_write_meta_page()
> f2fs: Remove f2fs_write_node_page()
>
> fs/f2fs/checkpoint.c | 7 -------
> fs/f2fs/data.c | 28 ----------------------------
> fs/f2fs/node.c | 8 --------
> 3 files changed, 43 deletions(-)
>
> --
> 2.47.2
next prev parent reply other threads:[~2025-03-07 20:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-07 18:21 [f2fs-dev] [PATCH 0/4] f2fs: Remove uses of writepage Matthew Wilcox (Oracle)
2025-03-07 18:21 ` Matthew Wilcox (Oracle)
2025-03-07 18:21 ` [f2fs-dev] [PATCH 1/4] f2fs: Remove check for ->writepage Matthew Wilcox (Oracle)
2025-03-07 18:21 ` Matthew Wilcox (Oracle)
2025-03-11 11:48 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-03-11 11:48 ` Chao Yu
2025-03-07 18:21 ` [f2fs-dev] [PATCH 2/4] f2fs: Remove f2fs_write_data_page() Matthew Wilcox (Oracle)
2025-03-07 18:21 ` Matthew Wilcox (Oracle)
2025-03-11 11:48 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-03-11 11:48 ` Chao Yu
2025-03-07 18:21 ` [f2fs-dev] [PATCH 3/4] f2fs: Remove f2fs_write_meta_page() Matthew Wilcox (Oracle)
2025-03-07 18:21 ` Matthew Wilcox (Oracle)
2025-03-11 11:49 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-03-11 11:49 ` Chao Yu
2025-03-07 18:21 ` [f2fs-dev] [PATCH 4/4] f2fs: Remove f2fs_write_node_page() Matthew Wilcox (Oracle)
2025-03-07 18:21 ` Matthew Wilcox (Oracle)
2025-03-11 11:49 ` [f2fs-dev] " Chao Yu via Linux-f2fs-devel
2025-03-11 11:49 ` Chao Yu
2025-03-07 20:39 ` Jaegeuk Kim via Linux-f2fs-devel [this message]
2025-03-07 20:39 ` [PATCH 0/4] f2fs: Remove uses of writepage Jaegeuk Kim
2025-03-07 20:48 ` [f2fs-dev] " Matthew Wilcox
2025-03-07 20:48 ` Matthew Wilcox
2025-03-07 22:13 ` [f2fs-dev] " Jaegeuk Kim via Linux-f2fs-devel
2025-03-07 22:13 ` Jaegeuk Kim
2025-03-11 19:50 ` [f2fs-dev] " patchwork-bot+f2fs--- via Linux-f2fs-devel
2025-03-11 19:50 ` patchwork-bot+f2fs
2025-03-12 0:18 ` Matthew Wilcox
2025-03-12 0:18 ` Matthew Wilcox
2025-03-12 1:22 ` Jaegeuk Kim via Linux-f2fs-devel
2025-03-12 1:22 ` Jaegeuk Kim
2025-03-14 15:57 ` Matthew Wilcox
2025-03-14 15:57 ` Matthew Wilcox
2025-03-14 21:38 ` Jaegeuk Kim via Linux-f2fs-devel
2025-03-14 21:38 ` Jaegeuk Kim
2025-03-26 3:37 ` Matthew Wilcox
2025-03-26 3:37 ` Matthew Wilcox
2025-03-27 22:27 ` Jaegeuk Kim via Linux-f2fs-devel
2025-03-27 22:27 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z8tZnN-CAS20Dpi7@google.com \
--to=linux-f2fs-devel@lists.sourceforge.net \
--cc=jaegeuk@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.