From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Netfilter Development <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH libnetfilter_queue] src: doc: Re-order gcc args so nf-queue.c compiles on Debian systems
Date: Fri, 21 Mar 2025 11:26:02 +0100 [thread overview]
Message-ID: <Z90-ujnsHlFRH4P3@calendula> (raw)
In-Reply-To: <Z9zHjBkgCDyPiBoN@slk15.local.net>
On Fri, Mar 21, 2025 at 12:57:32PM +1100, Duncan Roe wrote:
> Hi Pablo,
>
> On Thu, Mar 20, 2025 at 07:42:12AM +1100, Duncan Roe wrote:
> > Hi Pablo,
> >
> > On Wed, Mar 19, 2025 at 10:28:52AM +0100, Pablo Neira Ayuso wrote:
> > > On Wed, Mar 19, 2025 at 11:56:05AM +1100, Duncan Roe wrote:
> > > > * Simple compile line:
> > > > * \verbatim
> > > > -gcc -g3 -ggdb -Wall -lmnl -lnetfilter_queue -o nf-queue nf-queue.c
> > > > +gcc -g3 -gdwarf-4 -Wall nf-queue.c -o nf-queue -lnetfilter_queue -lmnl
> > >
> > > I am going t remove -g3 and -gdwarf-4, so it ends up with:
> > >
> > > gcc -Wall nf-queue.c -o nf-queue -lnetfilter_queue -lmnl
> >
> > That makes nonsense of the previous line:
> >
> > | you should start by reading (or, if feasible, compiling and stepping through with gdb) nf-queue.c
> >
> > You can only step through nf-queue.c if you compile with the debug options.
> >
> > Please leave them there.
> ^^^^^^ ^^^^^ ^^^^ ^^^^^^
> You chose to ignore this or maybe you just missed it?
none of them, just disagreement.
> I can send a patch to remove the reference to gdb in the previous paragraph or I
> can send a patch to reinstate the gcc debug options. Which would you prefer?
developers are familiar with debugging tools, there are more choices
that gdb, -g is a "popular" flag, there is no need to document that
many gcc options in the documentation, just a "Simple compile line" is
fine.
I very much apologize for the discomfort this rises on you.
Thanks.
prev parent reply other threads:[~2025-03-21 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 0:56 [PATCH libnetfilter_queue] src: doc: Re-order gcc args so nf-queue.c compiles on Debian systems Duncan Roe
2025-03-19 9:28 ` Pablo Neira Ayuso
2025-03-19 20:42 ` Duncan Roe
2025-03-21 1:57 ` Duncan Roe
2025-03-21 10:26 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z90-ujnsHlFRH4P3@calendula \
--to=pablo@netfilter.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.