From: Duncan Roe <duncan_roe@optusnet.com.au>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Netfilter Development <netfilter-devel@vger.kernel.org>
Subject: Re: [PATCH libnetfilter_queue] src: doc: Re-order gcc args so nf-queue.c compiles on Debian systems
Date: Thu, 20 Mar 2025 07:42:12 +1100 [thread overview]
Message-ID: <Z9ssJMKDJDetdYV2@slk15.local.net> (raw)
In-Reply-To: <Z9qOVEObhFzmVKx6@calendula>
Hi Pablo,
On Wed, Mar 19, 2025 at 10:28:52AM +0100, Pablo Neira Ayuso wrote:
> On Wed, Mar 19, 2025 at 11:56:05AM +1100, Duncan Roe wrote:
> > Change the order of gcc arguments following the discussion starting at
> > https://www.spinics.net/lists/netfilter-devel/msg90612.html.
> > While being about it, update the obsolete -ggdb debug option to -gdwarf-4.
> >
> > Reported-by: "G.W. Haywood" <ged@jubileegroup.co.uk>
> > Fixes: f0eb6a9c15a5 ("src: doc: Update the Main Page to be nft-focussed")
> > Signed-off-by: Duncan Roe <duncan_roe@optusnet.com.au>
> > ---
> > src/libnetfilter_queue.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/libnetfilter_queue.c b/src/libnetfilter_queue.c
> > index f152efb..99799c0 100644
> > --- a/src/libnetfilter_queue.c
> > +++ b/src/libnetfilter_queue.c
> > @@ -86,7 +86,7 @@
> > * nf-queue.c source file.
> > * Simple compile line:
> > * \verbatim
> > -gcc -g3 -ggdb -Wall -lmnl -lnetfilter_queue -o nf-queue nf-queue.c
> > +gcc -g3 -gdwarf-4 -Wall nf-queue.c -o nf-queue -lnetfilter_queue -lmnl
>
> I am going t remove -g3 and -gdwarf-4, so it ends up with:
>
> gcc -Wall nf-queue.c -o nf-queue -lnetfilter_queue -lmnl
That makes nonsense of the previous line:
| you should start by reading (or, if feasible, compiling and stepping through with gdb) nf-queue.c
You can only step through nf-queue.c if you compile with the debug options.
Please leave them there.
Cheers ... Duncan.
next prev parent reply other threads:[~2025-03-19 20:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 0:56 [PATCH libnetfilter_queue] src: doc: Re-order gcc args so nf-queue.c compiles on Debian systems Duncan Roe
2025-03-19 9:28 ` Pablo Neira Ayuso
2025-03-19 20:42 ` Duncan Roe [this message]
2025-03-21 1:57 ` Duncan Roe
2025-03-21 10:26 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9ssJMKDJDetdYV2@slk15.local.net \
--to=duncan_roe@optusnet.com.au \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.