From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Woudstra <ericwouds@gmail.com>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Kuniyuki Iwashima <kuniyu@amazon.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Roopa Prabhu <roopa@nvidia.com>, Ivan Vecera <ivecera@redhat.com>,
Jiri Pirko <jiri@resnulli.us>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
Simon Horman <horms@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Andrew Lunn <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
bridge@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-hardening@vger.kernel.org, Kees Cook <kees@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Ahmed Zaki <ahmed.zaki@intel.com>,
Vladimir Oltean <olteanv@gmail.com>,
Frank Wunderlich <frank-w@public-files.de>,
Daniel Golle <daniel@makrotopia.org>
Subject: Re: [PATCH v9 nf 00/15] bridge-fastpath and related improvements
Date: Fri, 14 Mar 2025 13:37:43 +0100 [thread overview]
Message-ID: <Z9QjF5LhavodVA4Y@calendula> (raw)
In-Reply-To: <02b97708-1214-4fa4-a011-70388cff8f79@gmail.com>
On Thu, Mar 13, 2025 at 07:01:38PM +0100, Eric Woudstra wrote:
>
>
> On 3/13/25 12:11 AM, Pablo Neira Ayuso wrote:
>
> >> What do you suggest?
> >
> > Probably I can collect 4/15 and 5/15 from this series to be included
> > in the next pull request, let me take a look. But it would be good to
> > have tests for these two patches.
> >
>
> These are not most important to bridge-fastpath, but it gives extra
> possibilities. How about concentrating first on patch 2/15 (with 1/15
> removing a warning and 3/15 cleaning up), adding nf_flow_encap_push()
> for xmit direct? It is a vital patch for the bridge-fastpath.
I see cleanup patch 3/15 is a consequence of 2/15, let me take a look.
> Anyway, I will look into writing selftests for conntrack-bridge setup,
> including various vlan setups. This will take me some time, which I
> do not have in abundance, so for that I do not know if I get it done
> before the merge window.
There is tools/testing/selftests/net/netfilter/nft_flowtable.sh that
can possibly be extended to improve coverage.
Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Eric Woudstra <ericwouds@gmail.com>
Cc: Kees Cook <kees@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Ahmed Zaki <ahmed.zaki@intel.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Eric Dumazet <edumazet@google.com>,
linux-hardening@vger.kernel.org, Ivan Vecera <ivecera@redhat.com>,
Alexander Lobakin <aleksander.lobakin@intel.com>,
Jozsef Kadlecsik <kadlec@netfilter.org>,
coreteam@netfilter.org, Roopa Prabhu <roopa@nvidia.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Nikolay Aleksandrov <razor@blackwall.org>,
Jiri Pirko <jiri@resnulli.us>,
bridge@lists.linux.dev, Kuniyuki Iwashima <kuniyu@amazon.com>,
linux-mediatek@lists.infradead.org,
Daniel Golle <daniel@makrotopia.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Andrew Lunn <andrew+netdev@lunn.ch>,
netfilter-devel@vger.kernel.org, Simon Horman <horms@kernel.org>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v9 nf 00/15] bridge-fastpath and related improvements
Date: Fri, 14 Mar 2025 13:37:43 +0100 [thread overview]
Message-ID: <Z9QjF5LhavodVA4Y@calendula> (raw)
In-Reply-To: <02b97708-1214-4fa4-a011-70388cff8f79@gmail.com>
On Thu, Mar 13, 2025 at 07:01:38PM +0100, Eric Woudstra wrote:
>
>
> On 3/13/25 12:11 AM, Pablo Neira Ayuso wrote:
>
> >> What do you suggest?
> >
> > Probably I can collect 4/15 and 5/15 from this series to be included
> > in the next pull request, let me take a look. But it would be good to
> > have tests for these two patches.
> >
>
> These are not most important to bridge-fastpath, but it gives extra
> possibilities. How about concentrating first on patch 2/15 (with 1/15
> removing a warning and 3/15 cleaning up), adding nf_flow_encap_push()
> for xmit direct? It is a vital patch for the bridge-fastpath.
I see cleanup patch 3/15 is a consequence of 2/15, let me take a look.
> Anyway, I will look into writing selftests for conntrack-bridge setup,
> including various vlan setups. This will take me some time, which I
> do not have in abundance, so for that I do not know if I get it done
> before the merge window.
There is tools/testing/selftests/net/netfilter/nft_flowtable.sh that
can possibly be extended to improve coverage.
Thanks.
next prev parent reply other threads:[~2025-03-14 12:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 10:29 [PATCH v9 nf 00/15] bridge-fastpath and related improvements Eric Woudstra
2025-03-05 10:29 ` [PATCH v9 nf 01/15] net: pppoe: avoid zero-length arrays in struct pppoe_hdr Eric Woudstra
2025-03-05 10:29 ` [PATCH v9 nf 02/15] netfilter: nf_flow_table_offload: Add nf_flow_encap_push() for xmit direct Eric Woudstra
2025-03-05 10:29 ` [PATCH v9 nf 03/15] netfilter: flow: remove hw_outdev, out.hw_ifindex and out.hw_ifidx Eric Woudstra
2025-03-05 10:29 ` [PATCH v9 nf 04/15] netfilter: bridge: Add conntrack double vlan and pppoe Eric Woudstra
2025-03-05 10:29 ` [PATCH v9 nf 05/15] netfilter: nft_chain_filter: Add bridge " Eric Woudstra
2025-03-05 10:29 ` [PATCH v9 nf 06/15] bridge: Add filling forward path from port to port Eric Woudstra
2025-03-05 10:29 ` [PATCH v9 nf 07/15] net: core: dev: Add dev_fill_bridge_path() Eric Woudstra
2025-03-05 10:29 ` [PATCH v9 nf 08/15] netfilter :nf_flow_table_offload: Add nf_flow_rule_bridge() Eric Woudstra
2025-03-05 10:29 ` [PATCH v9 nf 09/15] netfilter: nf_flow_table_inet: Add nf_flowtable_type flowtable_bridge Eric Woudstra
2025-03-05 10:29 ` [PATCH v9 nf 10/15] netfilter: nft_flow_offload: Add NFPROTO_BRIDGE to validate Eric Woudstra
2025-03-05 10:29 ` [PATCH v9 nf 11/15] netfilter: nft_flow_offload: Add DEV_PATH_MTK_WDMA to nft_dev_path_info() Eric Woudstra
2025-03-05 10:29 ` [PATCH v9 nf 12/15] netfilter: nft_flow_offload: No ingress_vlan forward info for dsa user port Eric Woudstra
2025-03-05 10:29 ` [PATCH v9 nf 13/15] bridge: No DEV_PATH_BR_VLAN_UNTAG_HW for dsa foreign Eric Woudstra
2025-03-05 10:29 ` [PATCH v9 nf 14/15] bridge: Introduce DEV_PATH_BR_VLAN_KEEP_HW for bridge-fastpath Eric Woudstra
2025-03-05 10:29 ` [PATCH v9 nf 15/15] netfilter: nft_flow_offload: Add bridgeflow to nft_flow_offload_eval() Eric Woudstra
2025-03-11 8:22 ` [PATCH v9 nf 00/15] bridge-fastpath and related improvements Eric Woudstra
2025-03-11 8:22 ` Eric Woudstra
2025-03-11 23:44 ` Pablo Neira Ayuso
2025-03-11 23:44 ` Pablo Neira Ayuso
2025-03-12 16:21 ` Eric Woudstra
2025-03-12 16:21 ` Eric Woudstra
2025-03-12 23:11 ` Pablo Neira Ayuso
2025-03-12 23:11 ` Pablo Neira Ayuso
2025-03-13 18:01 ` Eric Woudstra
2025-03-13 18:01 ` Eric Woudstra
2025-03-14 12:37 ` Pablo Neira Ayuso [this message]
2025-03-14 12:37 ` Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9QjF5LhavodVA4Y@calendula \
--to=pablo@netfilter.org \
--cc=ahmed.zaki@intel.com \
--cc=aleksander.lobakin@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bigeasy@linutronix.de \
--cc=bridge@lists.linux.dev \
--cc=coreteam@netfilter.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericwouds@gmail.com \
--cc=frank-w@public-files.de \
--cc=gustavoars@kernel.org \
--cc=horms@kernel.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kadlec@netfilter.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.