Re: [PATCH v8 5/5] iommufd/selftest: Add coverage for reporting max_pasid_log2 via IOMMU_HW_INFO

[Nicolin Chen <nicolinc@nvidia.com>]

On Thu, Mar 13, 2025 at 05:47:53AM -0700, Yi Liu wrote:
> IOMMU_HW_INFO is extended to report max_pasid_log2, hence add coverage
> for it.
> 
> Signed-off-by: Yi Liu <yi.l.liu@intel.com>

Reviewed-by: Nicolin Chen <nicolinc@nvidia.com>

Two nits:

> @@ -342,12 +342,14 @@ FIXTURE(iommufd_ioas)
>  	uint32_t hwpt_id;
>  	uint32_t device_id;
>  	uint64_t base_iova;
> +	uint32_t pasid_device_id;

Maybe "device_pasid_id", matching with "MOCK_FLAGS_DEVICE_PASID"?

> +		if (variant->pasid_capable) {
> +			test_cmd_get_hw_info_pasid(self->pasid_device_id,
> +						   &max_pasid);
> +			ASSERT_EQ(20, max_pasid);

Maybe add a define in the iommufd_test.h file? Since the selftest
in the kernel needs to provide a "20" also.

Thanks
Nicolin