From: Nicolin Chen <nicolinc@nvidia.com>
To: Jason Gunthorpe <jgg@nvidia.com>
Cc: Yi Liu <yi.l.liu@intel.com>, <alex.williamson@redhat.com>,
<kevin.tian@intel.com>, <eric.auger@redhat.com>,
<kvm@vger.kernel.org>, <chao.p.peng@linux.intel.com>,
<zhenzhong.duan@intel.com>, <willy@infradead.org>,
<zhangfei.gao@linaro.org>, <vasant.hegde@amd.com>
Subject: Re: [PATCH v8 4/5] iommufd: Extend IOMMU_GET_HW_INFO to report PASID capability
Date: Thu, 20 Mar 2025 13:02:54 -0700 [thread overview]
Message-ID: <Z9x0AFJkrfWMGLsV@Asurada-Nvidia> (raw)
In-Reply-To: <20250320185726.GF206770@nvidia.com>
On Thu, Mar 20, 2025 at 03:57:26PM -0300, Jason Gunthorpe wrote:
> On Thu, Mar 20, 2025 at 09:47:32AM -0700, Nicolin Chen wrote:
>
> > In that regard, honestly, I don't quite get this out_capabilities.
>
> Yeah, I think it is best thought of as place to put discoverability if
> people want discoverability.
>
> I have had a wait and see feeling in this area since I don't know what
> qemu or libvirt would actually use.
Both ARM and Intel have max_pasid_log2 being reported somewhere
in their vendor data structures. So, unless user space really
wants that info immediately without involving the vendor IOMMU,
this max_pasid_log2 seems to be redundant.
Also, this patch polls two IOMMU caps out of pci_pasid_status()
that is a per device function. Is this okay? Can it end up with
two devices (one has PASID; the other doesn't) behind the same
IOMMU reporting two different sets of out_capabilities, which
were supposed to be the same since it the same IOMMU HW?
Thanks
Nicolin
next prev parent reply other threads:[~2025-03-20 20:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 12:47 [PATCH v8 0/5] vfio-pci support pasid attach/detach Yi Liu
2025-03-13 12:47 ` [PATCH v8 1/5] ida: Add ida_find_first_range() Yi Liu
2025-03-13 12:47 ` [PATCH v8 2/5] vfio-iommufd: Support pasid [at|de]tach for physical VFIO devices Yi Liu
2025-03-13 12:47 ` [PATCH v8 3/5] vfio: VFIO_DEVICE_[AT|DE]TACH_IOMMUFD_PT support pasid Yi Liu
2025-03-19 17:41 ` Nicolin Chen
2025-03-20 12:37 ` Yi Liu
2025-03-13 12:47 ` [PATCH v8 4/5] iommufd: Extend IOMMU_GET_HW_INFO to report PASID capability Yi Liu
2025-03-17 7:18 ` Yi Liu
2025-03-19 17:58 ` Nicolin Chen
2025-03-20 12:48 ` Yi Liu
2025-03-20 16:47 ` Nicolin Chen
2025-03-20 18:57 ` Jason Gunthorpe
2025-03-20 20:02 ` Nicolin Chen [this message]
2025-03-20 23:40 ` Jason Gunthorpe
2025-03-20 23:48 ` Nicolin Chen
2025-03-21 4:27 ` Nicolin Chen
2025-03-21 17:37 ` Yi Liu
2025-03-21 18:29 ` Nicolin Chen
2025-03-21 18:42 ` Jason Gunthorpe
2025-03-21 19:00 ` Nicolin Chen
2025-03-13 12:47 ` [PATCH v8 5/5] iommufd/selftest: Add coverage for reporting max_pasid_log2 via IOMMU_HW_INFO Yi Liu
2025-03-19 18:12 ` Nicolin Chen
2025-03-14 14:48 ` [PATCH v8 0/5] vfio-pci support pasid attach/detach Alex Williamson
2025-03-17 7:25 ` Yi Liu
2025-03-17 19:28 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z9x0AFJkrfWMGLsV@Asurada-Nvidia \
--to=nicolinc@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@linux.intel.com \
--cc=eric.auger@redhat.com \
--cc=jgg@nvidia.com \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=vasant.hegde@amd.com \
--cc=willy@infradead.org \
--cc=yi.l.liu@intel.com \
--cc=zhangfei.gao@linaro.org \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.